Favourite (Personal) Tab

[Mystery]

Hey everyone! The current favourite (personal) tab diff that's here is a little bit outdated and all crunched together with the cart and sitting diffs which is no longer needed because rAthena already supports both.

Currently no need for this anymore since it's been already implemented into rAthena: http://trac.rathena.org/changeset/16518/rathena. Deleted it from my SVN as you can see why here: https://code.google.com/p/mysterious-project/source/detail?r=131

[Lelouch vi Britannia]

Uhmmm i tryed your patch also im using r16503 but there is a lil bit problem in clif.h

clif.h Original (Line 465 and 466)

void clif_cart_delitem(struct map_session_data *sd,int n,int amount);
void clif_cartlist(struct map_session_data *sd);

clif.h Patched (Line 465)

void clif_cart_delitem(struct map_session_data *sd,int n,int amount);void clif_cartlist(struct map_session_data *sd);

Also Rejected patch hunks in clif.c

--- src/map/clif.c
+++ src/map/clif.c
@@ -2202,9 +2204,12 @@
 }

 WFIFOSET(fd,packet_len(cmd));
+#if PACKETVER >= 20111122
+ if ( sd->status.inventory[n].favorite )
+ clif_favorite_item(sd, n);
+#endif
}

@@ -2367,7 +2371,16 @@
 WBUFW(bufe,2)=4+ne*se;
 clif_send(bufe, WBUFW(bufe,2), &sd->bl, SELF);

Edited July 26, 2012 by Lelouch vi Britannia

[Mystery]

DId you manually add it or applied it with Tortoise? Since my server has a lot of mods in it, I had to delete some parts are that weren't related to the Favourite Tab diff. So, I guess since I deleted some stuff from within the diff, if you try to automatically add it in, there might be a problem.

Also, I manually added it in and I didn't get errors in my compiling.

[onizame]

[onizame2823@localhost ~]$ patch -Np0 -d rAthena < FavouriteTab.patch
(Stripping trailing CRs from patch.)
patching file src/char/char.c
patching file src/common/mmo.h
patch: **** malformed patch at line 122: Index: src/map/clif.c

is this ok? SVN ver 16509

[Lelouch vi Britannia]

DId you manually add it or applied it with Tortoise? Since my server has a lot of mods in it, I had to delete some parts are that weren't related to the Favourite Tab diff. So, I guess since I deleted some stuff from within the diff, if you try to automatically add it in, there might be a problem.

Also, I manually added it in and I didn't get errors in my compiling.

I think that i guess should be the problem .yeah i added it automatically in my SVN via tortoise .i havent tryed adding it manually .well i guess i should try it now .Thanks Myst

[Mystery]

[onizame2823@localhost ~]$ patch -Np0 -d rAthena < FavouriteTab.patch
(Stripping trailing CRs from patch.)
patching file src/char/char.c
patching file src/common/mmo.h
patch: **** malformed patch at line 122: Index: src/map/clif.c

is this ok? SVN ver 16509

As I mentioned:

DId you manually add it or applied it with Tortoise? Since my server has a lot of mods in it, I had to delete some parts are that weren't related to the Favourite Tab diff. So, I guess since I deleted some stuff from within the diff, if you try to automatically add it in, there might be a problem.

DId you manually add it or applied it with Tortoise? Since my server has a lot of mods in it, I had to delete some parts are that weren't related to the Favourite Tab diff. So, I guess since I deleted some stuff from within the diff, if you try to automatically add it in, there might be a problem.

Also, I manually added it in and I didn't get errors in my compiling.

I think that i guess should be the problem .yeah i added it automatically in my SVN via tortoise .i havent tryed adding it manually .well i guess i should try it now .Thanks Myst

Thank you. When I have time, I'll add the patch to a cleaner version of rAthena so that a .diff patch can be automatically patched.