Cases in Arrays

[iFoxkun]

gm02,96,99,4 script Professor Oak 793,{


mes "Hello, Welcome to the world of Pokemon";
next;
mes "We, Pokemon Trainers, reside in this world in peace with Pokemon";
next;
mes "Which starter Pokemon do you wish to have?";
set .@menu, select(.pkmn_menu$) -1;
if(.pkmn_menu$[0] == .pkmn$[0]):
mes "You choose " +.pkmn$[0]+ "?";

OnInit:
setarray .pkmn$,"Bulbasaur","Charmander","Squirtle";
for ( set .@i, 0; .@i < getarraysize(.pkmn$); set .@i, .@i +1 )
setarray .pkmntype$,"Grass","Fire","Water";
for ( set .@i, 0; .@i < getarraysize(.pkmntype$); set .@i, .@i +1 )
set .pkmn_menu$, .pkmn_menu$ + (.pkmn$[.@i]) + " - " + (.pkmntype$[.@i]) +":";
}

The one text bolded, How do i make it, if a player selects option 1, Bulbasaur, it says something?

This one : if(.pkmn_menu$[0] == .pkmn$[0]):

Edited December 11, 2011 by iFoxkun

[plankt]

The decrement of .menu was if it was supposed to index an array (since arrays start their indexing at 0, not 1). Using it with switch, which itself can handle whatever order you choose, you don't want to '-1'.

set .menu, select(.pkmn_menu$) -1;

Would make your first choice 0, then you check for 'case 1' which wants a 1. Solved by not having '-1'.

You do not terminate the script with a 'close;'. It will therefore continue after the menu down to the OnInit once again and continue to build the menu.

It's always good coding standard to make sure that an 'end' or 'close' is placed at the end of the NPC, but before On<Event> labels, in case you miss to terminate the user somewhere on the way.

Edited December 11, 2011 by plankt

[plankt]

'select' returns an index for the selection the user made.

1 for the first alternative, 2 for the second and so on... (or if it begins on 0, can't remember)

You can just use that to index the correct pokemon in the .pkmn$ array: (-1 if it starts on 1, since arrays count from 0)

if( .pkmn$[.@menu-1] == "Bulbasaur" ) ...

Or if you don't want to go for names, use the index directly:

switch( .@menu ){
case 1:
Bulbasaur code
break;
case 2:
Charmander code
break;
case 3:
Squirtle code
break;
}

You only need one for loop in the OnInit aswell:

OnInit:
setarray .pkmn$,"Bulbasaur","Charmander","Squirtle";
setarray .pkmntype$,"Grass","Fire","Water";
for ( set .@i, 0; .@i < getarraysize(.pkmntype$); set .@i, .@i +1 )
set .pkmn_menu$, .pkmn_menu$ + (.pkmn$[.@i]) + " - " +...

[iFoxkun]

'select' returns an index for the selection the user made.

1 for the first alternative, 2 for the second and so on... (or if it begins on 0, can't remember)

You can just use that to index the correct pokemon in the .pkmn$ array: (-1 if it starts on 1, since arrays count from 0)

if( .pkmn$[.@menu-1] == "Bulbasaur" ) ...

Or if you don't want to go for names, use the index directly:

switch( .@menu ){
case 1:
Bulbasaur code
break;
case 2:
Charmander code
break;
case 3:
Squirtle code
break;
}

You only need one for loop in the OnInit aswell:

OnInit:
setarray .pkmn$,"Bulbasaur","Charmander","Squirtle";
setarray .pkmntype$,"Grass","Fire","Water";
for ( set .@i, 0; .@i < getarraysize(.pkmntype$); set .@i, .@i +1 )
set .pkmn_menu$, .pkmn_menu$ + (.pkmn$[.@i]) + " - " +...

I tried the second option. The case 1 etc doesn't work and when I close it, the menu option multiplies:

gm02,96,99,4 script Professor Oak 793,{


mes "Hello, Welcome to the world of Pokemon";
next;
mes "We, Pokemon Trainers, reside in this world in peace with Pokemon";
next;
L_SelectPkmn:
mes "Which starter Pokemon do you wish to have?";
set .menu, select(.pkmn_menu$) -1;
switch( .menu ) {
case 1: 
next;
mes "You choose " +.pkmn$[0]+ "?";
if(select("Yes:No")==2) goto L_SelectPkmn;


}
OnInit:
setarray .pkmn$,"Bulbasaur","Charmander","Squirtle";
setarray .pkmntype$,"Grass","Fire","Water";
for ( set .@i, 0; .@i < getarraysize(.pkmn$); set .@i, .@i +1 ) 
set .pkmn_menu$, .pkmn_menu$ + (.pkmn$[.@i]) + " - " + (.pkmntype$[.@i]) +":";
}

[iFoxkun]

YES <333 THANK YOUUUU xD. I forgot i put a -1 there -.-. SO STUPID HUH? xD