There was a debate on GitHub for rAthena—let’s go over the conclusion.

[Scriptreload]

There was a debate on GitHub for rAthena—let’s go over the conclusion.

Here’s what happened:
A team member encountered an issue while playing the game related to an NPC shop, specifically the one at prt_in,162,135. The issue they reported was that if they opened the shop to view the item list but pressed the Cancel button without purchasing anything, their character became unable to move.

Now, the question is: Has anyone else experienced this issue?
Most likely not, because this NPC has been around for a long time. As another person pointed out, if there were really an issue, someone would have reported it before.

To support their claim, they provided a comparison image showing that the script in the master file (before any modification) was identical to the updated version. So, they pressed the issue further: What exactly changed with this update?

In the end, it turned out that only one person had the issue, but instead of acknowledging that they might have made a mistake (or forgotten to use the correct master file), they blamed the script. So, now everyone is invited to look at the images and compare: Was there really a difference before and after the update? Or is someone refusing to admit their mistake and instead blaming the master script, even though it has been working just fine? Take a look at the images and judge for yourself.

So, in the end, how am I supposed to update it? I opened my file to check, and it’s exactly the same. That’s what I find funny!

I apologize, but I don’t know where I should post this or under which category.

[Chaos92]

1 hour ago, Scriptreload said:

There was a debate on GitHub for rAthena—let’s go over the conclusion.

Here’s what happened:
A team member encountered an issue while playing the game related to an NPC shop, specifically the one at prt_in,162,135. The issue they reported was that if they opened the shop to view the item list but pressed the Cancel button without purchasing anything, their character became unable to move.

Now, the question is: Has anyone else experienced this issue?
Most likely not, because this NPC has been around for a long time. As another person pointed out, if there were really an issue, someone would have reported it before.

To support their claim, they provided a comparison image showing that the script in the master file (before any modification) was identical to the updated version. So, they pressed the issue further: What exactly changed with this update?

In the end, it turned out that only one person had the issue, but instead of acknowledging that they might have made a mistake (or forgotten to use the correct master file), they blamed the script. So, now everyone is invited to look at the images and compare: Was there really a difference before and after the update? Or is someone refusing to admit their mistake and instead blaming the master script, even though it has been working just fine? Take a look at the images and judge for yourself.

So, in the end, how am I supposed to update it? I opened my file to check, and it’s exactly the same. That’s what I find funny!

I apologize, but I don’t know where I should post this or under which category.

I already replied to this git comments.

And i replied again here why.

its already changed 3 weeks ago (9 march 2025) so if people using latest rathena before that commit, will have that issue.

https://github.com/rathena/rathena/blob/6ac181503f9317692521bde0073cb8e5c6b14fa6/npc/re/merchants/Extended_Ammunition.txt

See that file before that commit.  that commit happens 3 weeks ago which is 9 march 2025. it changed this file.

https://github.com/rathena/rathena/commit/139ea0b5b393c3b19b07103245c16f756a2b8d2d#diff-1d06ccaac468f1155a6018c8ab3271064538967aac6cd396f43af7e642f7a9c0

They track from official its using close; but in rAthena it doesnt yet supported as Atemo said.

Official script uses "callshop" then "close" for these NPCs, but rAthena doesn't currently support this. That's why these scripts have been modified/reverted (hopefully temporarily) in 11d373a

So if you are downloading this rathena since before this PR update around 48hours ago till last 3 weeks, the debug warning will appear.

If you didnt believe it, try to download rAthena dated around 2 weeks ago, and try. Or try update that rAthena just a few days after 8 March 2025.

Edited March 27 by Chaos92
additional info

[Scriptreload]

Are you sure? Are you really sure about that? Then take a look at my file.

In my country, the year is 2567, now 2568 = 2025 which corresponds to 2024. The file in this clip is dated 13/11/2024.

I've been using it for a long time, which is why I find it funny—what exactly am I supposed to update when everything is already working fine? And what was even changed in the update?

I'm not even the one involved in the issue, but after reading and checking, I see that the other person was right—the file was already fine, so why was it changed? Was the real problem that someone failed to update their own file and then blamed the script instead?
 

 

Edited March 27 by Scriptreload
13/11/2024

[Scriptreload]

Are you accusing me of lying? You can check everything yourself. I've been using it since 13/11/2024.

The person who didn’t do anything wrong has now been made out to be the one at fault. That’s unfortunate.

 

rathena-master.rar

Edited March 27 by Scriptreload

[Chaos92]

29 minutes ago, Scriptreload said:

Are you accusing me of lying? You can check everything yourself. I've been using it since 13/11/2024.

The person who didn’t do anything wrong has now been made out to be the one at fault. That’s unfortunate.

 

rathena-master.rarFetching info...

its on git. so how is it im not sure ? if not just download that rathena 100% from github during that date.

did u know u can revert a few commit back ? then do it and try. 

Download latest rathena, revert 10 commit back, and try. as simple as that.

Just make sure u know how to revert 10 commit back and how to use git.

So what u should do to get the same result is :

 

1. Download latest git rathena

2. Revert 10 latest commit.

3. Retry the issue or see the npc file after u revert 10 commit.

Edited March 27 by Chaos92
additional info

[Scriptreload]

Did you even read the details of what they explained? They already stated that the Master file was correct all along.

They even provided a link, meaning they must have checked it themselves, and they copied an example of the script file to show. The original Master script was indeed correct.

"The key point here is that they explained the file was already correct before the modification, so why change it? Or is the real issue that a single player made a mistake but refused to admit it, instead blaming the script? Even though they provided proof that the script was already correct, it had nothing to do with any file changes from three weeks ago."

The important part is that the Master file was never modified and was always correct—that is the main point I’m summarizing.

And for the record, I check and update GitHub every single day—I repeat, every day—and there has never been any change to the Extended_Ammunition.txt file.

 

Oh, and one more thing—it was never "Merged branch 'master' into master" during that update.

https://github.com/rathena/rathena/pull/9056

This proves that the Extended_Ammunition.txt file in the Master branch has always been correct, just as I showed in my example from 13/11/2024.

 

That’s why I said it’s really funny. When I went to update it and checked the file—surprise! It’s exactly the same.

So what am I supposed to change? I don’t get it. Everything is identical, except for the addition of this line:

// !Fix me: official server uses "callshop" then "close"

Hahahahaha.

Edited March 28 by Scriptreload

[Chaos92]

12 hours ago, Scriptreload said:

Did you even read the details of what they explained? They already stated that the Master file was correct all along.

They even provided a link, meaning they must have checked it themselves, and they copied an example of the script file to show. The original Master script was indeed correct.

"The key point here is that they explained the file was already correct before the modification, so why change it? Or is the real issue that a single player made a mistake but refused to admit it, instead blaming the script? Even though they provided proof that the script was already correct, it had nothing to do with any file changes from three weeks ago."

The important part is that the Master file was never modified and was always correct—that is the main point I’m summarizing.

And for the record, I check and update GitHub every single day—I repeat, every day—and there has never been any change to the Extended_Ammunition.txt file.

 

Oh, and one more thing—it was never "Merged branch 'master' into master" during that update.

https://github.com/rathena/rathena/pull/9056

This proves that the Extended_Ammunition.txt file in the Master branch has always been correct, just as I showed in my example from 13/11/2024.

 

That’s why I said it’s really funny. When I went to update it and checked the file—surprise! It’s exactly the same.

So what am I supposed to change? I don’t get it. Everything is identical, except for the addition of this line:

// !Fix me: official server uses "callshop" then "close"

Hahahahaha.

Oh, and one more thing—it was never "Merged branch 'master' into master" during that update.

https://github.com/rathena/rathena/pull/9056

Bro are you drunk ?

You didnt tried what I said isnt it ?

Then most probably you dont know how to use github and how to revert as I said.

Your screenshot of file also didnt show you did tried during 9 March until that previous PR as per told.

So for what we still discussed here ?

I already show what is the rathena script that changed that and revert back to.

https://github.com/rathena/rathena/commit/139ea0b5b393c3b19b07103245c16f756a2b8d2d#diff-1d06ccaac468f1155a6018c8ab3271064538967aac6cd396f43af7e642f7a9c0

This is the script which is officially from rAthena but before that commit merged : https://github.com/rathena/rathena/blob/6ac181503f9317692521bde0073cb8e5c6b14fa6/npc/re/merchants/Extended_Ammunition.txt

If you didnt know how to use git, learn a bit how to revert and understand why this commit is done.

I already told u to download what date rathena. if you download u will understand the issue.

Or else, good luck and learn more on how to understand how git works.

 

Edited March 28 by Chaos92
additional info

[Chaos92]

Just incase someone have some git understanding issue, did u know u can see file changes by clicking history ?

Then click every commit to see what is actually changes.