Sharp Shooting not criting

[darkdrey]

Hey, everyone!

I`m using the most up-to-date rAthena emulator from GitHub.

Client: 2022-04-06

Mode: Pre-renewal

Both `SN_SHARPSHOOTING` and `MA_SHARPSHOOTING` are set with the `Critical: true` flag in the `skill_db.yml` file.

I didn't change anything in `battle.cpp` or `battle.hpp`. 

 
This is with 4 Critical

Spoiler

 

And this is with 104 Critical

Spoiler

104 Crticial with 3 Paper Cards

Spoiler

 

Thank you very much for your help!

[Playtester]

Sharp Shooting is a special case. It just deals fake critical damage, which only ignores DEF/FLEE but does not actually count as critical damage. So it neither deals max damage nor is increased by "The Paper" card.

Try to test against a monster with very high DEF or FLEE, there you will see the difference.

This is official behavior.

[mir0ma]

On 2/26/2025 at 12:51 PM, Playtester said:

Sharp Shooting is a special case. It just deals fake critical damage, which only ignores DEF/FLEE but does not actually count as critical damage. So it neither deals max damage nor is increased by "The Paper" card.

Try to test against a monster with very high DEF or FLEE, there you will see the difference.

This is official behavior.

Hello, I’m with the same "problem", tested against monsters with def/ flee high and no change using the Paper Card, I entered a server that seems to have the oldest emulator and I can easily notice the difference using Paper Card and not using. If so, is there any way to return functionality as in the old emulators?

[Playtester]

If you really want to restore that bug you can probably just remove the fix for it:

			if (skill_id == SN_SHARPSHOOTING || skill_id == MA_SHARPSHOOTING)
				bflag &= ~(BDMG_CRIT); // Sharpshooting just ignores DEF/FLEE but damage is like a normal attack

 

[mir0ma]

6 hours ago, Playtester said:

If you really want to restore that bug you can probably just remove the fix for it:

			if (skill_id == SN_SHARPSHOOTING || skill_id == MA_SHARPSHOOTING)
				bflag &= ~(BDMG_CRIT); // Sharpshooting just ignores DEF/FLEE but damage is like a normal attack

 

perfect, thank you!