MO_EXTREMITYFIST

[WellStriker]

I'm facing an issue that I can't resolve at all. My emulator is updated with the latest version of rAthena, and the skill MO_EXTREMITYFIST is dealing damage to Ghost element when it should be missing. I've already modified the files attr_fix and battle.cpp, but I couldn't fix the problem. Can someone help me?

[Jarrett Purdy]

On 10/17/2024 at 8:21 AM, WellStriker said:

I'm facing an issue that Undertale Yellow I can't resolve at all. My emulator is updated with the latest version of rAthena, and the skill MO_EXTREMITYFIST is dealing damage to Ghost element when it should be missing. I've already modified the files attr_fix and battle.cpp, but I couldn't fix the problem. Can someone help me?

Thank you for asking us a question, I hope you get a reasonable answer.

[Playtester]

There is a bug in renewal at the moment. The constant_addition bonus is not affected by attr_fix is what's causing it, but I never found something to test Freezing Trap and Shield Chain (Rapid Smiting) to confirm it's also true for those two skills.

Assuming that all these skills should miss Ghost 4 in renewal the fix would be to wrap the attr_fix call around constant_addition.

		// Additive damage bonus
		ATK_ADD(wd.damage, wd.damage2, battle_attr_fix(src, target, battle_calc_skill_constant_addition(&wd, src, target, skill_id, skill_lv), right_element, tstatus->def_ele, tstatus->ele_lv));

 

[Playtester]

Ignore above post, after in-depth testing the correct solution is here: https://github.com/rathena/rathena/pull/8763/files

Will be applied to rAthena soon.