Wrong calculating atk with setunitdata

[nguyenhuy123]

I'm currently use setunitdata to change str,min attk and max attk of a mob like this:

// Save current mob data
getunitdata .GID, .@por_arr;
        
// Cache origin value of mob for the first time to calculate anger later
if (!.origin_sch_data) {
	copyarray .origin_sch_data[0], .@por_arr[0], getarraysize(.@por_arr);
}

set .@newminatk, .origin_sch_data[UMOB_ATKMIN] + .anger_arr[1] * 2;
set .@newmaxatk, .origin_sch_data[UMOB_ATKMAX] + .anger_arr[1] * 2;

setunitdata .GID,UMOB_STR,.origin_sch_data[UMOB_STR] + .anger_arr[1];
setunitdata .GID,UMOB_ATKMIN,.@newminatk;
setunitdata .GID,UMOB_ATKMAX,.@newmaxatk;

But as i log through the command line, i can see that the atk of mob is decreasing instead of increasing:

This is small piece of code i put into setunitdata source code to log:

if (calc_status) {
	status_calc_bl(&md->bl, SCB_BATTLE);
	ShowDebug("log current min-maxatk: %d %d\n", md->status.rhw.atk, md->status.rhw.atk2);
}

Also this is the stat of the mob i spawn:

Is there any wrong with command "setunitdata" for atk calculating?

Another try:  When i increase int, the matk is increase too.

Edited November 30, 2019 by nguyenhuy123

[Seravy]

Get/setunitdata works incorrectly and gets/sets from wrong variables because it doesn't implement renewal changes to stat mechanics properly.

This is what I had to do to make it work for the matk stats : https://github.com/rathena/rathena/pull/3968

I haven't investigated the atk stat yet. However, like matk, the min and max values are calculated. Setting them makes no sense because they are not the base values so they'll be replaced as soon as the unit is recalculated. Monsters only have one base atk value, and it's atk1. atk2 is their base matk stat.

It's really disappointing such basic functionality was remaning broken for this long.

[nguyenhuy123]

On 12/1/2019 at 3:01 AM, Seravy said:

Get/setunitdata works incorrectly and gets/sets from wrong variables because it doesn't implement renewal changes to stat mechanics properly.

This is what I had to do to make it work for the matk stats : https://github.com/rathena/rathena/pull/3968

I haven't investigated the atk stat yet. However, like matk, the min and max values are calculated. Setting them makes no sense because they are not the base values so they'll be replaced as soon as the unit is recalculated. Monsters only have one base atk value, and it's atk1. atk2 is their base matk stat.

It's really disappointing such basic functionality was remaning broken for this long.

Thanks @Seravy, i will take a look on the source.

I don't know why we do this( in status_calc_bl_main function in status.cpp), but this block of code make the str modifier not affect batk anymore( just like +1 then -1):