@gstorage problem with @at

[Fluxion]

Hello to the Rathena community!

I apologize in advance if I post in the wrong place, I am not English and I have a little trouble with the language, as you can see I write to you using google translation.

 

My problem being that one of the players of my private server used the command @autotrade (or @at) having open Guildstorage ... By reconnecting the next day, he can not reopen his Gstorage at all. It tells him that he is already open and that he has to wait for it to be closed by another user to be able to open it. Except he's alone in guild. I try to look in my SQL tables but no way to find a solution to solve the problem. In short, my server considers that the Gstorage is constantly open when it is not. The player just did @at while his Gstorage was open.

 

Has anyone ever had the trouble? And if so how did you solve it? Any help puts precious.

 

Cordially, Yuno.

[Mabuhay]

6 hours ago, Yuno said:

Hello to the Rathena community!

I apologize in advance if I post in the wrong place, I am not English and I have a little trouble with the language, as you can see I write to you using google translation.

 

My problem being that one of the players of my private server used the command @autotrade (or @at) having open Guildstorage ... By reconnecting the next day, he can not reopen his Gstorage at all. It tells him that he is already open and that he has to wait for it to be closed by another user to be able to open it. Except he's alone in guild. I try to look in my SQL tables but no way to find a solution to solve the problem. In short, my server considers that the Gstorage is constantly open when it is not. The player just did @at while his Gstorage was open.

 

Has anyone ever had the trouble? And if so how did you solve it? Any help puts precious.

 

Cordially, Yuno.

Tested and I can confirm to this..

This may not be a solution but more of a prevention for future incidents. Tho untested, this should work.

Go to atcommand.cpp.

Look for this :

ACMD_FUNC(autotrade) {
	nullpo_retr(-1, sd);

	if( map_getmapflag(sd->bl.m, MF_AUTOTRADE) != battle_config.autotrade_mapflag ) {
		clif_displaymessage(fd, msg_txt(sd,1179)); // Autotrade is not allowed on this map.
		return -1;
	}

	if( pc_isdead(sd) ) {
		clif_displaymessage(fd, msg_txt(sd,1180)); // You cannot autotrade when dead.
		return -1;
	}

	if( !sd->state.vending && !sd->state.buyingstore ) { //check if player is vending or buying
		clif_displaymessage(fd, msg_txt(sd,549)); // "You should have a shop open to use @autotrade."
		return -1;
	}

Place this under : 

	if (sd->state.storage_flag == 1) {
		clif_displaymessage(fd, "Close your storage before using @autotrade."); 
		return -1;
	}
	
	if (sd->state.storage_flag == 2) {
		clif_displaymessage(fd, "Close your guild storage before using @autotrade."); 
		return -1;
	}
	
	if (sd->state.storage_flag == 3) {
		clif_displaymessage(fd, "Close your storage before using @autotrade."); 
		return -1;
	}

 

 

[Fluxion]

Thank you for your quick response, I will make this source change right away.

Nobody had this problem then?

Thank's @Mabuhay Source changes worked well.

We are creating a custom command to restore my concerns "@reloadgsto" is a variable that will tell the server that the gstorage was closed