[BUG] Report a source error

[Darkmania2]

Good morning, i like to report one bug,

 

I do not know exactly where to report, so I apologize if it's the wrong place.

Well, i have a BGEamod extansion installed in my server, because of this i make all my source modifications manually once a month,

In uptade "Refactored item bonuses to utilize C++ features" i noticed a big mistake. The bonus of equipments have become cumulative, if you equip and unequip the any weapon you ATK and MATK infinitely increase, leaving just you refresh or log again.

I even thought that i had made some mistake, because of this i make a new download of the last version of rathena and tested the server clean, without changes in source, and the error persisted.

This way i make the modifications manually again using a backup server, but this time i did not use the modifications of this update, and the error did not appear any more.

I don't know what the uptade error, but would like to report and suggest that more people take the test. 

OBS: error occurs using buff skills to.

 

[asg43tgfsa]

status.cpp file 

    // Zero up structures...
    memset(&sd->hp_loss, 0, sizeof(sd->sp_loss)
        + sizeof(sd->hp_loss)    //insert code     
        + sizeof(sd->hp_regen)
        + sizeof(sd->sp_regen)
        + sizeof(sd->percent_hp_regen)
        + sizeof(sd->percent_sp_regen)
        + sizeof(sd->def_set_race)
        + sizeof(sd->mdef_set_race)
        + sizeof(sd->norecover_state_race)
        + sizeof(sd->hp_vanish_race)
        + sizeof(sd->sp_vanish_race)
        + sizeof(sd->bonus)
    );
 

memset mistake

[asg43tgfsa]

But yet
There is still a bug in the source.

I can solve but I have no authority.

Edited December 4, 2018 by asg43tgfsa

[Secrets]

Pull request opened

https://github.com/rathena/rathena/pull/3729