Jump to content
  • 0

scrpt:run_script_main: infinity loop

ryuma1922

Asked by ryuma1922,

 Share

Question

ryuma1922 Poring

ryuma1922

Posted
  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  11
  • Reputation:   0
  • Joined:  06/03/18
  • Last Seen:  
Posted (edited)

Code for me 

function    script    Krathong    {
    getmapxy .@map$,.@x,.@y,0;
    if( .@x >= 57 && .@x <= 79 && .@y == 72 ) set .@pos,1;
    else if( .@x >= 67 && .@x <= 95 && .@y == 51 ) set .@pos,2;
    else end;
    for( set .@i,1; .@i <= 50; set .@i,.@i+1){
        if(!getvariableofnpc(getd(".npcwalkKrathong"+.@i)," #Krathong"+.@i)) {
            set .@npcname$," #Krathong"+.@i;
            break;
        }
        if( .@i == 50 ) end;
    }
    if( .@pos == 1 ) movenpc .@npcname$,.@x,.@y-2;
    else if( .@pos == 2 ) movenpc .@npcname$,.@x,.@y+2;
    mes "[KraThong]";
    mes "อธิษฐาน......";
    input $@MyWish$;
    set $@NameKrathong$,strcharinfo(0);
    donpcevent .@npcname$+"::OnWalk";
    end;
}

loykrathong,0,0,0    script     #Krathong1    3997,{
end;
OnWalk:
    setd ".npcwalk"+strnpcinfo(2),1;
    set .@npcname$,strnpcinfo(0);
    waitingroom $@MyWish$,0;
    setnpcdisplay(strnpcinfo(0), $@NameKrathong$+"#"+strnpcinfo(2));
    npctalk $@MyWish$;
    set .@walkto_x,114;
    set .@walkto_y,rand(53,69);
    npcspeed 1000;
    getmapxy .@map$,.@x,.@y,1;
    if( .@x < 85 ){
        set .@npcx,114-85+.@x;
        while( .@x != .@npcx || .@y != .@walkto_y ){
            getmapxy .@map$,.@x,.@y,1;
            npcwalkto .@npcx,.@walkto_y;
        }
    }
    while( .@x != .@walkto_x || .@y != .@walkto_y ){
        getmapxy .@map$,.@x,.@y,1;
        npcwalkto .@walkto_x,.@walkto_y;
    }
    globalmes getd(".npcwalk"+strnpcinfo(2));
    setd ".npcwalk"+strnpcinfo(2),0;
    setnpcdisplay(" #"+strnpcinfo(2), .@npcname$);
    delwaitingroom;
    movenpc strnpcinfo(0),0,0;
    end;
}
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong2        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong3        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong4        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong5        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong6        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong7        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong8        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong9        3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong10    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong11    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong12    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong13    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong14    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong15    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong16    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong17    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong18    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong19    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong20    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong21    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong22    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong23    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong24    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong25    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong26    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong27    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong28    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong29    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong30    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong31    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong32    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong33    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong34    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong35    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong36    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong37    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong38    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong39    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong40    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong41    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong42    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong43    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong44    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong45    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong46    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong47    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong48    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong49    3997
loykrathong,0,0,0    duplicate( #Krathong1)     #Krathong50    3997

 

Edited by Skorm
Added code box.
Link to comment
Share on other sites

7 answers to this question

Recommended Posts

  • 0
sader1992 Pouring

sader1992

Posted
  • Group:  Content Moderator
  • Topic Count:  55
  • Topics Per Day:  0.01
  • Content Count:  1691
  • Reputation:   716
  • Joined:  12/21/14
  • Last Seen:  
Posted

you are not showing the terminal error (you should have)

i see there is only one loop on your script 

  while( .@x != .@walkto_x || .@y != .@walkto_y ){
        getmapxy .@map$,.@x,.@y,1;
        npcwalkto .@walkto_x,.@walkto_y;
    }

use this command before your loop 

freeloop(1)

and after the loop is done use 

freeloop(0) 

freeloop(1);
  while( .@x != .@walkto_x || .@y != .@walkto_y ){
        getmapxy .@map$,.@x,.@y,1;
        npcwalkto .@walkto_x,.@walkto_y;
    }
freeloop(0);

 

Link to comment
Share on other sites
  • 0
ryuma1922 Poring

ryuma1922

Posted
  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  11
  • Reputation:   0
  • Joined:  06/03/18
  • Last Seen:  
  • Author
Posted (edited)

[Error]: scrpt:run_script_main: infinity loop
[Debug]: Source (NPC) : -GM-#Krathongl at loykrathong (71,70)

 

It happens. The NPC goes to the last point.

 

I fixed it by putting Sleep. It did not up the infinity loop, but it raised a warning message to me instead.

  

loykrathong,0,0,0	script	#Krathong1	3997,{
end;
OnWalk:
	setd ".npcwalk"+strnpcinfo(2),1;
	set .@npcname$,strnpcinfo(0);
	waitingroom $@MyWish$,0;
	setnpcdisplay(strnpcinfo(0), $@NameKrathong$+"#"+strnpcinfo(2));
	npctalk $@MyWish$;
	sleep 1000;
	set .@walkto_x,114;
	set .@walkto_y,rand(53,69);
	npcspeed 1500;
	sleep rand(500,2000);
	getmapxy .@map$,.@x,.@y,1;
	if( .@x < 83 ){
		set .@npcx,114-83+.@x;
		while( .@x != .@npcx || .@y != .@walkto_y ){
			getmapxy .@map$,.@x,.@y,1;
			npcwalkto .@npcx,.@walkto_y;
			sleep 250;
		}
	}
	while( .@x != .@walkto_x || .@y != .@walkto_y ){
		getmapxy .@map$,.@x,.@y,1;
		npcwalkto .@walkto_x,.@walkto_y;
		sleep 250;
	}
	globalmes getd(".npcwalk"+strnpcinfo(2));
	setd ".npcwalk"+strnpcinfo(2),0;
	setnpcdisplay("#"+strnpcinfo(2), .@npcname$);
	delwaitingroom;
	movenpc strnpcinfo(0),0,0;
	end;
}

 

Untitled.png

Edited by ryuma1922
Link to comment
Share on other sites
  • 0
sader1992 Pouring

sader1992

Posted
  • Group:  Content Moderator
  • Topic Count:  55
  • Topics Per Day:  0.01
  • Content Count:  1691
  • Reputation:   716
  • Joined:  12/21/14
  • Last Seen:  
Posted (edited)

it would be easier if you explain what you want the npcs to do from the start to end

if you want the best result

and try this

  

globalmes "" + getd(".npcwalk"+strnpcinfo(2));
Edited by sader1992
Link to comment
Share on other sites
  • 0
sader1992 Pouring

sader1992

Posted
  • Group:  Content Moderator
  • Topic Count:  55
  • Topics Per Day:  0.01
  • Content Count:  1691
  • Reputation:   716
  • Joined:  12/21/14
  • Last Seen:  
Posted

this will help you if you want the best result 


*movenpc "<NPC name>",<x>,<y>{,<dir>};

This command looks like the NPCWalkToxy function,but is a little different.

While NPCWalkToXY just makes the NPC 'walk' to the coordinates given (which
sometimes gives problems if the path isn't a straight line without objects),
this command just moves the NPC. It basically warps out and in on the current
and given spot. Direction can be used to change the NPC's facing direction.

Example:

// This will move Bugga from it's old coordinates to the new coordinates at 100,20 (if those coordinates are legit).
	moveNPC "Bugga",100,20;

---------------------------------------

*freeloop({<toggle>})

Toggling this to enabled (1) allows the script instance to bypass the infinite loop
protection, allowing your script to loop as much as it may need. Disabling (0) will
warn you if an infinite loop is detected.

The command will return the state of freeloop for the attached script, even if no
argument is provided.

Example:
	freeloop(1); // enable script to loop freely

	// be careful with what you do here
	for ( .@i = 0; .@i < .@bigloop; .@i++ ) {
		dothis;
		// will sleep the script for 1ms when detect an infinity loop to
		// let rAthena do what it needs to do (socket, timer, process, etc.)
	}

	freeloop(0); // disable freeloop

	for ( .@i = 0; .@i < .@bigloop; .@i++ ) {
		dothis;
		// throw an infinity loop error
	}

---------------------------------------

 

Link to comment
Share on other sites
  • 0
ryuma1922 Poring

ryuma1922

Posted
  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  11
  • Reputation:   0
  • Joined:  06/03/18
  • Last Seen:  
  • Author
Posted (edited)

Oh, I'm very thankful for the help, but I'm not good at c ++ language. I'm just an apprentice ?

 

 

I try to put it according to the instructions but it also shows the infinity loop.

Untitled.png

Edited by ryuma1922
Link to comment
Share on other sites
  • 0
ryuma1922 Poring

ryuma1922

Posted
  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  11
  • Reputation:   0
  • Joined:  06/03/18
  • Last Seen:  
  • Author
Posted
39 minutes ago, sader1992 said:

it would be easier if you explain what you want the npcs to do from the start to end

if you want the best result

and try this

  


globalmes "" + getd(".npcwalk"+strnpcinfo(2));

It does not work with other scripts.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing
×
×
  • Create New...