OnNPCKillEvent announce Help

[Kinx]

the announce is not working properly, i kill 10 Vitata or 5 Familiar and she is coming, but she shall not come until I have killed all.

 

OnNPCKillEvent:
if(anthell) end;
if(killedrid == 1176 && VitataKills < 10) // = Vitata
{
	set VitataKills,VitataKills + 1;
	dispbottom "You killed "+VitataKills+"/10 Vitata.";
	if(VitataKills >= 10) 
		dispbottom "You have killed all Vitatas.";
		
} else if (killedrid == 1097 && AntEggKills < 55) // = Ant Egg
{
	set AntEggKills,AntEggKills + 1;
	dispbottom "You killed "+AntEggKills+"/55 AntEgg.";
	if(AntEggKills >= 55)
		dispbottom "You have killed all AntEggs.";
		
}else if (killedrid == 1005 && FamiliarKills < 5) // = Familiar
{
	set FamiliarKills,FamiliarKills + 1;
	dispbottom "You killed "+FamiliarKills+"/5 Familiar.";
	if(FamiliarKills >= 5)
		dispbottom "You have killed all Familiars.";
		
} else if(anthell == 0) {
announce " You have killed every Monster. Come back to me to !",bc_self;
set anthell,1;
}
end;
}

 

[Cydh]

imho, I don't like this script. better you use quest_db and add monster's objectives

OnNPCKillEvent:
	if(anthell) end;
	if(killedrid == 1176) // = Vitata
	{
		set VitataKills,VitataKills + 1;
		if (VitataKills < 10) {
			dispbottom "You killed "+VitataKills+"/10 Vitata.";
		}
		else if(VitataKills == 10) {
			dispbottom "You have killed all Vitatas.";
		}
	}
	else if (killedrid == 1097) // = Ant Egg
	{
		set AntEggKills,AntEggKills + 1;
		if (AntEggKills < 55) {
			dispbottom "You killed "+AntEggKills+"/55 AntEgg.";
		}
		else if(AntEggKills == 55) {
			dispbottom "You have killed all AntEggs.";
		}
	}
	else if (killedrid == 1005) // = Familiar
	{
		set FamiliarKills,FamiliarKills + 1;
		if (FamiliarKills < 5) {
			dispbottom "You killed "+FamiliarKills+"/5 Familiar.";
		}
		else if(FamiliarKills == 5) {
			dispbottom "You have killed all Familiars.";
		}
	}
	if(anthell == 0 && FamiliarKills >= 5 && AntEggKills >= 55 && VitataKills >= 10) {
		announce " You have killed every Monster. Come back to me to !",bc_self;
		set anthell,1;
	}
	end;

 

[Skorm]

7 hours ago, Kinx said:

the announce is not working properly, i kill 10 Vitata or 5 Familiar and she is coming, but she shall not come until I have killed all.

I agree with @Cydh only use OnNPCKillEvent: when you absolutely have to. Since it's going to trigger every time a mob gets killed in your server ever...

[Kinx]

how do you use the quest_db?