Jump to content
  • 0

Eurphy's Quest Shop only showing jellopy

elmucho

Asked by elmucho,

 Share

Question

elmucho Poring

elmucho

Posted
  • Group:  Members
  • Topic Count:  15
  • Topics Per Day:  0.01
  • Content Count:  32
  • Reputation:   0
  • Joined:  05/27/17
  • Last Seen:  
Posted (edited)

The Code below only shows jellopy :(  

//===== rAthena Script =======================================
//= Euphy's Quest Shop
//===== By: ==================================================
//= Euphy
//===== Current Version: =====================================
//= 1.4b
//===== Compatible With: =====================================
//= rAthena SVN r15340+
//===== Description: =========================================
//= A dynamic quest shop based on Lunar's, with easier config.
//= Includes support for multiple shops & cashpoints.
//= Item Preview script by ToastOfDoom.
//============================================================
                    
prontera,164,203,6    script    Quest Shop    998,{
function Add; function Chk; function Slot; function A_An;

    if (.Shops$ == "") set .@i, select(.menu$);
    else set .@i,1;
    dispbottom "Select one item at a time.";
    callshop "qshop"+.@i,1;
    npcshopattach "qshop"+.@i;
    end;

function Add {
    if (getitemname(getarg(1)) == "null") {
        debugmes "Quest reward #"+getarg(1)+" invalid (skipped).";
        return;
    }
    for(set .@n,5; .@n<127; set .@n,.@n+2) {
        if (!getarg(.@n,0)) break;
        if (getitemname(getarg(.@n)) == "null") {
            debugmes "Quest requirement #"+getarg(.@n)+" invalid (skipped).";
            return;
        }
    }
    for(set .@i,2; .@i<.@n; set .@i,.@i+1)
        set getd(".q_"+getarg(1)+"["+(.@i-2)+"]"), getarg(.@i);
    npcshopadditem "qshop"+getarg(0),getarg(1),((.ShowZeny)?getarg(3):0);
    return;
}
function Chk {
    if (getarg(0) < getarg(1)) {
        set @qe0,1;
        return "^FF0000";
    }
    else return "^00FF00";
}
function Slot {
    set .@s$,getitemname(getarg(0));
    switch(.ShowSlot) {
        case 1: if (!getitemslots(getarg(0))) return .@s$;
        case 2: if (getiteminfo(getarg(0),2) == 4 || getiteminfo(getarg(0),2) == 5) return .@s$+" ["+getitemslots(getarg(0))+"]";
        default: return .@s$;
    }
}
function A_An {
    setarray .@A$[0],"a","e","i","o","u";
    set .@B$, "_"+getarg(0);
    for(set .@i,0; .@i<5; set .@i,.@i+1)
        if (compare(.@B$,"_"+.@A$[.@i])) return "an "+getarg(0);
    return "a "+getarg(0);
}

OnBuyItem:
    set .@q[0],@bought_nameid;
    copyarray .@q[1],getd(".q_"+@bought_nameid+"[0]"),getarraysize(getd(".q_"+@bought_nameid+"[0]"));
    if (!.@q[1]) {
        message strcharinfo(0),"An error has occurred.";
        end;
    }
    mes "[Quest Shop]";
    mes "Reward: ^0055FF"+((.@q[1]>1)?.@q[1]+"x ":"")+Slot(.@q[0])+"^000000";
    mes "Requirements:";
    if (.@q[2]) mes " > "+Chk(Zeny,.@q[2])+.@q[2]+" Zeny^000000";
    if (.@q[3]) mes " > "+Chk(getd(.Points$[0]),.@q[3])+.@q[3]+" "+.Points$[1]+" ("+getd(.Points$[0])+"/"+.@q[3]+")^000000";
    if (.@q[4]) for(set .@i,4; .@i<getarraysize(.@q); set .@i,.@i+2)
        mes " > "+Chk(countitem(.@q[.@i]),.@q[.@i+1])+((.DisplayID)?"{"+.@q[.@i]+"} ":"")+Slot(.@q[.@i])+" ("+countitem(.@q[.@i])+"/"+.@q[.@i+1]+")^000000";
    next;
    set @qe1, getiteminfo(.@q[0],5);
    set @qe2, getiteminfo(.@q[0],11);
    addtimer 1000, strnpcinfo(1)+"::OnEnd";
    while(1) {
        switch(select(" ~ Purchase ^0055FF"+getitemname(.@q[0])+"^000000:"+((((@qe1&1) || (@qe1&256) || (@qe1&512)) && @qe2 > 0 && !@qe6)?" ~ Preview...":"")+": ~ ^777777Cancel^000000")) {
        case 1:
            if (@qe0) { 
                mes "[Quest Shop]";
                mes "You're missing one or more quest requirements.";
                close;
            }
            if (!checkweight(.@q[0],.@q[1])) {
                mes "[Quest Shop]";
                mes "^FF0000You need "+(((.@q[1]*getiteminfo(.@q[0],6))+Weight-MaxWeight)/10)+" additional weight capacity to complete this trade.^000000";
                close;
            }
            if (.@q[2]) set Zeny, Zeny-.@q[2];
            if (.@q[3]) setd .Points$[0], getd(.Points$[0])-.@q[3];
            if (.@q[4]) for(set .@i,4; .@i<getarraysize(.@q); set .@i,.@i+2)
                delitem .@q[.@i],.@q[.@i+1];
            getitem .@q[0],.@q[1];
            if (.Announce) announce strcharinfo(0)+" has created "+A_An(getitemname(.@q[0]))+"!",0;
            specialeffect2 699;
            close;
        case 2:
            set @qe3, getlook(3);
            set @qe4, getlook(4);
            set @qe5, getlook(5);
            set @qe6,1;
            if (@qe1&1) atcommand "@changelook 3 "+@qe2;
            if (@qe1&256) atcommand "@changelook 1 "+@qe2;
            if (@qe1&512) atcommand "@changelook 2 "+@qe2;
            break;
        case 3:
            close;
        }
    }
OnEnd:
    if (@qe6) {
        atcommand "@changelook 3 "+@qe3;
        atcommand "@changelook 1 "+@qe4;
        atcommand "@changelook 2 "+@qe5;
    }
    for(set .@i,0; .@i<7; set .@i,.@i+1)
        setd "@qe"+.@i,0;
    end;
OnInit:
    freeloop(1);
// --------------------- Config ---------------------
// Custom points, if needed: "<variable>","<name to display>"
    setarray .Points$[0],"#CASHPOINTS","Cash Points";

    set .Announce,1;    // Announce quest completion? (1: yes / 0: no)
    set .ShowSlot,1;    // Show item slots? (2: all equipment / 1: if slots > 0 / 0: never)
    set .DisplayID,0;    // Show item IDs? (1: yes / 0: no)
    set .ShowZeny,0;    // Show Zeny cost, if any? (1: yes / 0: no)

// Shop categories, if needed: "<Shop 1>","<Shop 2>"{,...};
// Duplicate dummy data for any additional shops (bottom of script).
// If no categories, use the second line instead (remove //).

    setarray .Shops$[1],"Headgears","Weapons","Other";
    // set .Shops$,"n/a";

// Add(<shop number>,<reward ID>,<reward amount>,<Zeny cost>,<point cost>,
//     <required item ID>,<required item amount>{,...});
// Shop number corresponds with order above (default is 1).
// Note: Do NOT use a reward item more than once!

    Add(1,5022,1,0,0,7086,1,969,10,999,40,1003,50,984,2);
    Add(1,5032,1,0,0,1059,250,2221,1,2227,1,7063,600);
    Add(1,5027,1,0,0,2252,1,1036,400,7001,50,4052,1);
    Add(1,5045,1,0,0,2252,1,1054,450,943,1200);

    Add(2,1224,1,0,0,7297,30,969,10,999,50,714,10);
    Add(2,1225,1,0,0,7292,30,969,10,999,50,714,10);

    Add(3,531,1,3,0,512,1,713,1);
    Add(3,532,1,3,0,513,1,713,1);
    Add(3,533,1,3,0,514,1,713,1);
    Add(3,534,1,3,0,515,1,713,1);

// --------------------------------------------------
    freeloop(0);
    set .menu$,"";
    for(set .@i,1; .@i<=getarraysize(.Shops$); set .@i,.@i+1) {
        set .menu$, .menu$+.Shops$[.@i]+":";
        npcshopdelitem "qshop"+.@i,909;
    }
    end;
}

// -------- Dummy data (duplicate as needed) --------
-    shop    qshop1    -1,909:-1
-    shop    qshop2    -1,909:-1
-    shop    qshop3    -1,909:-1

 

Edited by Cyro
Code box
Link to comment
Share on other sites

5 answers to this question

Recommended Posts

  • 0
Zutcer Drops

Zutcer

Posted
  • Group:  Members
  • Topic Count:  31
  • Topics Per Day:  0.01
  • Content Count:  114
  • Reputation:   5
  • Joined:  07/19/15
  • Last Seen:  
Posted 
Change the value freeloop(1); for 0
Link to comment
Share on other sites
  • 0
Ninja Poring

Ninja

Posted
  • Group:  Members
  • Topic Count:  54
  • Topics Per Day:  0.01
  • Content Count:  513
  • Reputation:   83
  • Joined:  08/11/12
  • Last Seen:  
Posted
16 hours ago, elmucho said:

The Code below only shows jellopy :(  


//===== rAthena Script =======================================
//= Euphy's Quest Shop
//===== By: ==================================================
//= Euphy
//===== Current Version: =====================================
//= 1.4b
//===== Compatible With: =====================================
//= rAthena SVN r15340+
//===== Description: =========================================
//= A dynamic quest shop based on Lunar's, with easier config.
//= Includes support for multiple shops & cashpoints.
//= Item Preview script by ToastOfDoom.
//============================================================
                    
prontera,164,203,6    script    Quest Shop    998,{
function Add; function Chk; function Slot; function A_An;

    if (.Shops$ == "") set .@i, select(.menu$);
    else set .@i,1;
    dispbottom "Select one item at a time.";
    callshop "qshop"+.@i,1;
    npcshopattach "qshop"+.@i;
    end;

function Add {
    if (getitemname(getarg(1)) == "null") {
        debugmes "Quest reward #"+getarg(1)+" invalid (skipped).";
        return;
    }
    for(set .@n,5; .@n<127; set .@n,.@n+2) {
        if (!getarg(.@n,0)) break;
        if (getitemname(getarg(.@n)) == "null") {
            debugmes "Quest requirement #"+getarg(.@n)+" invalid (skipped).";
            return;
        }
    }
    for(set .@i,2; .@i<.@n; set .@i,.@i+1)
        set getd(".q_"+getarg(1)+"["+(.@i-2)+"]"), getarg(.@i);
    npcshopadditem "qshop"+getarg(0),getarg(1),((.ShowZeny)?getarg(3):0);
    return;
}
function Chk {
    if (getarg(0) < getarg(1)) {
        set @qe0,1;
        return "^FF0000";
    }
    else return "^00FF00";
}
function Slot {
    set .@s$,getitemname(getarg(0));
    switch(.ShowSlot) {
        case 1: if (!getitemslots(getarg(0))) return .@s$;
        case 2: if (getiteminfo(getarg(0),2) == 4 || getiteminfo(getarg(0),2) == 5) return .@s$+" ["+getitemslots(getarg(0))+"]";
        default: return .@s$;
    }
}
function A_An {
    setarray .@A$[0],"a","e","i","o","u";
    set .@B$, "_"+getarg(0);
    for(set .@i,0; .@i<5; set .@i,.@i+1)
        if (compare(.@B$,"_"+.@A$[.@i])) return "an "+getarg(0);
    return "a "+getarg(0);
}

OnBuyItem:
    set .@q[0],@bought_nameid;
    copyarray .@q[1],getd(".q_"+@bought_nameid+"[0]"),getarraysize(getd(".q_"+@bought_nameid+"[0]"));
    if (!.@q[1]) {
        message strcharinfo(0),"An error has occurred.";
        end;
    }
    mes "[Quest Shop]";
    mes "Reward: ^0055FF"+((.@q[1]>1)?.@q[1]+"x ":"")+Slot(.@q[0])+"^000000";
    mes "Requirements:";
    if (.@q[2]) mes " > "+Chk(Zeny,.@q[2])+.@q[2]+" Zeny^000000";
    if (.@q[3]) mes " > "+Chk(getd(.Points$[0]),.@q[3])+.@q[3]+" "+.Points$[1]+" ("+getd(.Points$[0])+"/"+.@q[3]+")^000000";
    if (.@q[4]) for(set .@i,4; .@i<getarraysize(.@q); set .@i,.@i+2)
        mes " > "+Chk(countitem(.@q[.@i]),.@q[.@i+1])+((.DisplayID)?"{"+.@q[.@i]+"} ":"")+Slot(.@q[.@i])+" ("+countitem(.@q[.@i])+"/"+.@q[.@i+1]+")^000000";
    next;
    set @qe1, getiteminfo(.@q[0],5);
    set @qe2, getiteminfo(.@q[0],11);
    addtimer 1000, strnpcinfo(1)+"::OnEnd";
    while(1) {
        switch(select(" ~ Purchase ^0055FF"+getitemname(.@q[0])+"^000000:"+((((@qe1&1) || (@qe1&256) || (@qe1&512)) && @qe2 > 0 && !@qe6)?" ~ Preview...":"")+": ~ ^777777Cancel^000000")) {
        case 1:
            if (@qe0) { 
                mes "[Quest Shop]";
                mes "You're missing one or more quest requirements.";
                close;
            }
            if (!checkweight(.@q[0],.@q[1])) {
                mes "[Quest Shop]";
                mes "^FF0000You need "+(((.@q[1]*getiteminfo(.@q[0],6))+Weight-MaxWeight)/10)+" additional weight capacity to complete this trade.^000000";
                close;
            }
            if (.@q[2]) set Zeny, Zeny-.@q[2];
            if (.@q[3]) setd .Points$[0], getd(.Points$[0])-.@q[3];
            if (.@q[4]) for(set .@i,4; .@i<getarraysize(.@q); set .@i,.@i+2)
                delitem .@q[.@i],.@q[.@i+1];
            getitem .@q[0],.@q[1];
            if (.Announce) announce strcharinfo(0)+" has created "+A_An(getitemname(.@q[0]))+"!",0;
            specialeffect2 699;
            close;
        case 2:
            set @qe3, getlook(3);
            set @qe4, getlook(4);
            set @qe5, getlook(5);
            set @qe6,1;
            if (@qe1&1) atcommand "@changelook 3 "+@qe2;
            if (@qe1&256) atcommand "@changelook 1 "+@qe2;
            if (@qe1&512) atcommand "@changelook 2 "+@qe2;
            break;
        case 3:
            close;
        }
    }
OnEnd:
    if (@qe6) {
        atcommand "@changelook 3 "+@qe3;
        atcommand "@changelook 1 "+@qe4;
        atcommand "@changelook 2 "+@qe5;
    }
    for(set .@i,0; .@i<7; set .@i,.@i+1)
        setd "@qe"+.@i,0;
    end;
OnInit:
    freeloop(1);
// --------------------- Config ---------------------
// Custom points, if needed: "<variable>","<name to display>"
    setarray .Points$[0],"#CASHPOINTS","Cash Points";

    set .Announce,1;    // Announce quest completion? (1: yes / 0: no)
    set .ShowSlot,1;    // Show item slots? (2: all equipment / 1: if slots > 0 / 0: never)
    set .DisplayID,0;    // Show item IDs? (1: yes / 0: no)
    set .ShowZeny,0;    // Show Zeny cost, if any? (1: yes / 0: no)

// Shop categories, if needed: "<Shop 1>","<Shop 2>"{,...};
// Duplicate dummy data for any additional shops (bottom of script).
// If no categories, use the second line instead (remove //).

    setarray .Shops$[1],"Headgears","Weapons","Other";
    // set .Shops$,"n/a";

// Add(<shop number>,<reward ID>,<reward amount>,<Zeny cost>,<point cost>,
//     <required item ID>,<required item amount>{,...});
// Shop number corresponds with order above (default is 1).
// Note: Do NOT use a reward item more than once!

    Add(1,5022,1,0,0,7086,1,969,10,999,40,1003,50,984,2);
    Add(1,5032,1,0,0,1059,250,2221,1,2227,1,7063,600);
    Add(1,5027,1,0,0,2252,1,1036,400,7001,50,4052,1);
    Add(1,5045,1,0,0,2252,1,1054,450,943,1200);

    Add(2,1224,1,0,0,7297,30,969,10,999,50,714,10);
    Add(2,1225,1,0,0,7292,30,969,10,999,50,714,10);

    Add(3,531,1,3,0,512,1,713,1);
    Add(3,532,1,3,0,513,1,713,1);
    Add(3,533,1,3,0,514,1,713,1);
    Add(3,534,1,3,0,515,1,713,1);

// --------------------------------------------------
    freeloop(0);
    set .menu$,"";
    for(set .@i,1; .@i<=getarraysize(.Shops$); set .@i,.@i+1) {
        set .menu$, .menu$+.Shops$[.@i]+":";
        npcshopdelitem "qshop"+.@i,909;
    }
    end;
}

// -------- Dummy data (duplicate as needed) --------
-    shop    qshop1    -1,909:-1
-    shop    qshop2    -1,909:-1
-    shop    qshop3    -1,909:-1

 

Do you have any errors in your map server?

14 hours ago, Zutcer said: 

Change the value freeloop(1); for 0

If you do that, you will have map server errors if your list grows more.

Link to comment
Share on other sites
  • 0
elmucho Poring

elmucho

Posted
  • Group:  Members
  • Topic Count:  15
  • Topics Per Day:  0.01
  • Content Count:  32
  • Reputation:   0
  • Joined:  05/27/17
  • Last Seen:  
  • Author
Posted

@Ninja @Zutcer  1.4b is not showing on the map can u check the 1.6b because it only shows jellpy 

 

im using the 1.6b its still the same https://raw.githubusercontent.com/rathena/rathena/master/npc/custom/quests/quest_shop.txt

Link to comment
Share on other sites
  • 0
sethacuestapro Poring

sethacuestapro

Posted
  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  21
  • Reputation:   2
  • Joined:  08/31/15
  • Last Seen:  
Posted

Same error... I tried all the version.

 

I think i fixed it... Try automatically loading the npc via the script_custom.conf it worked for me.

Link to comment
Share on other sites
  • 0
dikapramantya Poring

dikapramantya

Posted
  • Group:  Members
  • Topic Count:  55
  • Topics Per Day:  0.01
  • Content Count:  216
  • Reputation:   9
  • Joined:  07/12/12
  • Last Seen:  
Posted

use reloadscript dont use @loadnpc to spawn your quest shop npc sir.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing
×
×
  • Create New...