Punching Bag stack

[peculiarro]

-	script	Punching Bag	-1,{

OnInit:
	setmapflag("prontera",mf_monster_noteleport);
	setmapflag("morocc",mf_monster_noteleport);
	setmapflag("comodo",mf_monster_noteleport);
	setmapflag("louyang",mf_monster_noteleport);

	monster "comodo",191,141,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "morocc",170,85,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "prontera",136,171,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "louyang",207,48,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";

	end;

OnDummyKill:
	monster "comodo",191,141,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "morocc",170,85,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "prontera",136,171,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "louyang",207,48,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	end;

OnPCAttackEvent:
	if ( !@test_punch ) end;
	@dps_damage += @damage;
	end;

}

When I cast storm gust after killing many punching bags, they stack

[Secrets]

Your script spawns the bags for other towns when a bag is killed, so it's normal that they stack. You need to improve the respawn code.

[Ninja]

2 hours ago, peculiarro said:

-	script	Punching Bag	-1,{

OnInit:
	setmapflag("prontera",mf_monster_noteleport);
	setmapflag("morocc",mf_monster_noteleport);
	setmapflag("comodo",mf_monster_noteleport);
	setmapflag("louyang",mf_monster_noteleport);

	monster "comodo",191,141,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "morocc",170,85,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "prontera",136,171,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "louyang",207,48,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";

	end;

OnDummyKill:
	monster "comodo",191,141,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "morocc",170,85,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "prontera",136,171,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	monster "louyang",207,48,"Punching Bag",1905,1,"Punching Bag::OnDummyKill";
	end;

OnPCAttackEvent:
	if ( !@test_punch ) end;
	@dps_damage += @damage;
	end;

}

When I cast storm gust after killing many punching bags, they stack

If I may suggest, you can have more than 1 approach here but I'd have 2 for you

1. Separate each monster script's OnDummyKill. (i.e. comodo -> OnDummyKillComodo, etc.)

2. Use OnNPCKillEvent and do a map check there.

[peculiarro]

22 hours ago, Ninja said:

If I may suggest, you can have more than 1 approach here but I'd have 2 for you

1. Separate each monster script's OnDummyKill. (i.e. comodo -> OnDummyKillComodo, etc.)

2. Use OnNPCKillEvent and do a map check there.

Thank you! Did your 1st solution