Refine Function not working after latest src update

[Felten]

I'm using Emistry's Refine Function - https://rathena.org/board/topic/86008-utility-refine-function/ -

After i updated my src last night the script doesn't work anymore, nothing appears on the menu. I know some things related to this got changed but i can't figure out how to solve this.

 

If anyone can give me a hand on this i'll be grateful. Thanks in advance.

 

 

This is the script if it helps:

function	script	RefineFunc	{

disable_items;
if (isequipped(2576)) {
for( set .@i,1; .@i <= 10; set .@i,.@i + 1 )
	set .@Menu$,.@Menu$ + (( getarg(2) & pow( 2,(.@i-1 ) ) && getequiprefinerycnt( .@i ) >= getarg(3) && getequiprefinerycnt( .@i ) < getarg(4) && getequipisequiped( .@i )?"^FF0000+"+getequiprefinerycnt( .@i )+" ^0000FF"+getequipname( .@i)+" "+( getitemslots( getequipid( .@i ) )?"["+getitemslots( getequipid( .@i ) )+"]":"" )+"^000000":"" )+":";
set .@Refine,select( .@Menu$ );
mes "Preciso de^FF0000"+getarg(1)+" x "+getitemname( getarg(0) )+"^000000";
if( getarg(5) == 1 && !getequipisenableref( .@Refine ) )
	mes "Eu não posso refinar esse item.";
else{
	if( select( "^FF0000Refinar^000000:Cancelar" ) == 2 ) close;	
		if( countitem( getarg(0) ) < getarg(1) ) close;
			delitem getarg(0),getarg(1);
		if( rand(100) < getarg(7) ){
			if( getarg(6) ) 
				while( getequiprefinerycnt( .@Refine ) < getarg(4) )
					successrefitem ( .@Refine );
			else
				successrefitem ( .@Refine );
			mes "Você refinou : ";
			mes "^FF0000+"+getequiprefinerycnt( .@Refine )+" ^0000FF"+getequipname( .@Refine )+"^000000";
		}else{
			failedrefitem ( .@Refine );
			mes "Sorry, Failed in Refine and Equipment...Destroyed.";
		}
}
close;
}
else if (isequipped(2589)) {
for( set .@i,1; .@i <= 10; set .@i,.@i + 1 )
	set .@Menu$,.@Menu$ + (( getarg(2) & pow( 2,(.@i-1 ) ) && getequiprefinerycnt( .@i ) >= getarg(3) && getequiprefinerycnt( .@i ) < getarg(4) && getequipisequiped( .@i) )?"^FF0000+"+getequiprefinerycnt( .@i )+" ^0000FF"+getequipname( .@i )+" "+( getitemslots( getequipid( .@i ) )?"["+getitemslots( getequipid( .@i ) )+"]":"" )+"^000000":"" )+":";
set .@Refine,select( .@Menu$ );
mes "Preciso de^FF0000"+getarg(1)+" x "+getitemname( getarg(0) )+"^000000";
if( getarg(5) == 1 && !getequipisenableref( .@Refine ) )
	mes "Eu não posso refinar esse item.";
else{
	if( select( "^FF0000Refinar^000000:Cancelar" ) == 2 ) close;	
		if( countitem( getarg(0) ) < getarg(1) ) close;
			delitem getarg(0),getarg(1);
		if( rand(100) < getarg(7) ){
			if( getarg(6) ) 
				while( getequiprefinerycnt( .@Refine ) < getarg(4) )
					successrefitem ( .@Refine );
			else
				successrefitem ( .@Refine );
			mes "Você refinou : ";
			mes "^FF0000+"+getequiprefinerycnt( .@Refine )+" ^0000FF"+getequipname( .@Refine )+"^000000";
		}else{
			failedrefitem ( .@Refine );
			mes "Sorry, Failed in Refine and Equipment...Destroyed.";
		}
}
close;
}
else {
mes "Você não está com a asa nem/ou a mochila equipada.";
close;
}
enable_items;
}

Edited April 21, 2016 by cfelten

[Playtester]

It's mostly because scripts should be using the constants rather than using the internal numbers for positions.

 

You can see how Lemongrass fixed the official refine NPC here:

https://github.com/rathena/rathena/commit/7046cf8fc588d4c17047107a98f24547964e6e2e

 

Or Atemo script fixes here:

https://github.com/rathena/rathena/commit/05a1b61beded08b7759b59ef381b4ddbad791abf

https://github.com/rathena/rathena/commit/7d6be7e21ea831130111de846b81700cfc6c6c1e

 

And make sure you have the update on the global function for appropriate usage:

https://github.com/rathena/rathena/commit/1a87f90aa9a9c8f40dec41517b6f2d749c73378e

 

If you have custom scripts you have to adjust them accordingly.

[Felten]

Oh, i get it now. Thanks for the help!