MarkZD

I just think Cookie has to approve it soon, if it's gonna be approved, so we can send the the revision 16968 again and reput the diffs. Since there's just 14 changeset of Core after this, which are all 5~10 min(with excption of 16981 which will take maybe 25 min) of copy/paste or less each, it doesn't seem much things to do.

bypassFCPwSingleStripWhenSCLinkedAsRogue.patch Mirror: http://pastebin.com/pwwpfSMY

I vote for tabs.

This topic is related to bugreport: http://rathena.org/b...reation-denied/ It's hard coded in the client.Also it can be burlated by a packet editor by some bad intentioned user, which might use it to crash the other. I meant in the case the user gets into another account. Note: On 2010 clients it generates grf error, I think the same goes on 2011, but I'm not sure now. I think just newer clients after some 2011 revision will not crash.

In src/map/vending.c Replace all occurrences from this: pc_payzeny(sd, (int)z); to this: pc_payzeny(sd, (int)z, LOG_TYPE_VENDING, vsd); Replace all occurrencies from this: pc_getzeny(vsd, (int)z); to this: pc_getzeny(vsd, (int)z, LOG_TYPE_VENDING, sd); Remove both lines like this one: //Logs (V)ending Zeny [Lupus] log_zeny(vsd, LOG_TYPE_VENDING, sd, (int)z);

You can change the value in status.c It gives 20 * 5 = +100% on lv 5.(200%) case SC_MAXOVERTHRUST: val2 = 20*val1; //Power increase break; To something like: case SC_MAXOVERTHRUST: if(sc->data[sC_SPIRIT] && sc->data[sC_SPIRIT]->val2 == SL_BLACKSMITH) val2 = 100 + 20 * val1; // 300% on lv 5 else val2 = 20*val1; //Power increase break;

3) EDP changes ASPD Open src/map/status.c Find: set_sc( ASC_EDP , SC_EDP , SI_EDP , SCB_NONE ); Replace with: set_sc( ASC_EDP , SC_EDP , SI_EDP , SCB_NONE|SCB_ASPD ); Find: //@TODO move FIGHTINGSPIRIT in fix_aspd if( sc && sc->data[sC_FIGHTINGSPIRIT] && sc->data[sC_FIGHTINGSPIRIT]->val2 ) amotion -= (sd?pc_checkskill(sd, RK_RUNEMASTERY):10) / 10 * 40; amotion = status_calc_fix_aspd(bl, sc, amotion); status->amotion = cap_value(amotion,((sd->class_&JOBL_THIRD) ? battle_config.max_third_aspd : battle_config.max_aspd),2000); Replace with: //@TODO move FIGHTINGSPIRIT in fix_aspd if( sc && sc->data[sC_FIGHTINGSPIRIT] && sc->data[sC_FIGHTINGSPIRIT]->val2 ) amotion -= (sd?pc_checkskill(sd, RK_RUNEMASTERY):10) / 10 * 40; amotion = status_calc_fix_aspd(bl, sc, amotion); if(sc && sc->data[sC_EDP] && sc->data[sC_EDP]->val1 > 3) { if(status->amotion < 31)//197 aspd status->amotion += (sc->data[sC_EDP]->val1 - 3) * 10; else if(status->amotion < 41)//196 aspd status->amotion = 30; } status->amotion = cap_value(amotion,((sd->class_&JOBL_THIRD) ? battle_config.max_third_aspd : battle_config.max_aspd),2000);

The only greed skill I know is this one: http://irowiki.org/wiki/Greed And it doesn't have anything to do with block chance. Anything is possible, or almost.

No, he's right. We don't have current formulas from Renewal implemented yet, atk, def, mdef, matk, etc from Renewal are not implemented yet, so we're using a jerry-rig, not a really good one: http://trac.rathena.org/changeset/16770/rathena The one you provided was changed in this date. This quick-fix still increases final damage, so it didn't help that much. http://rathena.org/board/tracker/issue-6066-edp-should-no-longer-increase-final-damage/

Basicaly so, you just have to take care about the custom edit. What are you supposed to do with Greed? If you just want it to work with another weapon, just edit the skill_require_db.txt in your pre/re path, the one you use. It's the 8º column, you can add more than one weapon using : to separate. The values for weapons can be found at: doc/item_db.txt

Block chance will be edited at status.c, I forgot to add it there, edited the post with the fix. The edit to Sniper is already some posts above, just to let you know.

1) Open src/map/skill.c One Hand Parrying Find: int skill_check_condition_castend(struct map_session_data* sd, short skill, short lv) { struct skill_condition require; struct status_data *status; int i; int index[MAX_SKILL_ITEM_REQUIRE]; After ADD: struct status_change *sc = &sd->sc; Find and Replace the two places like that: if( require.weapon && !pc_check_weapontype(sd,require.weapon) ) { By this: if(require.weapon && !(pc_check_weapontype(sd,require.weapon) || (skill == LK_PARRYING && sc && sc->data[sC_SPIRIT] && sc->data[sC_SPIRIT]->val2 == SL_KNIGHT && sd->status.weapon == W_1HSWORD)) ){ Delay reduction Within function int skill_delayfix (struct block_list *bl, int skill_id, int skill_lv) Find: if ( sc && sc->data[sC_SPIRIT] ) { switch (skill_id) { case CR_SHIELDBOOMERANG: if (sc->data[sC_SPIRIT]->val2 == SL_CRUSADER) time /= 2; break; case AS_SONICBLOW: if (!map_flag_gvg(bl->m) && !map[bl->m].flag.battleground && sc->data[sC_SPIRIT]->val2 == SL_ASSASIN) time /= 2; break; } } Replace with: if ( sc && sc->data[sC_SPIRIT] ) { if(sc->data[sC_SPIRIT]->val2 == SL_KNIGHT) time /= 10; switch (skill_id) { case CR_SHIELDBOOMERANG: if (sc->data[sC_SPIRIT]->val2 == SL_CRUSADER) time /= 2; break; case AS_SONICBLOW: if (!map_flag_gvg(bl->m) && !map[bl->m].flag.battleground && sc->data[sC_SPIRIT]->val2 == SL_ASSASIN) time /= 2; break; } } Open src/map/status.c Block chance change: Find: case SC_PARRYING: val2 = 20 + val1*3; //Block Chance break; Replace with: case SC_PARRYING: if(sd && sd->status.weapon == W_1HSWORD) val2 = val1 * 3; else val2 = 20 + val1*3; //Block Chance break;

In src/map/battle.c if( sc && sc->data[sC__SHADOWFORM] ) { struct block_list *s_bl = map_id2bl(sc->data[sC__SHADOWFORM]->val2); if( !s_bl ) { // If the shadow form target is not present remove the sc. status_change_end(bl, SC__SHADOWFORM, INVALID_TIMER); } else if( status_isdead(s_bl) || !battle_check_target(src,s_bl,BCT_ENEMY)) { // If the shadow form target is dead or not your enemy remove the sc in both. status_change_end(bl, SC__SHADOWFORM, INVALID_TIMER); if( s_bl->type == BL_PC ) ((TBL_PC*)s_bl)->shadowform_id = 0; } else { if( (--sc->data[sC__SHADOWFORM]->val3) < 0 ) { // If you have exceded max hits supported, remove the sc in both. status_change_end(bl, SC__SHADOWFORM, INVALID_TIMER); if( s_bl->type == BL_PC ) ((TBL_PC*)s_bl)->shadowform_id = 0; } else { status_damage(src, s_bl, damage, 0, clif_damage(s_bl, s_bl, gettick(), 500, 500, damage, -1, 0, 0), 0); return ATK_NONE; } } } The damage variable in here: You could redulce this value before it's passed trought the status_damage function, right after the else. Something like: } else { damage *= 0.7; //reduces 30% of damage status_damage(src, s_bl, damage, 0, clif_damage(s_bl, s_bl, gettick(), 500, 500, damage, -1, 0, 0), 0); return ATK_NONE; }

You want reduction for all skills or do you want all skills from LK to work with 1 Hand Sword. Independent from the case, there's no need to do it with each one, if you want it to work with all, we just have to remove the skill check. Fixed the other request, tested and working: http://rathena.org/b...l-modification/ Ok. Understood. 2) Open src/map/skill.c Find: // Automatic trigger of Blitz Beat if (pc_isfalcon(sd) && sd->status.weapon == W_BOW && (skill=pc_checkskill(sd,HT_BLITZBEAT))>0 && rnd()%1000 <= sstatus->luk*10/3+1 ) { rate=(sd->status.job_level+9)/10; skill_castend_damage_id(src,bl,HT_BLITZBEAT,(skill<rate)?skill:rate,tick,SD_LEVEL); } After Add: // Automatic trigger of Falcon Assault, customized source. [MarkZD] if (sc && sc->data[sC_SPIRIT] && sc->data[sC_SPIRIT]->val2 == SL_HUNTER && pc_isfalcon(sd) && sd->status.weapon == W_BOW && (skill=pc_checkskill(sd,SN_FALCONASSAULT))>0 && rnd()%1000 <= sstatus->luk*10/3+1 ) { skill_castend_damage_id(src,bl,SN_FALCONASSAULT,skill,tick,SD_LEVEL); } Done.

1) First add my modification to enable One Hand Parrying when Soul Linked with knight spirit: http://rathena.org/b...l-modification/ 2) Aswer: editing the source. What would be the chance? 3) See if it's what you want in 3: If a guy has 197 aspd and use EDP level 5 or 4 it'll reduce. If he has 196 it'll increase to 197 ONLY when level 5 used? Just 196 and 197 aspd will be changed? I don't know if I'll do it anyway.

I edited the post, fixed it. Tested and Working.

Did you put it on group 0 and do you users belongs to group 0 or did you change it? Did you try restarting the server? Note: This is not the right section to ask for support.

If you're using rAthena, One Hand Quicken is already provided when LK is linked(and have two hand quicken lv 10). So the edits below are just for the second request. Open src/map/skill.c Find: int skill_check_condition_castend(struct map_session_data* sd, short skill, short lv) { struct skill_condition require; struct status_data *status; int i; int index[MAX_SKILL_ITEM_REQUIRE]; After ADD: struct status_change *sc = &sd->sc; Find and Replace the two places like that: if( require.weapon && !pc_check_weapontype(sd,require.weapon) ) { By this: if(require.weapon && !(pc_check_weapontype(sd,require.weapon) || (skill == LK_PARRYING && sc && sc->data[sC_SPIRIT] && sc->data[sC_SPIRIT]->val2 == SL_KNIGHT && sd->status.weapon == W_1HSWORD)) ){

You want HIT POINTS, not HEALTH POINTS, right?(Say just hit next time, hp is the life bar) So, in your src/map/status.c Find the function: static signed short status_calc_hit Find within the function: if(!sc || !sc->count) return cap_value(hit,1,SHRT_MAX); After ADD: if(sc && sc->data[sC_SPIRIT] && sc->data[sC_SPIRIT]->val2 == SL_WIZARD) hit += Number_You_Want; In this case, it will work for who have wizard spirits only. If you want it to work with other sipirit, just replace SL_WIZARD by one of these: If you want it to work in any spirit, just remove the: && sc->data[sC_SPIRIT]->val2 == SL_WIZARD Don't set this value to high as the sum of the total function, it includes buffs etc can't be higher than 32,767 and lower than -32,768.

i'd say that, but as I tested it and it worked, and because of C language allowing it I discarded. It's probably because his compiler is too old or because of the script engine? But it's possible, it's the error cause though. ;D

When I say struct conversion, I'm referring about this: struct map_session_data *sd = (struct map_session_data *)bl; bl is a block_list struct but you're saying you want it as a map_session_data struct, I don't know really what will happen, but if this works it should only if both structs are equal or they have same members used in the next steps. I knew it, but as I saw it was simpler to the moment, I used it and I give a little optimized by comparing as soon as possible the user_map with the said map to avoid unnecessary checks. And with the current source, I think it's the only way to do it. You don't have to worry so much, You can verify thousand of users(maybe millions or more, depends on PC) with this way in a second. There's a lot of compilers, he's probably using GCC.

I edited it again. It could give a message of users from others maps, not the one chosen, if the user doesn't have permission to recall from there. Optimized the code, so it will avoid unnecessary checks.

I have paste the wrong piece, I edited it, try again, please.

Open: src/map/atcommand.c Find: /** * Fills the reference of available commands in atcommand DBMap **/ Replace with: ACMD_FUNC(recallmap) { short mapindex; struct map_session_data* pl_sd; struct s_mapiterator* iter; int count; nullpo_retr(-1, sd); if (!message || !*message){ clif_displaymessage(fd, msg_txt(909)); // Please enter a map (usage: @recallmap <mapname>). return -1; } mapindex = map_mapname2mapid(message); if (mapindex < 0) { clif_displaymessage(fd, msg_txt(1)); // Map not found. return -1; } count = 0; iter = mapit_getallusers(); for( pl_sd = (TBL_PC*)mapit_first(iter); mapit_exists(iter); pl_sd = (TBL_PC*)mapit_next(iter) ) { if(pl_sd->bl.m == mapindex) { if (sd->status.account_id != pl_sd->status.account_id && pc_get_group_level(sd) >= pc_get_group_level(pl_sd)) { if (map[pl_sd->bl.m].flag.nowarp && !pc_has_permission(sd, PC_PERM_WARP_ANYWHERE)) count++; else { if (pc_isdead(pl_sd)) { //Wake them up pc_setstand(pl_sd); pc_setrestartvalue(pl_sd,1); } pc_setpos(pl_sd, sd->mapindex, sd->bl.x, sd->bl.y, CLR_RESPAWN); } } } } mapit_free(iter); clif_displaymessage(fd, msg_txt(92)); // All characters recalled! if (count){ sprintf(atcmd_output, msg_txt(1033), count); // Because you are not authorized to warp from some maps, %d player(s) have not been recalled. clif_displaymessage(fd, atcmd_output); } return 0; } /** * Fills the reference of available commands in atcommand DBMap **/ Find: AtCommandInfo atcommand_base[] = { Replace with: AtCommandInfo atcommand_base[] = { ACMD_DEF(recallmap), Recompile, you're done.

I see, it's because you're using the function as a reference in map_foreachmap. This struct conversion which may be causing the trouble. kamoteka, if you still go on getting errors, you just need to change "static int" to "int". But check again you did it all right, I compiled her code and it passed through VB 2010.(Maybe your compiler is more strict?)