Consumable Items & Skill Bugs

[Veracious]

 

Schwartzwald Pine Jubilee - Item ID# 12320

Box of Drowsiness - Item ID# 12031

Box of Resentment - Item ID# 12030

 

All these items are not functioning properly, even these and these too are not working as they should. These are some of the core WOE/BG/PVP items, i hope it gets solved at the earliest.

 

SVN - 17704 - https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/

Edited June 16, 2014 by Veracious

[Veracious]

I've managed to fix it. Was also able to fix clown gypsy skills(bragi, please dont forget me, etc) which would not dispel upon death.

 

Items :- 

 

Item ID# 12030 SC_ATKPOTION

Item ID# 12031 SC_MATKPOTION

Item ID# 12320 SC_INCHIT, SC_INCFLEE2

 

Skills :-

 

SC_WHISTLE:

SC_ASSNCROS:

SC_POEMBRAGI:

SC_APPLEIDUN:

SC_HUMMING:

SC_DONTFORGETME:

SC_FORTUNE:

SC_SERVICE4U:

 

Made changes as shown below.

 

/**
* End all statuses except those listed
* TODO: May be useful for dispel instead resetting a list there
* @param src: Source of the status change [PC|MOB|HOM|MER|ELEM|NPC]
* @param type: Changes behaviour of the function
*  0: PC killed -> Place here statuses that do not dispel on death.
*  1: If for some reason status_change_end decides to still keep the status when quitting.
*  2: Do clif_changeoption()
*  3: Do not remove some permanent/time-independent effects
* @return 1: Success 0: Fail
**/
int status_change_clear(struct block_list* bl, int type)
{
struct status_change* sc;
int i;
 
sc = status_get_sc(bl);
 
if (!sc || !sc->count)
return 0;
 
for(i = 0; i < SC_MAX; i++) {
if(!sc->data[i])
continue;
 
if(type == 0)
switch (i) { // Type 0: PC killed -> Place here statuses that do not dispel on death.
case SC_ELEMENTALCHANGE: // Only when its Holy or Dark that it doesn't dispell on death
if( sc->data[i]->val2 != ELE_HOLY && sc->data[i]->val2 != ELE_DARK )
break;
case SC_WEIGHT50:
case SC_WEIGHT90:
case SC_EDP:
case SC_MELTDOWN:
case SC_WEDDING:
case SC_XMAS:
case SC_SUMMER:
case SC_HANBOK:
case SC_OKTOBERFEST:
case SC_NOCHAT:
case SC_FUSION:
case SC_EARTHSCROLL:
case SC_READYSTORM:
case SC_READYDOWN:
case SC_READYCOUNTER:
case SC_READYTURN:
case SC_DODGE:
case SC_JAILED:
case SC_EXPBOOST:
case SC_ITEMBOOST:
case SC_HELLPOWER:
case SC_JEXPBOOST:
case SC_AUTOTRADE:
//case SC_WHISTLE:
//case SC_ASSNCROS:
//case SC_POEMBRAGI:
//case SC_APPLEIDUN:
//case SC_HUMMING:
//case SC_DONTFORGETME:
//case SC_FORTUNE:
//case SC_SERVICE4U:
case SC_FOOD_STR_CASH:
case SC_FOOD_AGI_CASH:
case SC_FOOD_VIT_CASH:
case SC_FOOD_DEX_CASH:
case SC_FOOD_INT_CASH:
case SC_FOOD_LUK_CASH:
case SC_DEF_RATE:
case SC_MDEF_RATE:
case SC_INCHEALRATE:
//case SC_INCFLEE2:
//case SC_INCHIT:
//case SC_ATKPOTION:
//case SC_MATKPOTION:
case SC_S_LIFEPOTION:
case SC_L_LIFEPOTION:
case SC_PUSH_CART:
case SC_STYLE_CHANGE:
case SC_HEAT_BARREL_AFTER:
case SC_QUEST_BUFF1:
case SC_QUEST_BUFF2:
case SC_QUEST_BUFF3:
continue;
}

Edited May 22, 2014 by Veracious