NPC Visibility Variable help

[Hirasu]

hey i need some help with a code from @Jonne

 

 

 

diff --git a/src/map/clif.c b/src/map/clif.c
index 2731018..099466f 100644
--- a/src/map/clif.c
+++ b/src/map/clif.c
@@ -4152,11 +4152,16 @@ void clif_getareachar_unit(struct map_session_data* sd,struct block_list *bl)
if (!vd || vd->class_ == INVISIBLE_CLASS)
return;


- /**
- * Hide NPC from maya purple card.
- **/
- if(bl->type == BL_NPC && !((TBL_NPC*)bl)->chat_id && (((TBL_NPC*)bl)->sc.option&OPTION_INVISIBLE))
- return;
+ if(bl->type == BL_NPC) {
+ /**
+ * Hide NPC from maya purple card.
+ **/
+ if (!((TBL_NPC*)bl)->chat_id && (((TBL_NPC*)bl)->sc.option&OPTION_INVISIBLE))
+ return;
+ // Only show NPC to people who have a certain variable set
+ if (((TBL_NPC*)bl)->visibility != 0 && ((TBL_NPC*)bl)->visibility == pc_readglobalreg(sd, "npcvisibility"))
+ return;
+ }


ud = unit_bl2ud(bl);
len = ( ud && ud->walktimer != INVALID_TIMER ) ? clif_set_unit_walking(bl,ud,buf) : clif_set_unit_idle(bl,buf,false);
diff --git a/src/map/npc.h b/src/map/npc.h
index ab9d084..b4b6552 100644
--- a/src/map/npc.h
+++ b/src/map/npc.h
@@ -70,6 +70,7 @@ struct npc_data {
char killer_name[NAME_LENGTH];
} tomb;
} u;
+ int visibility;
};




diff --git a/src/map/script.c b/src/map/script.c
index eda82c7..681867f 100644
--- a/src/map/script.c
+++ b/src/map/script.c
@@ -18165,6 +18165,43 @@ static int atcommand_cleanfloor_sub(struct block_list *bl, va_list ap)
return 0;
}


+/**
+ * setvisibility <value>{, <"npc">}
+ * @param <value> the value to set it and checkf or
+ * @param <"npc"> if another NPC should be targetted
+**/
+BUILDIN_FUNC(setvisibility) {
+ struct npc_data *nd = NULL;
+
+ if (script_hasdata(st, 3)) {
+ nd = npc_name2id(script_getstr(st, 3));
+ ShowWarning("buildin_setvisibility: NPC '%s' not found. Using active NPC.\n", script_getstr(st, 3));
+ }
+ if (nd == NULL)
+ nd = map_id2nd(st->oid);
+
+ nd->visibility = script_getnum(st, 2);
+ return 0;
+}
+
+/**
+ * getvisibility {<"npc>"}
+ * @param <"npc"> if another NPC should be targetted
+**/
+BUILDIN_FUNC(getvisibility) {
+ struct npc_data *nd = NULL;
+
+ if (script_hasdata(st, 2)) {
+ nd = npc_name2id(script_getstr(st, 2));
+ ShowWarning("buildin_getvisibility: NPC '%s' not found. Using active NPC.\n", script_getstr(st, 2));
+ }
+ if (nd == NULL)
+ nd = map_id2nd(st->oid);
+
+ script_pushint(st, nd->visibility);
+ return 0;
+}
+
#include "../custom/script.inc"


// declarations that were supposed to be exported from npc_chat.c
@@ -18648,6 +18685,8 @@ struct script_function buildin_func[] = {
BUILDIN_DEF(vip_time,"i?"),
#endif
BUILDIN_DEF(bonus_script,"si???"),
+ BUILDIN_DEF(setvisibility, "i?"),
+ BUILDIN_DEF(getvisibility, "?"),


#include "../custom/script_def.inc"

 

 

* setvisibility <value>{, <"npc">}

* @param <value> the value to set it and checkf or

* @param <"npc"> if another NPC should be targetted

 

You set the value of the NPC to a value not 0. Only players with the character variable "npcvisibility" set to this exact value can now see the NPC. It should also not effect NPCs which have no visibility set, since it ignores the value zero. You have to put this into the OnInit event, since I didn't add a saving mechanism so it will be deleted once you reload. Thus the OnInit.

 

* getvisibility {<"npc>"}

* @param <"npc"> if another NPC should be targetted

**/

An example:

// Some NPC here
OnInit:
SetVisibility(1);
End;

Only a player with the variable "npcvisibility" set to 1 can see the npc now.

 

my Script:

 

prontera,150,150,4 script testitest 110,{

 

OnInit:

SetVisibility(1);

End;

}

 

But i can see the npc with npcvisibility 0 or 1

(No Complie error || No server errors) 

 

 

Can someone help me please?

 

 

Edited March 10, 2014 by Hirasu

[Jonne]

Yea, my bad. I just realized this line is wrong:  if (((TBL_NPC*)bl)->visibility != 0 && ((TBL_NPC*)bl)->visibility == pc_readglobalreg(sd, "npcvisibility"))

 

It should be:

 if (((TBL_NPC*)bl)->visibility != 0 && ((TBL_NPC*)bl)->visibility != pc_readglobalreg(sd, "npcvisibility"))

[Hirasu]

 

Yea, my bad. I just realized this line is wrong:  if (((TBL_NPC*)bl)->visibility != 0 && ((TBL_NPC*)bl)->visibility == pc_readglobalreg(sd, "npcvisibility"))

 

It should be:

 if (((TBL_NPC*)bl)->visibility != 0 && ((TBL_NPC*)bl)->visibility != pc_readglobalreg(sd, "npcvisibility"))

Hey , danke erstmal das du mir helfen möchtest aber ich hab den code ersetzt und neu compiled aber es geht noch immer nicht 

 

mein script:

 

 

prontera,150,150,4 script testitest 110,{

 

OnInit:

SetVisibility(1);

End;

}

 hab es mit 1 und 0 getestet aber es funktioniert nicht und bekomm auch keine errors

ich warte auf so ein code seit 7 jahren wäre echt nett wenn du es hinbekommen würdest

[Jonne]

I wish I could further test, but I'm on a business trip until May :/ I will definetly check it out then again, if nobody has fixxed it until then. I know what you mean about that code, as it could add something like episodes of story to the NPCs. Sorry about the bummer for now

[Zell]

Jonne, some news?