"[SQL] DB Error" svn17101 - MAX_GUARDIANS vs guild_castle fields

[Cydh]

hi everyone..

I just downloaded the latest svn for rAthena, 17101. Clean install, also clean import .sql file from svn/repository

of course the main.sql file from https://rathena.svn....files/main.sql.

Here the error

and tada~ I just realize how I got this error.

for guild_castle table, only provides 8 guardians. visibleG0~visibleG7 fields

but, let check on this line (src/char/int_guild.c line 537)

for (i = 0; i < MAX_GUARDIANS; ++i)

it can provide until x guardian that decided on mmo.h (line 100)

#define MAX_GUARDIANS 8 //Local max per castle. [skotlex]

how If I decided the MAX_GUARDIANS is 12 but the table only supports until it 8 guardians?

well, I can add the fields manually.

How if 100 MAX_GUARDIANS? hahaha

Thank's

Edited January 18, 2013 by cydh

[Brian]

Correct, trunk/sql-files/main.sql creates a `guild_castle` for the default 8 guardians (visibleG0 - visibleG7).

For 12 guardians, you should modify your SQL table to this:

DROP TABLE IF EXISTS `guild_castle`;
CREATE TABLE IF NOT EXISTS `guild_castle` (
 `castle_id` int(11) unsigned NOT NULL default '0',
 `guild_id` int(11) unsigned NOT NULL default '0',
 `economy` int(11) unsigned NOT NULL default '0',
 `defense` int(11) unsigned NOT NULL default '0',
 `triggerE` int(11) unsigned NOT NULL default '0',
 `triggerD` int(11) unsigned NOT NULL default '0',
 `nextTime` int(11) unsigned NOT NULL default '0',
 `payTime` int(11) unsigned NOT NULL default '0',
 `createTime` int(11) unsigned NOT NULL default '0',
 `visibleC` int(11) unsigned NOT NULL default '0',
 `visibleG0` int(11) unsigned NOT NULL default '0',
 `visibleG1` int(11) unsigned NOT NULL default '0',
 `visibleG2` int(11) unsigned NOT NULL default '0',
 `visibleG3` int(11) unsigned NOT NULL default '0',
 `visibleG4` int(11) unsigned NOT NULL default '0',
 `visibleG5` int(11) unsigned NOT NULL default '0',
 `visibleG6` int(11) unsigned NOT NULL default '0',
 `visibleG7` int(11) unsigned NOT NULL default '0',
 `visibleG8` int(11) unsigned NOT NULL default '0',
 `visibleG9` int(11) unsigned NOT NULL default '0',
 `visibleG10` int(11) unsigned NOT NULL default '0',
 `visibleG11` int(11) unsigned NOT NULL default '0',
 PRIMARY KEY  (`castle_id`),
 KEY `guild_id` (`guild_id`)
) ENGINE=MyISAM;

[Cydh]

Correct, trunk/sql-files/main.sql creates a `guild_castle` for the default 8 guardians (visibleG0 - visibleG7).

For 12 guardians, you should modify your SQL table to this:

DROP TABLE IF EXISTS `guild_castle`;
CREATE TABLE IF NOT EXISTS `guild_castle` (
 `castle_id` int(11) unsigned NOT NULL default '0',
 `guild_id` int(11) unsigned NOT NULL default '0',
 `economy` int(11) unsigned NOT NULL default '0',
 `defense` int(11) unsigned NOT NULL default '0',
 `triggerE` int(11) unsigned NOT NULL default '0',
 `triggerD` int(11) unsigned NOT NULL default '0',
 `nextTime` int(11) unsigned NOT NULL default '0',
 `payTime` int(11) unsigned NOT NULL default '0',
 `createTime` int(11) unsigned NOT NULL default '0',
 `visibleC` int(11) unsigned NOT NULL default '0',
 `visibleG0` int(11) unsigned NOT NULL default '0',
 `visibleG1` int(11) unsigned NOT NULL default '0',
 `visibleG2` int(11) unsigned NOT NULL default '0',
 `visibleG3` int(11) unsigned NOT NULL default '0',
 `visibleG4` int(11) unsigned NOT NULL default '0',
 `visibleG5` int(11) unsigned NOT NULL default '0',
 `visibleG6` int(11) unsigned NOT NULL default '0',
 `visibleG7` int(11) unsigned NOT NULL default '0',
 `visibleG8` int(11) unsigned NOT NULL default '0',
 `visibleG9` int(11) unsigned NOT NULL default '0',
 `visibleG10` int(11) unsigned NOT NULL default '0',
 `visibleG11` int(11) unsigned NOT NULL default '0',
 PRIMARY KEY  (`castle_id`),
 KEY `guild_id` (`guild_id`)
) ENGINE=MyISAM;

I did, just wondering that everyone knows this issue or not.

Thank's

And, is the MySQL query always be executed for the first time when the server is running meanwhile there's no record there?

How if make table `castle_guardian` that contains `castle_id`, `visible_guardian`, and `guardian_id` and call it use INNER JOIN, so the MAX_GUARDIANS can be LIMIT clause when executing the query.

Edited January 20, 2013 by cydh