script error

[caspa]

....

Edited July 9, 2012 by caspa

[plankt]

First of, the variables are a bit messed up.

1) You can't use the same variable for both iterating and holding the array data like this.

Use the variables actually set by *getpartymember()

2) You use $@members as a static var? The party could have everything from 1 to 12 members.

*getpartymember sets $@partymembercount, use that.

You use *getpartymember(... , 1) but you don't use the cid in *isloggedin(aid, cid). So technically the player can have 2 characters from the same account and be offline on one of them and still register as online.

You can rewrite the for loop to reduce the code:

for(set .@i, 0; .@i < $@partymembercount && isloggedin($@partymemberaid[.@i], $@partymembercid[.@i]); set .@i, .@i+1){ }
if(.@i < $@partymembercount){
 mes "not enough members";
 close;
}