GoldPC Shop

[mizanyan]

Hello. It's there a way to make the GoldPC button open the shop directly instead of spawning a npc besides the player?

 

[Poring King]

3 hours ago, mizanyan said:

Hello. It's there a way to make the GoldPC button open the shop directly instead of spawning a npc besides the player?

 

It would be nice if you post your script . If you are asking if you want a NPC that will show in certain place

 

mapname,x,y,facing[TAB]Script[TAB]NPCID,{


	mes "[ Simple NPC]";
	mes "This is the paragraph";
		end;
}

 

[mizanyan]

Hello @Poring King. The npc already spawn besides me if I click on Goldpc button on the top of the screen. I want to know if theres a way to make the shop window open up directly instead of having to spawn a npc and click on him.

I've posted 2 videos, first one is how it is right now and second one is what I want to be.
 

prontera,156,181,5	script	Hourly Point Manager::GOLDPCCAFE	10380,{
    cutin("ep18_merchant.png", 2);
    callshop("hourly_shop", 1);
    npcshopattach("hourly_shop");
    end;

    OnBuyItem:
        mes("[Hourly Point Manager]");
        if (!checkweight2(@bought_nameid, @bought_quantity)) {
            mes("Sorry, you can't carry all these items!");
            close3;
        }
        
        for (.@i = 0; .@i < getarraysize(@bought_nameid); .@i++){
            .@itemIndex = inarray(.Shop, @bought_nameid[.@i]);
            .@costs += (.Shop[.@itemIndex + 1] * @bought_quantity[.@i]);
        }

        if (.@costs > Goldpc_Points) {
            mes("You don't have enough Hourly Points.");
            close3;
        }

        Goldpc_Points -= .@costs;
        for(.@i = 0; .@i < getarraysize(@bought_nameid); .@i++) {
            getitem(@bought_nameid[.@i], @bought_quantity[.@i]);
            dispbottom("Purchased " + @bought_quantity[.@i] + " x " + getitemname(@bought_nameid[.@i]) + ".");
        }

        mes("Purchased successfully!");
        mes("You have ^0000ff" + Goldpc_Points + "^000000 points remaining.");
        close3;

    OnInit:
        setarray(.Shop[0], 13534, 1, 13810, 1, 14532, 1, 14606, 1, 12211, 1, 7776, 25);
        npcshopitem("hourly_shop", 13534, 1, 13810, 1, 14532, 1, 14606, 1, 12211, 1, 7776, 25);
}

 

Edited July 18, 2023 by mizanyan
Typo

[Winterfox]

There is nothing in that script that would make it spawn near your character. It sounds like you use duplicate_dynamic which spawns a copy of a NPC near your character.
Also it doesn't make sense for a NPC that you don't want to be visible to have data about the map and sprite.
 

-	script	Hourly Point Manager::GOLDPCCAFE	FAKE_NPC,{
    cutin("ep18_merchant.png", 2);
    callshop("hourly_shop", 1);
    npcshopattach("hourly_shop");
    end;

    OnBuyItem:
        mes("[Hourly Point Manager]");
        if (!checkweight2(@bought_nameid, @bought_quantity)) {
            mes("Sorry, you can't carry all these items!");
            close3;
        }
        
        for (.@i = 0; .@i < getarraysize(@bought_nameid); .@i++){
            .@itemIndex = inarray(.Shop, @bought_nameid[.@i]);
            .@costs += (.Shop[.@itemIndex + 1] * @bought_quantity[.@i]);
        }

        if (.@costs > Goldpc_Points) {
            mes("You don't have enough Hourly Points.");
            close3;
        }

        Goldpc_Points -= .@costs;
        for(.@i = 0; .@i < getarraysize(@bought_nameid); .@i++) {
            getitem(@bought_nameid[.@i], @bought_quantity[.@i]);
            dispbottom("Purchased " + @bought_quantity[.@i] + " x " + getitemname(@bought_nameid[.@i]) + ".");
        }

        mes("Purchased successfully!");
        mes("You have ^0000ff" + Goldpc_Points + "^000000 points remaining.");
        close3;

    OnInit:
        setarray(.Shop[0], 13534, 1, 13810, 1, 14532, 1, 14606, 1, 12211, 1, 7776, 25);
        npcshopitem("hourly_shop", 13534, 1, 13810, 1, 14532, 1, 14606, 1, 12211, 1, 7776, 25);
}

 

[mizanyan]

54 minutes ago, Winterfox said:

There is nothing in that script that would make it spawn near your character. It sounds like you use duplicate_dynamic which spawns a copy of a NPC near your character.
Also it doesn't make sense for a NPC that you don't want to be visible to have data about the map and sprite.
 

-	script	Hourly Point Manager::GOLDPCCAFE	FAKE_NPC,{
    cutin("ep18_merchant.png", 2);
    callshop("hourly_shop", 1);
    npcshopattach("hourly_shop");
    end;

    OnBuyItem:
        mes("[Hourly Point Manager]");
        if (!checkweight2(@bought_nameid, @bought_quantity)) {
            mes("Sorry, you can't carry all these items!");
            close3;
        }
        
        for (.@i = 0; .@i < getarraysize(@bought_nameid); .@i++){
            .@itemIndex = inarray(.Shop, @bought_nameid[.@i]);
            .@costs += (.Shop[.@itemIndex + 1] * @bought_quantity[.@i]);
        }

        if (.@costs > Goldpc_Points) {
            mes("You don't have enough Hourly Points.");
            close3;
        }

        Goldpc_Points -= .@costs;
        for(.@i = 0; .@i < getarraysize(@bought_nameid); .@i++) {
            getitem(@bought_nameid[.@i], @bought_quantity[.@i]);
            dispbottom("Purchased " + @bought_quantity[.@i] + " x " + getitemname(@bought_nameid[.@i]) + ".");
        }

        mes("Purchased successfully!");
        mes("You have ^0000ff" + Goldpc_Points + "^000000 points remaining.");
        close3;

    OnInit:
        setarray(.Shop[0], 13534, 1, 13810, 1, 14532, 1, 14606, 1, 12211, 1, 7776, 25);
        npcshopitem("hourly_shop", 13534, 1, 13810, 1, 14532, 1, 14606, 1, 12211, 1, 7776, 25);
}

 

I've tried your method but it doesn't spawn anything and it says in chat that already exist a npc in the map so I assume the goldpc button calls a invisible npc. Maybe it needs to modify in the source for it to work? This is the patch I applied btw: https://github.com/rathena/rathena/pull/7410

I wanted it to call the shop window directly without the need of the npc at all.

Edited July 19, 2023 by mizanyan

[Winterfox]

The changed clif.cpp uses npc_duplicate_npc_for_player when you click the button. That function is what spawns the NPC near your character.
So that is not a scripting issue, but one you will have to solve via modifying the source code so that the NPC gets called instead of being spawned near the character.

Edited July 19, 2023 by Winterfox

[williamII]

On 7/17/2023 at 11:53 PM, mizanyan said:

Hello. It's there a way to make the GoldPC button open the shop directly instead of spawning a npc besides the player?

 

 

Bro, how i can activate GoldPC , i searched but i don't find the option

[imat1]

44 minutes ago, williamII said:

Bro, how i can activate GoldPC , i searched but i don't find the option

https://github.com/rathena/rathena/pull/7410