i found Bug on TF_STEAL

[rongrong]

Bug Description:  skill TF_STEAL ONLY obtain the first item on the mob's drop list （no matter how low the droprate is）

Condition:  1. PRE-RENEWAL Server.

                   2. Bug occurred when char's DEX < mob's DEX, and get right when char‘s DEX >= mob's DEX.

Possible Code:

    // base skill success chance (percentual)
    rate = (sd_status->dex - md_status->dex)/2 + skill_lv*6 + 4; // bug rate < 64
    rate += sd->bonus.add_steal_rate;

    if( rate < 1
#ifdef RENEWAL
        || rnd()%100 >= rate
#endif
    )
        return false;

    // Try dropping one item, in the order from first to last possible slot.
    // Droprate is affected by the skill success rate.
    for( i = 0; i < MAX_MOB_DROP; i++ )
        if( item_db.exists(md->db->dropitem[i].nameid) && !md->db->dropitem[i].steal_protected && rnd() % 10000 < md->db->dropitem[i].rate
#ifndef RENEWAL
        * rate/100.  // i cant find the bug
#endif
        )
            break;
    if( i == MAX_MOB_DROP )
        return false;

    itemid = md->db->dropitem[i].nameid;
    struct item tmp_item = {};
    tmp_item.nameid = itemid;
    tmp_item.amount = 1;
    tmp_item.identify = itemdb_isidentified(itemid);
    if( battle_config.skill_steal_random_options ){
        mob_setdropitem_option( &tmp_item, &md->db->dropitem[i] );
    }
    flag = pc_additem(sd,&tmp_item,1,LOG_TYPE_PICKDROP_PLAYER);

Edited June 2, 2023 by rongrong