[SOLVED] How to prove that skills are copied to mob_data?

[eduardoxmenezes]

Hello,

there's pc_checkskill 

uint8 pc_checkskill(struct map_session_data *sd, uint16 skill_id)
{
    uint16 idx = 0;
    if (sd == NULL)
        return 0;
    if ((idx = skill_get_index(skill_id)) == 0) {
        ShowError("pc_checkskill: Invalid skill id %d (char_id=%d).\n", skill_id, sd->status.char_id);
        return 0;
    }
    if (SKILL_CHK_GUILD(skill_id) ) {
        struct guild *g;

        if( sd->status.guild_id>0 && (g=sd->guild)!=NULL)
            return guild_checkskill(g,skill_id);
        return 0;
    }
    return (sd->status.skill[idx].id == skill_id) ? sd->status.skill[idx].lv : 0;
}

 

and there's skills copy by Skotlex:

mob_clone_spawn( .... ){
...
    //Skill copy [Skotlex]
    ms = &db->skill[0];
...
}

 

but I couldn't prove if my md has copied the skills by imitating pc_checkskill :

uint8 pc_checkskill2(struct mob_data *md, uint16 skill_id)
{
	uint16 idx = 0;
	if (md == NULL)
		return 0;
	if ((idx = skill_get_index(skill_id)) == 0) {
		ShowError("pc_checkskill2: Invalid skill id %d (char_id=%d).\n", skill_id, md->charid);
		return 0;
	}
	/*if (SKILL_CHK_GUILD(skill_id) ) {
		struct guild *g;

		if( md->status.guild_id>0 && (g=md->guild)!=NULL)
			return guild_checkskill(g,skill_id);
		return 0;
	}*/
	
		ShowMessage(" dane %s %d %d %d %d", md->name, skill_id, idx, 
			md->db->skill[idx].skill_id, md->skill2[idx].id);
	return (md->db->skill[idx].skill_id == skill_id) ? md->db->skill[idx].skill_lv : 0;
}

. Though, I already did :

    memcpy(&md->skill2, &ms, sizeof(struct s_skill));

in my mob_clone_spawn2, it seems like pc_checkskill2 still outputs 0. How would you prove that the skills owned by md can be used in other functions than mob_clone_spawn?

My case is to allow a slaveclone Sage to freely move when casting (as pc_checkskill for FREECAST is currently validated for sd, not md).

Thanks!

Edited August 22, 2020 by eduardoxmenezes

[eduardoxmenezes]

Figured this out already. Since it's copied by doing:

 ms = &db->skill[0];

, therefore to access the skill, we need to dive in to db as well. Cheers

md->db->skill[index].

And so when I had to use pc_checkskill2, I also had to adjust the passive skills wanted for this function.

Edited August 22, 2020 by eduardoxmenezes