item effect not working

[louigui0224]

i dont know what seems to be the problem with my script to this item...it's not working though.

2751,Academy_Badge,Academy Of Badge,5,0,,100,,0,,4,0xFFFFFFFF,7,2,136,,0,0,0,{ bonus bAllStats,20; if(Class==Job_Knight||BaseJob==Job_Bard||BaseJob==Job_Dancer||BaseJob==Job_Assassin||BaseJob==Job_Rouge||BaseJob==Job_Priest||BaseJob==Job_Monk||BaseJob==Job_Crusader||BaseJob==Job_Wizard||BaseJob==Job_Blacksmith||BaseJob==Job_Alchemist||BaseJob==Job_TaekwonSage) bonus2 bSkillAtk,62,30; bonus2 bSkillAtk,253,30; bonus2 bSkillAtk,254,30; bonus2 bSkillAtk,136,30; bonus2 bSkillAtk,379,30; bonus2 bSkillAtk,46,45; bonus2 bSkillAtk,46,40; bonus2 bSkillAtk,382,40; bonus2 bSkillAtk,128,45; bonus2 bSkillAtk,394,50; bonus2 bSkillAtk,485,50; bonus2 bSkillAtk,42,40; bonus2 bSkillAtk,230,45; bonus2 bSkillAtk,490,50; bonus2 bSkillAtk,156,300; bAutoSpellWhenHit,"MG_SAFETYWALL",4,20,BF_WEAPON|BF_MAGIC,0; bonus2 bSkillAtk,267,40; bonus2 bSkillAtk,271,15; bonus bMatkRate,50; },{ changebase roclass(eaclass()|EAJL_THIRD); },{ changebase Class; }

 

[Skorm]

11 hours ago, louigui0224 said:

i dont know what seems to be the problem with my script to this item...it's not working though.

You didn't have bonus5 on your bautobonus command.

2751,Academy_Badge,Academy Of Badge,5,0,,100,,0,,4,0xFFFFFFFF,7,2,136,,0,0,0,{ bonus bAllStats,20; if(Class==Job_Knight||BaseJob==Job_Bard||BaseJob==Job_Dancer||BaseJob==Job_Assassin||BaseJob==Job_Rouge||BaseJob==Job_Priest||BaseJob==Job_Monk||BaseJob==Job_Crusader||BaseJob==Job_Wizard||BaseJob==Job_Blacksmith||BaseJob==Job_Alchemist||BaseJob==Job_TaekwonSage) bonus2 bSkillAtk,62,30; bonus2 bSkillAtk,253,30; bonus2 bSkillAtk,254,30; bonus2 bSkillAtk,136,30; bonus2 bSkillAtk,379,30; bonus2 bSkillAtk,46,45; bonus2 bSkillAtk,46,40; bonus2 bSkillAtk,382,40; bonus2 bSkillAtk,128,45; bonus2 bSkillAtk,394,50; bonus2 bSkillAtk,485,50; bonus2 bSkillAtk,42,40; bonus2 bSkillAtk,230,45; bonus2 bSkillAtk,490,50; bonus2 bSkillAtk,156,300; bonus5 bAutoSpellWhenHit,"MG_SAFETYWALL",4,20,BF_WEAPON|BF_MAGIC,0; bonus2 bSkillAtk,267,40; bonus2 bSkillAtk,271,15; bonus bMatkRate,50; },{ changebase roclass(eaclass()|EAJL_THIRD); },{ changebase Class; }

 

This part here will only work for transcendent Jobs like Assassin Cross.

changebase roclass(eaclass()|EAJL_THIRD);

 

For lower jobs you need to add an addition step.

roclass(eaclass()|EAJL_2_1|EAJL_THIRD);

 

[louigui0224]

@Skorm what do you mean i dont have " You didn't have bonus5 on your bautobonus command. "..and also the one that you have now in the code box is it the one that is fixed?

[Skorm]

2 hours ago, louigui0224 said:

@Skorm what do you mean i dont have " You didn't have bonus5 on your bautobonus command. "..and also the one that you have now in the code box is it the one that is fixed?

Well it was but then I looked at it again and you were missing the curlys ( { } ) around your if statement. You need those even in an item script.
I'd also like to point out that there is a limit of 10 skill buffs per character or at least that's what my console is telling me. So I removed the last few.

Here is the modified version that seems to be working.

bonus bAllStats,20; if( pow( 2, roclass( ( eaclass() & EAJ_UPPERMASK ) ) ) & 0x1F9788 ) { bonus2 bSkillAtk,62,30; bonus2 bSkillAtk,253,30; bonus2 bSkillAtk,254,30; bonus2 bSkillAtk,136,30; bonus2 bSkillAtk,379,30; bonus2 bSkillAtk,46,45; bonus2 bSkillAtk,46,40; bonus2 bSkillAtk,382,40; bonus2 bSkillAtk,128,45; bonus2 bSkillAtk,394,50; bonus5 bAutoSpellWhenHit,"MG_SAFETYWALL",4,20,BF_WEAPON|BF_MAGIC,0; bonus bMatkRate,50; }

 

 About the autobonus thing... In your script you have.
 

bAutoSpellWhenHit,"MG_SAFETYWALL",4,20,BF_WEAPON|BF_MAGIC,0;

It should be...
 

bonus5 bAutoSpellWhenHit,"MG_SAFETYWALL",4,20,BF_WEAPON|BF_MAGIC,0;

 

[louigui0224]

@Skorm thank you sir everything's working fine now...but what about this sword guardian script?? its not working...

bonus bCritical,5; bonus2 bSkillAtk,62,25; if(BaseClass==Job_Swordman) bonus bMaxHP,500; bonus bDef,2; bonus bHit,5; bonus bCritical,5; bonus2 bSkillAtk,62,45; 

 

[Skorm]

8 hours ago, louigui0224 said:

@Skorm thank you sir everything's working fine now...but what about this sword guardian script?? its not working...

bonus bCritical,5; bonus2 bSkillAtk,62,25; if( eaclass() & EAJ_SWORDMAN ) { bonus bMaxHP,500; bonus bDef,2; bonus bHit,5; bonus bCritical,5; bonus2 bSkillAtk,62,45; }