Jump to content

Maximize Power (pre-re)

closed
Evil
2013-07-21 17:49:09		When the ability to Power Maximize is on, turn off the natural regeneration of the SP, which is contrary to the description on the irony, this change appeared to be updated Renewal.
Pre-re: http://irowiki.org/classic/Power_Maximize
Renewal: http://irowiki.org/wiki/Power_Maximize
Evil
2013-07-21 17:53:48		I think that the problem is in these lines of code:

-status.c
	if (
		sc->data[SC_DANCING] || sc->data[SC_OBLIVIONCURSE] || sc->data[SC_MAXIMIZEPOWER]
		|| (
			(bl->type == BL_PC && ((TBL_PC*)bl)->class_&MAPID_UPPERMASK) == MAPID_MONK &&
			(sc->data[SC_EXTREMITYFIST] || (sc->data[SC_EXPLOSIONSPIRITS] && (!sc->data[SC_SPIRIT] || sc->data[SC_SPIRIT]->val2 != SL_MONK)))
			)
	)	//No natural SP regen
		regen->flag &=~RGN_SP;

Akinari
2013-07-21 17:54:53		That particular function I wrong was only there to consolidate the SP use when a skill has both an "on" and "off" state. What that means is if you use a skill to turn off a particular effect, you simply don't spend the SP to cast it. That has nothing to do with regeneration. However, if what you say is true and pre-re should not disable natural regeneration, then the code you're looking for is actually here.
	if (
		sc->data[SC_DANCING] || sc->data[SC_OBLIVIONCURSE] || sc->data[SC_MAXIMIZEPOWER]
		|| (
			(bl->type == BL_PC && ((TBL_PC*)bl)->class_&MAPID_UPPERMASK) == MAPID_MONK &&
			(sc->data[SC_EXTREMITYFIST] || (sc->data[SC_EXPLOSIONSPIRITS] && (!sc->data[SC_SPIRIT] || sc->data[SC_SPIRIT]->val2 != SL_MONK)))
			)
	)	//No natural SP regen
		regen->flag &=~RGN_SP;



Can someone confirm?

Edit: Looks like you beat me to it.
Evil
2013-07-21 19:20:13
	if (
		sc->data[SC_DANCING] || sc->data[SC_OBLIVIONCURSE]
#ifdef RENEWAL
				|| sc->data[SC_MAXIMIZEPOWER]
#endif
		|| (
			(bl->type == BL_PC && ((TBL_PC*)bl)->class_&MAPID_UPPERMASK) == MAPID_MONK &&
			(sc->data[SC_EXTREMITYFIST] || (sc->data[SC_EXPLOSIONSPIRITS] && (!sc->data[SC_SPIRIT] || sc->data[SC_SPIRIT]->val2 != SL_MONK)))
			)
	)	//No natural SP regen
		regen->flag &=~RGN_SP;

Antares
2013-07-22 08:53:52		I played for many years on eA - pre-pre servers, and yes, there was sp regen during the skill was active. The key word is eA, so there's always room for debate. I can't say for sure that this was official, but I think it is very unlikely that this was an unfixed bug for so many years.
Loco
2013-07-22 10:43:31		Can confirm the Bug. SP regeneration dont work for Pre Re.
Evil
2013-07-22 19:33:15		dont work, i tested and reported xD
helvetica
2013-07-23 06:23:03		Need further confirmation of official behavior. On Renewal it definitely disables SP regeneration.
Evil
2013-07-23 21:34:40		http://www.youtube.com/watch?v=HjjCm4fOBXU
Akinari
2013-07-24 08:13:39		Fixed in 0a1cf765796. Thanks Evil and everyone else!
×
×
  • Create New...