Storm Gust counter does not get reset on mob dead | closed | |
Playtester 2013-03-31 09:14:25 | Pre-renewal only: A monster should only be frozen from SG if it has already been hit 2 times by it before. This also works fine for freshly spawned monsters. However, if a monster respawns it seems the monster can also get frozen on 1st and 2nd hit. After looking through the source code, I think it's because the sg_counter doesn't get reset when the monster dies. It might also be a general bug that monster data doesn't get reset on monster death. I don't really know where to put such a reset in the source code, though. Anyone can help? | |
Lemongrass 2013-03-31 10:05:14 | Fixed in [rev=17225]. | |
Lighta 2013-03-31 16:32:17 | you can't do a memset on status since some are permanent like weight and such, they'll need to deco reco to have them back. Plus but I'm not sure I think dance continue after death | |
Playtester 2013-03-31 19:42:38 | But I tested it on the test server and it seems to be working fine, the sg_counter gets reset now. Besides this is only for monsters dieing, not for players as far as I understand, so dances and weight doesn't matter. | |
Lighta 2013-03-31 20:21:02 | ah ye ye right ok my bad, respawn for monster are like new monster ok so that make sense then. | |
Lemongrass 2013-03-31 20:32:19 | That was indeed my way of thinking lighta. I wouldnt have done it that way for players. But thanks for reviewing it. | |
Lighta 2013-04-03 05:44:34 | lemongrass this create a sub issue with timer, look at http://rathena.org/board/tracker/issue-7458-status-change-timer-error-%EC%8A%A4%ED%85%8C%EC%9D%B4%EC%8A%A4%ED%84%B0%EC%8A%A4-%ED%83%80%EC%9D%B4%EB%A8%B8-%EC%97%90%EB%9F%AC/ | |
Playtester 2013-04-03 06:27:36 | See my post in the linked thread. I guess we could just set sc_counter directly to 0? |