MVP won't drop TCG (Bug)

[fallen0519]

When I use the bottom script which edited by Emistry and Annieruru, it's weird because the normal mvp won't drop TCG, but GM summoned MVP will drop tcg. Can anyone help me fix this, I will post 2 script wonder if it's the reason they make the script fail, another script is my mvp rank ladder script. Any pro scripter please help me about this yea...

-	script	jfksdhfkjs	-1,{
OnNPCKillEvent:
	if ( !getmonsterinfo( killedrid, MOB_MVPEXP ) ) end;
	if ( getcharid(1) ) {
		getpartymember getcharid(1), 1;
		getpartymember getcharid(1), 2;
		for ( .@i = 0; .@i < $@partymembercount; .@i++ ) {
			if ( isloggedin( $@partymemberaid[.@i], $@partymembercid[.@i] ) ) { // what happens if someone in the party member is offline =/
				.@partymemberaid[.@c] = $@partymemberaid[.@i];
				.@c++;
			}
		}
		getitem 7227, 1, .@partymemberaid[ rand( .@c ) ];
		announce "Party ["+ strcharinfo(1) +"] has killed "+ getmonsterinfo( killedrid, MOB_NAME ) +" and rewarded 1 TCG at "+ strcharinfo(3), 0;
	}
	else {
		getitem 7227, 1;
		announce "Player ["+ strcharinfo(0) +"] has killed "+ getmonsterinfo( killedrid, MOB_NAME ) +" and rewarded 1 TCG at "+ strcharinfo(3), 0;
	}
	end;
}

prontera,162,152,4	script	MVP Ladder	619,{
	query_sql( "DELETE FROM `mvp_ranking` WHERE `name` NOT IN ( SELECT `name` FROM `char` )" );
	set .@size, query_sql( "select name, points from mvp_ranking where points > 0 order by points desc limit "+ .top, .@name$, .@points );
	mes "[^FF0000MvP ^0000FFRank ^996600Top ^FF0000" + .top +"^000000]";
	for (set .@c, 0; .@c < .@size; set .@c, .@c + 1)
		mes "Top ^FF0000" +(.@c + 1) +"^000000 ^0000FF" + .@name$[.@c] +"^000000 with ^FF0000" + .@points[.@c] +"^000000 MvP killed.";
	close;

OnInit: // Script Configuration
	set .a, 1; // Broadcast who killed the MvP and wich MvP and wick Map [0 Off - 1 On]
	set .top, 10; // Max. Top Rank (Hihgly recommended between 5~10, more maybe bug the server (limited variables)
	waitingroom "MvP Rank",0;
	end;

OnNPCKillEvent: // Script execution
	if ( getmonsterinfo( killedrid,MOB_MODE ) & 0x0020  == 0 ) end;// not an mvp
	if (.a) // If announce On
		announce "Player [" +strcharinfo(0) +"] had killed MVP [" +getmonsterinfo(killedrid,0) +"] in [" +strcharinfo(3) +"]",bc_blue|bc_all;
	query_sql "insert into `mvp_ranking` value ( "+ getcharid(0) +", '"+ escape_sql( strcharinfo(0) ) +"', 1 ) on duplicate key update `points` = `points` + 1";
	end;
}

[Capuche]

The mvp with theirs owns event don't trigger onnpckillevent

abbey02,236,78,21,18	boss_monster	Fallen Bishop	1871,1,7200000,600000,1

will trigger onnpckillevent and give a tgc

abbey02,236,78,21,18	boss_monster	Fallen Bishop	1871,1,7200000,600000,"npcbiddon:OnEvent"

won't give a tgc

 

.. maybe because of that?

[fallen0519]

How can I fix that yea, I need to set all mvp with the "npcbiddon:OnEvent" ? Hmmmm.....

Hope anyone can help me about this.... Bump~~~

[Capuche]

 

I need to set all mvp with the "npcbiddon:OnEvent" ? Hmmmm.....

you don't get it.. for example a mvp like thanatos (or ktu, Naght Sieger...) summoned by quest won't drop a tgc card because it will call it own event when dying.. but the others mvp will give the card.. did the other mvp give the card for you?

[fallen0519]

No, other MVP didnt give a card, Ex: Eddga, Maya, Tao Gunka and etc...

i did set something like this because its for the MVP check script.

beach_dun,0,0,0,0	boss_monster	Tao Gunka	1583,1,18000000,600000,"convex::OnMyMvPDead"

//===== eAthena Script =======================================
//= Super Convex Mirror
//===== By: ==================================================
//= Brian
//===== Current Version: =====================================
//= 1.0
//===== Compatible With: =====================================
//= eAthena SVN
//===== Description: =========================================
//= Detects if every MVP is alive or dead.
//===== Additional Comments: =================================
//= http://www.eathena.ws/board/index.php?showtopic=242050
//============================================================

prontera,144,173,5	script	MVP Board::convex	857,{
	if (!.display_type) donpcevent strnpcinfo(3)+"::OnInit"; // initialize variables
	for( set .@i,0; .@i < getarraysize(.mvp_name$); set .@i, .@i+1 ) {
		switch (.@i) {
			case 9:  set .@alive, mobcount("lhz_dun03","summon_boss_lt::OnMyMvPDead"); break;
			case 29: set .@alive, ($ktullanux_summon<4 || mobcount("ice_dun03","ice_boss#on::OnMyMobDead")); break;
			case 31: set .@alive, mobcount("niflheim","NifInvasion::OnLoDDead"); break;
			case 46: set .@alive, ($@thana_summon<6 || mobcount("thana_boss","#Death::OnThanaDead")); break;
			default: set .@alive, mobcount(.mvp_map$[.@i],"convex::OnMyMvPDead"); break;
		}
		if (.display_type == 2)
			set .@menu$, .@menu$+ (.@alive ? "^008000" : "^FF0000") + .mvp_name$[.@i] +"^000000 ("+ .mvp_map$[.@i] +"):";
		else if (.display_type == 1)
			mes (.@alive ? "^008000" : "^FF0000") + .mvp_name$[.@i] +"^000000 ("+ .mvp_map$[.@i] +")";
	}
	
	if (.display_type == 2)
		set .@num, select(.@menu$) -1;
	if (.warp_to_mvp >= 1)
		warp .mvp_map$[.@num],0,0;
	if (.warp_to_mvp == 2) {
		sleep2 1000;
		sc_start SC_BOSSMAPINFO,600000,0;
	}
	end;

OnInit:
waitingroom "MVP Board",0;
	set .display_type, 2; // 1=mes, 2=menu
	set .warp_to_mvp, 2; // 0=disabled, 1=enabled, 2=enabled+SC_BOSSMAPINFO
	
	setarray .mvp_map$[0], 
		"moc_pryd06","ra_fild02","ra_fild03","ra_fild04","ve_fild01",
		"ve_fild02","lou_dun03","prt_maze03","abbey03","lhz_dun03","bra_dun02",
		"gl_chyard","gld_dun04","abyss_03","gef_dun02","gld_dun02","gef_dun01","treasure02",
		"pay_fild11","gld_dun01","gon_dun03","abbey02","xmas_fild01","ra_san05",
		"prt_sewb4","mosk_dun03","thor_v03","ama_dun03",
		"kh_dun02","ice_dun03","ayo_dun02","niflheim","anthell02","gld_dun03",
		"mjolnir_04","pay_dun04","2@nyd","gef_fild02","gef_fild14","gef_fild10",
		"moc_pryd04","in_sphinx5","moc_fild17","ein_dun02","xmas_dun02",
		"beach_dun","thana_boss","tur_dun04","odin_tem03",
		"jupe_core","moc_fild22","lhz_dun02";
	setarray .mvp_name$[0], 
		"AmonRa","Atroce","Atroce","Atroce","Atroce",
		"Atroce","Bacsojin","Baphomet","Beelzebub","Biolab3","Boitata",
		"DarkLord","DarkLord","Detale","Doppelganger","Doppelganger","Dracula","Drake",
		"Eddga","Eddga","EvilSnakeLord","FallenBishop","Garm","GloomUnderNight",
		"GoldenThiefBug","Gopinich","Ifrit","IncantationSamurai",
		"KielD01","Ktullanux","LadyTanee","LordofDeath","Maya","Maya",
		"Mistress","MoonlightFlower","NidhoggrShadow","OrcHero","OrcHero","OrcLord",
		"Osiris","Pharaoh","Phreeoni","RSX0806","StormyKnight",
		"TaoGunka","Thanatos","TurtleGeneral","ValkyrieRandgris",
		"Vesper","Wounded Morroc","Ygnizem";
	if (.warp_to_mvp) set .display_type,2; // in order for the user to pick an option, the list must be displayed as a menu
OnMyMvPDead:
	end;
}