freebies npc per account problem

[unknownuser]

 

//Freebies Giver NPC
//by: GM Dan of InfiniteRO
prontera,147,171,3    script    IRO Freebies Giver    509,{




mes "[^000088 Freebies Giver ^000000]";
mes "Hello "+strcharinfo(0)+", Welcome To Infinite-RO.";
mes "I'm the freebies giver.";
mes "I only give 1 freebies per account and can be use by this character only.";
next;
mes "[^000088 Freebies Giver ^000000]";
mes "Character Type.";
mes "Please Choose";


switch(select("Strength Type:Intelligence Type:Dexterity Type")) {
        case 1:    callsub S_Free1;
        case 2:    callsub S_Free2;
        case 3:    callsub S_Free3;
        
    }
    end;
    
S_Free1:
    
    Switch (Select ("Please Bless me:I Change my mind")) {
        Case 1:
            if E.G(#quest_done == 1) { //Check for every character add # if you want to choose per account E.G(#quest_done == 1)
            mes "You already have your freebies.";
            close;
            }


            getitem2 2357,1,1,7,0,0,0,0,0; // +7 valkarmor
            getitem2 2524,1,1,7,0,0,0,0,0; // +7 valkmant
            getitem2 2421,1,1,7,0,0,0,0,0; // +7 valksh
            getitem2 2102,1,1,7,0,0,0,0,0; // +7 Guard[1]
            getitem2 2115,1,1,7,0,0,0,0,0; // +7 Shoes[1]
            getitem 4174, 2;
            getitem 4302, 2;
            getitem 4142, 3;       
            set E.G(#quest_done == 1); //Check for every character add # if you want to choose per account E.G(#quest_done == 1)
            mes "Enjoy your Gifts.";
            close;
            
        Case 2:
            Mes "Come back for my Blessing";
            Mes "Thank you";
            Break;


            }
            Close;


S_Free2:
    
    Switch (Select ("Please Bless me:I Change my mind")) {
        Case 1:
            if E.G(#quest_done == 1) {    //Check for every character add # if you want to choose per account E.G(#quest_done == 1)
            mes "You already have your freebies.";
            close;
            }


            getitem2 2357,1,1,7,0,0,0,0,0; // +7 valkarmor
            getitem2 2524,1,1,7,0,0,0,0,0; // +7 valkmant
            getitem2 2421,1,1,7,0,0,0,0,0; // +7 valksh
            getitem2 2102,1,1,7,0,0,0,0,0; // +7 Guard[1]
            getitem2 2115,1,1,7,0,0,0,0,0; // +7 Shoes[1]
            getitem 4174, 2;
            getitem 4302, 2;
            getitem 4142, 3;  
            set E.G(#quest_done == 1);    //Check for every character add # if you want to choose per account E.G(#quest_done == 1)
            mes "Enjoy your Gifts.";
            close;
            
        Case 2:
            Mes "Come back for my Blessing";
            Mes "Thank you";
            Break;


            }
            Close;


S_Free3:
    
    Switch (Select ("Please Bless me:I Change my mind")) {
        Case 1:
            if E.G(#quest_done == 1) {    //Check for every character add # if you want to choose per account E.G(#quest_done == 1)
            mes "You already have your freebies.";
            close;
            }


            getitem2 2357,1,1,7,0,0,0,0,0; // +7 valkarmor
            getitem2 2524,1,1,7,0,0,0,0,0; // +7 valkmant
            getitem2 2421,1,1,7,0,0,0,0,0; // +7 valksh
            getitem2 2102,1,1,7,0,0,0,0,0; // +7 Guard[1]
            getitem2 2115,1,1,7,0,0,0,0,0; // +7 Shoes[1]
            getitem 4174, 2;
            getitem 4302, 2;
            getitem 4142, 3;  
            set E.G(#quest_done == 1);    //Check for every character add # if you want to choose per account E.G(#quest_done == 1)
            mes "Enjoy your Gifts.";
            close;
        
        Case 2:
            Mes "Come back for my Blessing";
            Mes "Thank you";
            Break;


            }
            Close;
            
OnInit:
waitingroom "WELCOME",0;
end;
}

I want single freebies for every account ?? help me to fix this ,

 

 

Thank you

Edited October 17, 2013 by Patskie
Change to code

[Ryokem]

I'm not really updated about Athena, but you can try to remove the "E.G" part in every variable check call.

if( #quest_done ) {
 
set #quest_done, 1;

 

Also, your freebies, even if divided by "Strengh, Dexterity and Intellect Type", give all the same items (you may need to check thi

[unknownuser]

sir it's not working

[Ryokem]

prontera,147,171,3    script    IRO Freebies Giver    509,{

mes "[^000088 Freebies Giver ^000000]";
mes "Hello "+strcharinfo(0)+", Welcome To Infinite-RO.";
mes "I'm the freebies giver.";
mes "I only give 1 freebies per account and can be use by this character only.";
next;
mes "[^000088 Freebies Giver ^000000]";
 
if(#freebies) {
    mes "You already have your freebies.";
    close;
}
 
if (select ("Please Bless me:I Change my mind") == 2) {
    Mes "Come back for my Blessing";
    Mes "Thank you";
    close;
}
 
else {
    set #freebies, 1;
    getitem2 2357,1,1,7,0,0,0,0,0; // +7 valkarmor
    getitem2 2524,1,1,7,0,0,0,0,0; // +7 valkmant
    getitem2 2421,1,1,7,0,0,0,0,0; // +7 valksh
    getitem2 2102,1,1,7,0,0,0,0,0; // +7 Guard[1]
    getitem2 2115,1,1,7,0,0,0,0,0; // +7 Shoes[1]
    getitem 4174, 2;
    getitem 4302, 2;
    getitem 4142, 3;       
 
    mes "[^000088 Freebies Giver ^000000]";
    mes "Enjoy your Gifts.";
    close;
 }
end; //Should never happen
            
OnInit:
waitingroom "WELCOME",0;
end;
}

[unknownuser]

i will test it . thanks for helping me out from this work

[Ryokem]

Refering to this thread, don't forget to add proper tabulations in the header.