Map checks using array variables

[Mumbles]

So I'm trying to write a condition where if your character is not on one of these maps:

 

        // Town Definitions    
        setarray .@mapname$[0],"prontera","morocc","geffen","payon","alberta","izlude","aldebaran","xmas","comodo","yuno","amatsu","gonryun","umbala","niflheim","louyang","lunette","in_moc_16","jawaii","ayothaya","einbroch","lighthalzen","einbech","hugel","rachel","veins","moscovia","schenberg";  

 

 

you will be undisguised:

 

    OnPCLoadMapEvent:
        for(set .@i,0; .@i < getarraysize(.@mapname$); set .@i,.@i+1) {
            if( "+.@mapname$[.@i]+" == strcharinfo(3))
                set .@a,1;
            if(!.@a) {
                undisguise;
                end;
           }

 

 

As written, it's not quite confirming that you are not on the maps in the array. What am I doing wrong?

[Brian]

Yes, every single map needs the loadevent mapflag in order to trigger OnPCLoadMapEvent ... unless you did one of these source edits

1) when maps are loaded, loadevent mapflag is added to every map

2) change OnPCLoadMapEvent to trigger on all maps, even if they don't have the loadevent mapflag

It looks like (almost) all your maps in .@mapname$[] are already listed in trunk/conf/mapflag/town.txt right? Then you could just check mapflag#town.

-	script	undisguise_me	-1,{
OnPCLoadMapEvent:
	if (!getmapflag(strcharinfo(3), mf_town)) {
		undisguise;
	}
	end;
}

[PewN]

try to change the 

 

 

if( "+.mapname$[.@i]+" == strcharinfo(3) )

 

to

 

if(strcharinfo(3) == .mapname$[.@i] )

and btw. did u add loadmapevent mapflag on your map's?

Edited March 2, 2013 by TrojanWorm

[Mumbles]

Does that even matter? I've used the OnPCLoadMapEvent label before on maps without the loadevent mapflag; what makes towns any different? In any case, I want the script to check if the map you loaded on was not in the array, so wouldn't that require every single map that isn't a town to have the loadevent mapflag?

[Mumbles]

Thanks Brian; contrary to what I originally requested, what you suggested works much better.