Jump to content

Script Comments Bugreport:6714

Spre

By Spre
in Implemented

 Share

Recommended Posts

Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
Posted

I ahve been going through the item DB the last few days, based on that bug report in the title, link here: bugreport:6714

upon Testing I only found a few of the commented out items/scripts were still undeveloped, Mainly madoheal on the repair items.

A few items like the aodai have sprite errors(could just be my client though)

But if noone has any issue with it, I am almost ready to submit the changes. alot of the commented out scripts it appears were from when the functions did not exist, and items from before there was sprite support in the client for them?

anyway I needed thoughts on it, as this updates alot of items in the database makes them useable and or whole with their scripts, I think when i finished there were like 250+ items effected.

Link to comment
Share on other sites
Euphy Poring

Euphy

Posted
  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  
Posted

Post your patch in the dev forums before any large update, so that others can look over it. If items give sprite errors, do not add them. If scripts don't work, don't uncomment them.

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

Post your patch in the dev forums before any large update, so that others can look over it. If items give sprite errors, do not add them. If scripts don't work, don't uncomment them.

yea I know that last part, any way you can look at the aodai items? item # are 2361, 2362, 2363 see if they give you sprite errors? Myclient I don't think completely updated,

and I have to head out to work soon, so I'll finish it up hopefully when I get out at 1am and post a patch.

Link to comment
Share on other sites
Euphy Poring

Euphy

Posted
  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  
Posted
item # are 2361, 2362, 2363

Yup, I get errors too.

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

ok,

Now Ring of flame lord and resonance, why are those erroring kRO renewal uhhhh 6/2010 client (i think 6-10-2010) Thos have been in kRO for the longest time, as a matter of fact in late 2009 I was using them?

Also Korean Trinkit and jade ring cause a complete client crash, so those should be left blank.

I am in final testing stages right now.

Here we go. I don;t believe I forgot anything, I tested the following, Droping, getting, Viewing, Putting on. Error on none except what I didn't uncomment.

Scripts that were commented out uncommented do not error the map server and seem to work.

a few items still aren;t there, alot of those are non kRO items.

on a side note:

Lucky clip works fine, it does need its item script, AFTER it is confirmed.

02:15 Spre • lucky Clip works great, was commented out no errors, but its description says "increase drops by 50%"

02:15 Spre • has no item script for it though

02:16 Spre • also I need someone to test ring of flame lord and ressonance, because those items have been in ro for a few years since ifrit debut, yet they error my client O_O

02:18 Spre • and IND you are the only one up so I volunteer you! lmao

02:19 &Ind • o-o

02:19 &Ind • you sure that is accurate?

02:19 &Ind • lol

02:20 Spre • the items, or you the only one up?

02:22 &Ind • o-o

02:22 &Ind • the item effect

02:22 &Ind • increase drops by 50% doesnt look like something gravity would do oO i think it might be badly translated

02:23 Spre • yea I dunno, then again it might be a rental or cashshop item. I'll utilize google search on that try to find out

02:24 Spre • http://forums.irowiki.org/showthread.php?t=74634

02:24 Spre • O_o

02:25 Spre • loos like it does in fRO maybe,

02:25 &Ind • we need more data on that then

02:26 Spre • mmmhmm sure do

itemchanges.diff

Link to comment
Share on other sites
Euphy Poring

Euphy

Posted
  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  
Posted

There are still some problems with it:

1. Almost all of the comments /* */ you removed now have double-spaces between scripts.

2. Why did you change this?

-  `defence` smallint(5) unsigned default NULL,
+  `defence` smallint(5) NULL default NULL,

3. A few other questions/mistakes, from skimming the file:

  • Should not uncomment an item named "????_???".
    -# REPLACE INTO `item_db_re` VALUES (7804,'????_???','????_???',3,NULL,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);
+REPLACE INTO `item_db_re` VALUES (7804,'????_???','????_???',3,NULL,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);


  • You commented these lines, why? Also, misplaced "#" line in first +.
    -REPLACE INTO `item_db_re` VALUES (12392,'Repair_A','Repair A',0,220,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,'/* madoheal rand(200,300),0; */',NULL,NULL);
-REPLACE INTO `item_db_re` VALUES (12393,'Repair_B','Repair B',0,500,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,'/* madoheal rand(300,400),0; */',NULL,NULL);
-REPLACE INTO `item_db_re` VALUES (12394,'Repair_C','Repair C',0,1100,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,'/* madoheal rand(400,500),0; */',NULL,NULL);
+# REPLACE INTO `item_db_re` VALUES (12392,'Repair_A','Repair A',0,220,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,#' madoheal rand(200,300),0; ',NULL,NULL);
+# REPLACE INTO `item_db_re` VALUES (12393,'Repair_B','Repair B',0,500,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,' madoheal rand(300,400),0; ',NULL,NULL);
+# REPLACE INTO `item_db_re` VALUES (12394,'Repair_C','Repair C',0,1100,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,' madoheal rand(400,500),0; ',NULL,NULL);


Do you have the pre-re and txt databases done as well?

  • Upvote 1
Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

There are still some problems with it:

1. Almost all of the comments /* */ you removed now have double-spaces between scripts.

2. Why did you change this?

-  `defence` smallint(5) unsigned default NULL,
+  `defence` smallint(5) NULL default NULL,

3. A few other questions/mistakes, from skimming the file:

  • Should not uncomment an item named "????_???".
    -# REPLACE INTO `item_db_re` VALUES (7804,'????_???','????_???',3,NULL,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);
+REPLACE INTO `item_db_re` VALUES (7804,'????_???','????_???',3,NULL,NULL,10,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL,NULL);


  • You commented these lines, why? Also, misplaced "#" line in first +.
    -REPLACE INTO `item_db_re` VALUES (12392,'Repair_A','Repair A',0,220,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,'/* madoheal rand(200,300),0; */',NULL,NULL);
-REPLACE INTO `item_db_re` VALUES (12393,'Repair_B','Repair B',0,500,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,'/* madoheal rand(300,400),0; */',NULL,NULL);
-REPLACE INTO `item_db_re` VALUES (12394,'Repair_C','Repair C',0,1100,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,'/* madoheal rand(400,500),0; */',NULL,NULL);
+# REPLACE INTO `item_db_re` VALUES (12392,'Repair_A','Repair A',0,220,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,#' madoheal rand(200,300),0; ',NULL,NULL);
+# REPLACE INTO `item_db_re` VALUES (12393,'Repair_B','Repair B',0,500,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,' madoheal rand(300,400),0; ',NULL,NULL);
+# REPLACE INTO `item_db_re` VALUES (12394,'Repair_C','Repair C',0,1100,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,' madoheal rand(400,500),0; ',NULL,NULL);


Do you have the pre-re and txt databases done as well?

1: Minor detail that will be fixed, they still loaded so, that'll get done before comitt

2: atleast one item has negative def at this time, unsigned can not go negative, and the only other difference is the range, and since there won;t be any item with def of 31k+ that doesn;t negatively effect it. *resurect egg shell* once it is in kRO if it does, has negative 7 def.

3 Oops haha good catch i didn't even see that on the ??? ones, for the second part, those items do not work and error the map-server, madoheal is not a defined function I just commented them out for now, but I should've place the script comments back in instead.

The other databases not yet but I'll fly through those, I did re sql first because I use sql and I love sql and re is awesome.

I am off to work right now though, I'll be back online at about quarter after 1am est

Here is the new DIFF

pre-re SQL re SQL and re TXT

itemchanges.diff

  • Upvote 3
Link to comment
Share on other sites
Joseph Poring

Joseph

Posted
  • Group:  Members
  • Topic Count:  5
  • Topics Per Day:  0.00
  • Content Count:  341
  • Reputation:   43
  • Joined:  01/10/12
  • Last Seen:  
Posted

Are these official?

+13919,?L_Magestic_Goat_Box?,Baphomet Horns Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5374,1; },{},{}
+13920,?Satanic_Chain_P_Box?,Flying Evil Wing Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5376,1; },{},{}
+13921,?Antique_Pipe_Box?,Gentleman's Pipe Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5377,1; },{},{}
+13922,?Rabbit_Ear_Hat_Box?,Bunny Top Hat Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5378,1; },{},{}
+13923,?Darkness_Helm_Box?,Dark Randgris Helm Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5373,1; },{},{}
+13924,?L_Orc_Hero_Helm_Box?,Orc Hero Headdress Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5375,1; },{},{}



+REPLACE INTO `item_db` VALUES (13918,'?Drooping_W_Kitty_Box?','Koneko Hat Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5372,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13919,'?L_Magestic_Goat_Box?','Baphomet Horns Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5374,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13920,'?Satanic_Chain_P_Box?','Flying Evil Wing Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5376,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13921,'?Antique_Pipe_Box?','Gentleman\'s Pipe Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5377,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13922,'?Rabbit_Ear_Hat_Box?','Bunny Top Hat Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5378,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13923,'?Darkness_Helm_Box?','Dark Randgris Helm Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5373,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13924,'?L_Orc_Hero_Helm_Box?','Orc Hero Headdress Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5375,1;',NULL,NULL);

Mistakes:

+  `id` smallint(5) unsigned NOT NULL default0',
+  `name_english` varchar(50) NOT NULL default',
+  `name_japanese` varchar(50) NOT NULL default',
+  `type` tinyint(2) unsigned NOT NULL default0',


+  `weight` smallint(5) unsigned NOT NULL default0',

Also, add the upgrade patch.

ALTER TABLE `item_db_re` MODIFY `defence` SMALLINT(5) DEFAULT NULL;

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

Are these official?

+13919,?L_Magestic_Goat_Box?,Baphomet Horns Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5374,1; },{},{}
+13920,?Satanic_Chain_P_Box?,Flying Evil Wing Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5376,1; },{},{}
+13921,?Antique_Pipe_Box?,Gentleman's Pipe Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5377,1; },{},{}
+13922,?Rabbit_Ear_Hat_Box?,Bunny Top Hat Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5378,1; },{},{}
+13923,?Darkness_Helm_Box?,Dark Randgris Helm Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5373,1; },{},{}
+13924,?L_Orc_Hero_Helm_Box?,Orc Hero Headdress Box,18,20,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5375,1; },{},{}



+REPLACE INTO `item_db` VALUES (13918,'?Drooping_W_Kitty_Box?','Koneko Hat Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5372,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13919,'?L_Magestic_Goat_Box?','Baphomet Horns Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5374,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13920,'?Satanic_Chain_P_Box?','Flying Evil Wing Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5376,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13921,'?Antique_Pipe_Box?','Gentleman\'s Pipe Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5377,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13922,'?Rabbit_Ear_Hat_Box?','Bunny Top Hat Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5378,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13923,'?Darkness_Helm_Box?','Dark Randgris Helm Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5373,1;',NULL,NULL);
+REPLACE INTO `item_db` VALUES (13924,'?L_Orc_Hero_Helm_Box?','Orc Hero Headdress Box',18,20,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5375,1;',NULL,NULL);

Mistakes:

+  `id` smallint(5) unsigned NOT NULL default0',
+  `name_english` varchar(50) NOT NULL default',
+  `name_japanese` varchar(50) NOT NULL default',
+  `type` tinyint(2) unsigned NOT NULL default0',


+  `weight` smallint(5) unsigned NOT NULL default0',

Also, add the upgrade patch.

ALTER TABLE `item_db_re` MODIFY `defence` SMALLINT(5) DEFAULT NULL;

Finally some feedback!

I have to believe they are official, as all i run right now is official kRO grfs and those have all the sprites and images and descriptions and what not

and whooooa thanks joseph I just noticed that, I will get that fixed, that is no minor error that'll error sql in a heartbeat.

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

Ok unless anything else is spotted this is the final diff, the one I believe is ready to comitt(unless I missed something small)

FinalItemChanges.diff

Link to comment
Share on other sites
Euphy Poring

Euphy

Posted
  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  
Posted

Rentitem scripts are incorrect.

[Error]:
script error on db/re/item_db.txt line 6265
   parse_line: need ';'
* 6265 : { rentitem 2369,1','604800; }
[Error]:
script error on db/re/item_db.txt line 6266
   parse_line: need ';'
* 6266 : { rentitem 2428,1','604800; }
[Error]:
script error on db/re/item_db.txt line 6267
   parse_line: need ';'
* 6267 : { rentitem 2533,1','604800; }

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

oh poop, those are like that in the svn i just forgot to edit the txt ones someone boobooed when they did that

edit.

bam fixedededed

13691,Freyja_Overcoat_Box,Freya's Clothes Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ rentitem 2369,604800; },{},{}
13692,Freyja_Boots_Box,Freya's Boots Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ rentitem 2428,604800; },{},{}
13693,Freyja_Cape_Box,Freya's Manteau Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ rentitem 2533,604800; },{},{}

Link to comment
Share on other sites
  • 3 weeks later...
Joseph Poring

Joseph

Posted
  • Group:  Members
  • Topic Count:  5
  • Topics Per Day:  0.00
  • Content Count:  341
  • Reputation:   43
  • Joined:  01/10/12
  • Last Seen:  
Posted

Bump.

Any updates on this?

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted

Im ready just awaiting euphys thumbs up

Link to comment
Share on other sites
Euphy Poring

Euphy

Posted
  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  
Posted

Oh, what? xD The rest looked fine, you don't need to wait on me.

Link to comment
Share on other sites
Spre Poring

Spre

Posted
  • Group:  Members
  • Topic Count:  8
  • Topics Per Day:  0.00
  • Content Count:  103
  • Reputation:   28
  • Joined:  09/20/12
  • Last Seen:  
  • Author
Posted (edited)

Oh i thought i did my mistake i am at work but ill connect to my pc and run it now

Done in r16822.

Edited by Euphy
Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...