mkbu95's msg_athena update diff

[Ind]

@mkbu95 sent me this early this week, its a great update for the msg_athena system however there is one small detail impeding me from moving on with it and I'd like your opinion about it, it seems the whitespaces are being screwed up at some point (not by his additions to the system, but by something else) which makes many messages layout end up wrong (e.g. @job's one), any ideas? Thank you for your time. atcommand_msg_athena.patch

[Brian]

We could do 2 commits:

1. mkbu95's msg_athena patch
   
2. fix the spacing in @go and @job
   

EDIT: #1 done in r16724

#2 I'll do tomorrow

Edited August 31, 2012 by Brian

[Brian]

I thought all he did was copy-paste those hard-coded messages from atcommand.c and put them in msg_athena.conf

[Euphy]

I've fixed and standardized all msg_athena messages. Mind if I commit them?

msg_athena.patch

Only afterwards did I realize the original messages are in the source as comments. I didn't change those. Are they even needed?

---

This is a patch to Ind's patch, didn't realize it was committed already e.e.

msg_athena.conf.patch

[Brian]

Looks good to me.

[Brian]

The %c is for the atcommand symbol.

The hard-coded message before was:

sprintf(atcmd_output, "Help for command %c%s:", atcommand_symbol, command_name);

[Euphy]

Jman/Brian: Thanks, I had no idea how those things worked. xD So I should leave that line alone?

I'll wait a couple more hours before I commit since this isn't urgent.

Edit: Done, r16725.

[Brian]

Couple of things:

+
+// @help
+988: There is no help for this command_name.
+989: Help for command %c%s:
+990: Available aliases:
+

988: Shouldn't that be %s?

i.e.:

988: There is no help for the command %s

?

Other than that, looks good from here. Thanks Euphy for the quick corrections.

Oh now I see what you're talking about XD

Yes, it should be:

988: There is no help for %c%s.

and atcommand.c replace line 1597 with:

sprintf(atcmd_output, msg_txt(988), atcommand_symbol, command_name); // There is no help for %c%s.
clif_displaymessage(fd, atcmd_output);

Edited August 31, 2012 by Brian

[lekkereten]

The line was like this:

clif_displaymessage(fd, "There is no help for this command_name.");

And I didn't realize it should be a parameter x)

Thanks for the corrections Euphy

@edit

I changed all strings that were modified on r16725 to reflect on atcommand.c (I think I covered everything).

Also, I added the commentaries on @send that I forgot, and commented the lines with custom jobs on @jobchange.

atcommand.c.patch

[Brian]

2. fix the spacing in @go and @job

Done in r16729/rathena/trunk/conf/help.txt

• Changed the column spacing in @go (town list) and @job (jobname list) so it lines up for Arial font, instead of fixed-width fonts.

[Euphy]

Applied mkbu95's patch in r16735. Thanks!