issue: No limit to plant summons.

[greasebag]

This ended up just being the land_skill_limit setting being wrong in /battle/skill.conf

Bio Cannibalize skill on my server is completely boundless.

Typically you can only cast up to a maxcount of plants where the maximum is defined by the skill level of Cannibalize. If you try to cast when your number of plants is equal to or greater than the max count it is supposed to fail.

It will not fail.

This is normal if you are on a GM account since it ignores the fail entirely. Unfortunately, this is not the issue. Normal accounts can still cast this skill infinitely.

In case you have never looked at this code ill put it below:

case AM_CANNIBALIZE:
case AM_SPHEREMINE:
{
 int c=0;
 int summons[5] = { 1589, 1579, 1575, 1555, 1590 };
 //int summons[5] = { 1020, 1068, 1118, 1500, 1368 };
 int maxcount = (skill==AM_CANNIBALIZE)? 6-lv : skill_get_maxcount(skill,lv);
 int mob_class = (skill==AM_CANNIBALIZE)? summons[lv-1] :1142;
 if(battle_config.land_skill_limit && maxcount>0 && (battle_config.land_skill_limit&BL_PC)) {
  i = map_foreachinmap(skill_check_condition_mob_master_sub ,sd->bl.m, BL_MOB, sd->bl.id, mob_class, skill, &c);
  if(c >= maxcount ||
(skill==AM_CANNIBALIZE && c != i && battle_config.summon_flora&2))
  { //Fails when: exceed max limit. There are other plant types already out.
clif_skill_fail(sd,skill,USESKILL_FAIL_LEVEL,0);
return 0;
  }
 }
 break;
}

The real issue here is that this code has never been touched. The summon_flora options in the battle config seem to have no effect on the skill either, or if it does it's being ignored.

So, basically,

what could be causing this issue other than the source for the skill itself, or the battle config options?

Edited May 6, 2012 by greasebag