Help in Hourly Points

[Sallycantdance]

hello im having a problem while the players are fishing they cant get any hourly coins, can someone check it thank you

 

Quote

-    script hourly_point_main  -1,{
 
    OnInit:
        .npc_name$ = strnpcinfo(3);
        bindatcmd "check",.npc_name$+"::OnAtcommand";
        end;
 
    OnAtcommand:
        dispbottom "Accumulated "+#daily_minute_count;
        end;
 
    OnUpdate:
        if (checkvending() & 2) end;
        #daily_minute_count++;
        deltimer .npc_name$+"::OnUpdate";
        switch ( #daily_minute_count ) {
            default:
                break;
            case 60: // 60 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 120: // 120 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 180: // 180 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 240: // 240 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 300: // 300 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 360: // 360 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 420: // 420 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 480: // 480 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                #daily_minute_count = 0; // reset.
                break;
        }
 
    OnPCLoginEvent:
        addtimer ( 60 * 1000 ), .npc_name$+"::OnUpdate";
        end;
}

 

[Winterfox]

-    script hourly_point_main  -1,{
     OnInit:
        .npc_name$ = strnpcinfo(3);
        .reward_minutes = 60;
        bindatcmd("check", .npc_name$ + "::OnAtcommand");
        end;
 
    OnAtcommand:
        dispbottom("Accumulated " + #daily_minute_count);
        end;
 
    OnPCLoginEvent:
        addtimer(.reward_minutes * 60000, .npc_name$ + "::OnUpdate");
        end;

    OnUpdate:
        deltimer(.npc_name$ + "::OnUpdate");
        addtimer(.reward_minutes * 60000, .npc_name$ + "::OnUpdate");

        if (checkvending() & 2) {
            end;
        }

        #daily_minute_count += .reward_minutes;

        switch(#daily_minute_count) {
            case 60: // 60 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 120: // 120 minutes 
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 180: // 180 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 240: // 240 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 300: // 300 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 360: // 360 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 420: // 420 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 480: // 480 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                #daily_minute_count = 0; // reset.
                break;
            default:
                break;
        }
}

 

Edited January 11, 2024 by Winterfox

[Sallycantdance]

2 hours ago, Winterfox said:

-    script hourly_point_main  -1,{
     OnInit:
        .npc_name$ = strnpcinfo(3);
        .reward_minutes = 60;
        bindatcmd("check", .npc_name$ + "::OnAtcommand");
        end;
 
    OnAtcommand:
        dispbottom("Accumulated " + #daily_minute_count);
        end;
 
    OnPCLoginEvent:
        addtimer(.reward_minutes * 60000, .npc_name$ + "::OnUpdate");
        end;

    OnUpdate:
        deltimer(.npc_name$ + "::OnUpdate");
        addtimer(.reward_minutes * 60000, .npc_name$ + "::OnUpdate");

        if (checkvending() & 2) {
            end;
        }

        #daily_minute_count += .reward_minutes;

        switch(#daily_minute_count) {
            case 60: // 60 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 120: // 120 minutes 
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 180: // 180 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 240: // 240 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 300: // 300 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 360: // 360 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 420: // 420 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                break;
            case 480: // 480 minutes
                #CASHPOINT += 1;
                getitem 677,1;
                #daily_minute_count = 0; // reset.
                break;
            default:
                break;
        }
}

 

i still cant get any hourly coins , also after using @check while fishing the command this showing then if i cancel the fishing the accumulated points are still the same as the 1st check while not fishing anyways ty for your effort sir i appreciate it 

[Johnson]

Better to use this if you're using 2021+ clients

https://github.com/rathena/rathena/pull/7410/files

[Sallycantdance]

1 hour ago, khouuming21 said:

Better to use this if you're using 2021+ clients

https://github.com/rathena/rathena/pull/7410/files

im using a custom item as a hourly points  

[Winterfox]

11 hours ago, GM Winter said:

i still cant get any hourly coins , also after using @check while fishing the command this showing then if i cancel the fishing the accumulated points are still the same as the 1st check while not fishing anyways ty for your effort sir i appreciate it 

Can you show your fishing script?