Skills promotion ATK formula error?

[mina]

[Lv 5] : Movement Speed 100% increase / ATK 50 increase

https://www.divine-pride.net/database/skill/2478/

Atk+50 is not work?

ATK bonus is added to the damage instead of the status

EX: I attack the monster 10 damage.

Use Geneticist Cart Boost [Lv 5] : Movement Speed 100% increase / ATK 50 increase

But, I attack the monster 60 damage, atk status is not work

SVN revision: 45186

Edited April 13, 2019 by mina

[Sakurada]

34 minutes ago, mina said:

How can I do this?

if(sc->data[SC_GN_CARTBOOST]) {
				ATK_ADD(wd->damage, wd->damage2, 10 * sc->data[SC_GN_CARTBOOST]->val1);

 

status.c

change this

	set_sc( GN_CARTBOOST			, SC_GN_CARTBOOST	, EFST_GN_CARTBOOST			, SCB_SPEED|SCB_WATK );

add scb_watk

 

find this

	if(sc->data[SC_WATKFOOD])
		watk += sc->data[SC_WATKFOOD]->val1;
	if(sc->data[SC_VOLCANO])
		watk += sc->data[SC_VOLCANO]->val2;
	if(sc->data[SC_MERC_ATKUP])
		watk += sc->data[SC_MERC_ATKUP]->val2;

add a new one 

	if(sc->data[SC_GN_CARTBOOST])
		watk += sc->data[SC_GN_CARTBOOST]->val4;

 

find this

		case SC_GN_CARTBOOST:
			if( val1 < 3 )
				val2 = 50;
			else if( val1 > 2 && val1 < 5 )
				val2 = 75;
			else
				val2 = 100;
			break;

add val4= 50; at the top

like so

		case SC_GN_CARTBOOST:
			val4 = 50; // Watk increase
			if( val1 < 3 )
				val2 = 50;
			else if( val1 > 2 && val1 < 5 )
				val2 = 75;
			else
				val2 = 100;
			break;

 

 

 

That should do it unless you want batk if that matters just change scb_watk to scb_batk and change watk in second part to batk , might have  to move it to other section with others tho 

 

recompile

 

 

 

Edited April 13, 2019 by AndyTheGoblin

[mina]

4 hours ago, AndyTheGoblin said:

no we dont have that here

do you want it?

so, Rathena is not support?

[mina]

2 hours ago, AndyTheGoblin said:

no support 

but really easy to add

How can I do this?

if(sc->data[SC_GN_CARTBOOST]) {
				ATK_ADD(wd->damage, wd->damage2, 10 * sc->data[SC_GN_CARTBOOST]->val1);

 

[mina]

11 hours ago, AndyTheGoblin said:

哦，我們確實有這個 

從來沒有這樣做，給我一個......它可能是同樣的事情，但我不知道在哪裡放置它

 

 

你能找到你的代碼嗎？ 

thx, i can~

and ATK_ADD is in battle.cpp

battle.cpp:

ATK_ADD(wd->damage, wd->damage2, 10 * sc->data[SC_GN_CARTBOOST]->val1);

Edited April 14, 2019 by mina

[mina]

2 hours ago, AndyTheGoblin said:

give me your battle.c and skill.c so i can copy it 

thanks

I have solved~ thx your help!

https://github.com/rathena/rathena/blob/master/src/map/battle.cpp

https://github.com/rathena/rathena/blob/master/src/map/skill.cpp