[Gatcha Item Use Gold coin and TCG !]

https://github.com/Atemo/scripts_customs/blob/master/olds_scripts/gatcha.txt

[script:implode: array length = 0 Gatcha Script]

Try the updated script https://github.com/Atemo/scripts_customs/blob/master/olds_scripts/gatcha.txt

[4CrAM - Open]

Some new animation skills are pretty well done.

Thanks you for sharing your hard work

[quest_db.yml Location setting doesn't work]

The functionality mob + location is currently not implemented on rAthena (maybe later?)

Currently supported:

 - Id: 22000
   Title: Fishy affair
   Targets:
     - Mob: VADON
       Count: 45

 - Id: 22000
   Title: Fishy affair
   Targets:
     - Id: 1
       Location: iz_dun01
       MapName: Undersea Tunnel B2

Requires an update :

 - Id: 22000
   Title: Fishy affair
   Targets:
     - Mob: VADON
       Count: 45
       Location: iz_dun01
       MapName: Undersea Tunnel B2

To do that find in quest.cpp

			if (qi->objectives[j]->mob_id == md->mob_id)
				objective_check = 6;
			else if (qi->objectives[j]->mob_id == 0) {

and replace the 3 lines by

			if (qi->objectives[j]->mob_id == md->mob_id) {
				objective_check = 5;
				if (qi->objectives[j]->mapid < 0 || (qi->objectives[j]->mapid == sd->bl.m && md->spawn != nullptr))
					objective_check++;
				else if (qi->objectives[j]->mapid >= 0) {
					struct map_data *mapdata = map_getmapdata(sd->bl.m);

					if (mapdata->instance_id && mapdata->instance_src_map == qi->objectives[j]->mapid)
						objective_check++;
				}
			}
			else if (qi->objectives[j]->mob_id == 0) {

(untested)

[Making @iteminfo2/@ii2 clickable]

You need, for example,

 

[The variable 'deleted' is being used without being initialized.]

This isssue has been fixed by Lemongrass in https://github.com/rathena/rathena/commit/1deb5a5f3e3dbb716b2ef9fe43e4c79df3518063

[item_group_db fail]

Maybe there is a mistake in your group name ?

item_group_db_.yml

  - Group: MyItemGroup
    Contain:

the name in const.yml must be

IG_MyItemGroup

because 'IG_' is appended to the name when the file is read.

 

[Why mob_item_ratio.yml are limited]

Ratio is a number between 0 and 10000, it can't exceed 10000 like in conf/battle/drops.txt

0 to remove the item

1 for 0.01%

10000 for 100% (in theory)

[Custom Branch group new rathena]

To add a custom monster summon branch, the steps are:

1.  Add MOBG_G_D_Branch_01 before MOBG_MAX in https://github.com/rathena/rathena/blob/2f311bd1ef6abf0de642f93690eb37bebbb34d14/src/map/mob.hpp#L116
2.  Add MOBG_G_D_Branch_01 after export_constant(MOBG_TAEKWON_MISSION); in https://github.com/rathena/rathena/blob/2f311bd1ef6abf0de642f93690eb37bebbb34d14/src/map/script_constants.hpp#L4625
3. After compiling your server should have created a folder named "import". Add your custom branch data in import/mob_summon.yml

Header:
  Type: MOB_SUMMONABLE_DB
  Version: 1

Body:
  - Group: G_D_Branch_01
    Default: MAYA
    Summon:
      - Mob: MAYA
        Rate: 100000
      - Mob: DEVILING
        Rate: 700000
      - Mob: Drake
        Rate: 700000

      4. In import/item_db.yml

  - Id: ****
    AegisName: name
    Name: name
    Type: Usable
    Buy: 10000
    Weight: 200
    Flags:
      BuyingStore: true
      DeadBranch: true
    Script: |
      monster "this",-1,-1,"--ja--",-1-MOBG_G_D_Branch_01,1,"";

 

All other steps are unnecessary (I think you just forgot to compile according to the error in your first post).

[Ask about skill_db.yml]

#     ItemCost:               Item required to cast. (Default: 0)
#       - Item                Item name.
#         Amount              Item amount.

How come you came to think that the file could support this when it's not in the documentation 

hmm.............

[Quick way to disabled npc include the duplicate]

How about https://github.com/rathena/rathena/blob/c5cf2f6e42b1cb88d501e0b3e7c56e870b928209/doc/script_commands.txt#L6567

*unloadnpc "<NPC object name>";

This command will fully unload a NPC object and all of it's duplicates.

 

[How works AG_CHATTING and AG_SPEND_ZENY from Achievement System]

AG_CHATTING is not supported yet.

See the pull request https://github.com/rathena/rathena/pull/4446 for an initial implementation.

[reflect damage how to reduce]

https://github.com/rathena/rathena/commit/d4d8130bcf0733d4d9edc4019db02184912c13c0

[Conversion of Item Database to YAML]

Your old file have mistakes, your items should be type armor instead of weapon (4 instead of 5), or if they are supposed to be weapon type, the 'viewid' of the weapon must be defined source side.

[Conversion of Item Database to YAML]

^ The tool to convert txt to yml (csv2yaml) can convert your import/item_db.txt as well. Compile the tool, run it !

[item_db.txt convert to YAML]

The 'SubType' (or viewid) 1100 for weapon doesn't exist. Replace the item type 5 (weapon) by type 4 (armor).

30001,Akatsuki_Hat,Akatsuki_Hat,4,10000...

 

[reset quest at spesific time]

The quest system already handle the timer. For example

  - Id: 9998
    Title: "Memorial Dungeon: Champion"
    TimeLimit: 4h
  - Id: 9999
    Title: "Memorial Dungeon: Champion"
    TimeLimit: +4h

9998 is reset at every 4:00, 9999 is reset 4h after the quest is given.

The issue of the topic owner was because he made some mistakes in the NPC script, the conditions on the timers were always false so the player could always recreate the instance.

Sample of correction

switch( checkquest(9998,PLAYTIME) ) {
case -1:
	break;
case 0:
case 1:
	mes "^ff0000Memorial Dungeon cannot be reentered within 8 hours after your last entrance.^000000";
	mes "Reset Every 04:00 AM";
	close;
case 2:
	erasequest 9998;// Memorial Dungeon: Champion
	break;
}
switch( checkquest(9999,PLAYTIME) ) {
case -1:
	break;
case 0:
case 1:
	mes "^ff0000Memorial Dungeon cannot be reentered within 8 hours after your last entrance.^000000";
	mes "Reset Every 04:00 AM";
	close;
case 2:
	erasequest 9999;
	break;
}
Create INSTANCE

 

[COSTUME_ACCESSORY item_DB.YML]

https://github.com/rathena/rathena/blob/master/doc/item_db.txt#L186

[R> Specific Global Item drop]

There is getunitdata to retrieve x y for monster. Sample untested :

-	script	CustomDrop	FAKE_NPC,{
function add_drop;

OnNPCKillEvent:
	if (!playerattached())
		end;
	.@mob_id = killedrid;
	.@size = getd(".size_" + .@mob_id);
	if (.@size < 1)
		end;
	getunitdata killedgid, .@v;
	.@x = .@v[UMOB_X];
	.@y = .@v[UMOB_Y];
	.@map$ = strcharinfo(3);

	for (.@i = 0; .@i < .@size; .@i++) {
		.@chance = getd(".chance_" + .@mob_id + "[" + .@i + "]");
		if (rand(10000) < .@chance) {
			.@id = getd(".item_id_" + .@mob_id + "[" + .@i + "]");
			.@amt = getd(".item_amount_" + .@mob_id + "[" + .@i + "]");
			while (.@amt > 0) {
				makeitem .@id, 1, .@map$, .@x, .@y;
				.@amt--;
			}
		}
	}
	end;
	
OnInit:
	// <mob_id>, <item_id>, <item_amount>, <chance>
	// Chance ========================
	// 10000 	= 100%
	// 1000		= 10%
	// 100		= 1%
	// 99		= 0.99%
	// 50		= 0.50%
	// 1		= 0.01%
	// ===============================
	add_drop( 1002, 607, 2, 10000 );	// poring will drop 2 ygg berries on the floor with 100% chance
	add_drop( 1002, 608, 3, 10000 ); // poring will drop 3 ygg seeds on the floor with 100% chance
	end;

function add_drop {
	.@arg_count = getargcount();
	if (.@arg_count % 4)
		return;

	for (.@i = 0; .@i < .@arg_count; .@i += 4) {
		.@mob_id = getarg(.@i);
		.@size = getd(".size_" + .@mob_id);
		setd ".item_id_" + .@mob_id + "[" + .@size + "]", getarg(.@i+1);	// <item_id>
		setd ".item_amount_" + .@mob_id + "[" + .@size + "]", getarg(.@i+2);	// <item_amount>
		setd ".chance_" + .@mob_id + "[" + .@size + "]", getarg(.@i+3);	// <chance>
		setd ".size_" + .@mob_id, .@size + 1;
	}
	return;
}
}

 

[outdated Muscle Fool script?]

1 hour ago, AyenPanda said:

i just thought that it was followed according to kRO

When did I say the opposite ?

The item script is just probably outdated.

Also note that RMS is not reliable, as we said it again and again on the forum.

[outdated Muscle Fool script?]

It's true that Muscle Fool item script has been changed several times. I don't follow all the kRO patch so I prefer to stick with our current data file which gives +1000 Def for now.

[GM ID wont bypass mapflag noskill and nowarp]

Change skill_unconditional to true

https://github.com/rathena/rathena/blob/0e42b738c59be3330395e8c79c51500d534fcf55/conf/groups.conf#L290

[Instance Problem]

A pull request is currently ongoing to fix the issue https://github.com/rathena/rathena/pull/4945

[Convert custom quest_db.txt in .yml format]

Run the tool in tool/csv2yaml to convert your txt to yml

[cell walkable with hidden npc in it]

Well there is no setting like Akkarin said, but this change in map.cpp should allow you to walk on cell where the npcs are hidden/disabled/invisible (untested)

@@ -553,6 +553,11 @@ int map_count_oncell(int16 m, int16 x, int16 y, int type, int flag)
 	if (type&~BL_MOB)
 		for( bl = mapdata->block[bx+by*mapdata->bxs] ; bl != NULL ; bl = bl->next )
 			if(bl->x == x && bl->y == y && bl->type&type) {
+				if (bl->type == BL_NPC) {
+					struct npc_data *nd = (struct npc_data *)bl;
+					if (nd && (nd->sc.option&(OPTION_INVISIBLE|OPTION_HIDE) || nd->class_ == JT_FAKENPC || nd->class_ == JT_HIDDEN_WARP_NPC))
+						continue;
+				}
 				if(flag&1) {
 					struct unit_data *ud = unit_bl2ud(bl);
 					if(!ud || ud->walktimer == INVALID_TIMER)