Jump to content

CMake does not work.

closed

Zigara
2014-09-09 03:29:56
CMake builds are broken as of commit https://github.com/rathena/rathena/commit/2d2991a1fdf0e681317a0313c03a6e68b8e23a12
user@host:~/rathena/build$ cmake -G"Unix Makefiles" -DINSTALL_TO_SOURCE=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
-- The C compiler identification is GNU 4.8.2
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
[...]
-- Configuring done
CMake Error at src/char/CMakeLists.txt:56 (add_executable):
  Cannot find source file:

    //char.h

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx




I checked the latest commits and reverted to 3c24f458ce (just before the commit I linked above) and it built perfectly.

It appears if this 'TXT cleanup' was not fully tested before being committed, or perhaps my version of cmake (2.8.12.2) is too old?

(PS: This is was to test JetBrains's new multi-platform C/C++ IDE http://www.jetbrains.com/clion/ - it uses the CMake system and seems like a perfect match for rAthena)

Lighta
2014-09-09 04:15:26
Thanks for the repport and forthe suggestion, I'll try Clion tomorrow that could be interesting IDE.
About the commit it's my fault, it was fully tested and working but I failed to merge a little thing for Aleos, conducting this little typo.
Need to change :
set( SERVER_CHAR_SOURCE_DIR CACHE INTERNAL "" )
to
set( SERVER_CHAR_SOURCE_DIR CACHE INTERNAL "" )

And you'll be fine =)

Zigara
2014-09-09 04:28:00
I checked out master and applied your change and it's working perfectly.

It's even compiling/running/debugging perfectly via CLion. I've only done some basic debugging (setting breakpoints and stepping through) but it's worked quite well so far.

Here is a preview of it running on Linux: http://i.imgur.com/k4y2thY.png

Thank you!

Lighta
2014-09-11 06:13:10
should be fixed in 82bb9b1f2f9ac86519c3d2cfea9636ed896c8c11
×
×
  • Create New...