MVP base experience calculation error | closed | |
| rayn 2014-07-13 15:56:35 | At 10x base exp, Base level 160 (no exp penalty/bonus) Mob ID 2240 1X base experience: 4,226,036 Mob ID 2240 10X base experience: 42,260,360 Correct Base level 135 (no exp penalty/bonus) Mob ID 1719 1X base experience: 4,320,000 Mob ID 1719 10X base experience: 250,327 Incorrect - should be: 43,200,000 At 20x base exp, Base level 141 (no exp penalty/bonus) Mob ID 1751 1X base experience: 2,000,000 Mob ID 1751 20X base experience: 40,000,000 Correct Base level 139 (no exp penalty/bonus) Mob ID 1768 1X base experience: 2,160,000 Mob ID 1768 20X base experience: 250,327 Incorrect - should be: 43,200,000 The EXP overflow happens when EXP is greater than 2^32 / 100 (42,949,672). This issue only affects base exp, not job exp or most valuable player experience. Tested on latest GIT, Renewal settings. | |
| leke 2014-07-14 05:31:13 | this already happens for long time. not only does the overflow affects EXP, if you set too much luck your attack damage and drop rate also rewinds itself. uint64_t / __uint64 is surely a luxury | |
| rayn 2014-07-14 15:28:44 | So, this doesn't happen on 64-bit installations? It would make sense to me to use the same calculation method for job experience and most valuable player experience, as these do not experience this issue (or at least not at 2^32/100). | |
| leke 2014-07-14 16:50:10 | no, I meant data type (64-bit integer) in the source code, not 64-bit system where it is installed | |
| Dragonis1701 2014-07-14 16:56:08 | It has nothing to do with experience overflow. If I recall from testing, it has everything to do with your base level. 141+ are completely unaffected where as > 140 and below get the penalty. Already reported but the server I was playing when I reported it suddenly went offline and never came back. Now that I think about it: wasn't this actually based on party, if I recall? If you were in a party, you didn't get this weird experience bug but if you weren't, you were losing experience. Page: http://rathena.org/board/tracker/issue-8604-mvp-experience-penalty/ | |
| rayn 2014-07-15 01:10:41 | [quote name="Dragonis1701" post="27541" timestamp="1405356968"] It has nothing to do with experience overflow. If I recall from testing, it has everything to do with your base level. 141+ are completely unaffected where as > 140 and below get the penalty. Already reported but the server I was playing when I reported it suddenly went offline and never came back.Now that I think about it: wasn't this actually based on party, if I recall? If you were in a party, you didn't get this weird experience bug but if you weren't, you were losing experience.Page: http://rathena.org/board/tracker/issue-8604-mvp-experience-penalty/[/quote] These are two separate bugs. MVP experience level penalty bug is real, but unrelated. This experience overflow bug affects all levels. This is why in my testing, my test character is the same level as the MVP so that there is no level exp penalty. | |
| Cydh 2014-07-15 03:45:28 | let's see. I've run high-rate server, and didn't notice overflow calculation. | |
| rayn 2014-07-15 12:24:30 | [quote name="Cydh" post="27553" timestamp="1405395928"] let's see. I've run high-rate server, and didn't notice overflow calculation.[/quote] I've tested this on 2 different revisions (latest, and early June) on two separate systems (one VPS, one dedicated hardware), and both experience the same issue. /? While investigating this, I've also spoken with a few other server owners who said they've noticed this issue too. Cydh, can you let me know what your rates are so that I can run some test? | |
| Cydh 2014-07-16 10:25:54 | Because I said I didn't notice, doesn't mean the bug doesn't appear. haha. The fact, yeah, I got that issue. Try, should be fixed here 171e2f2 | |
