EDP + Cross Impact | closed | |
| mofo 2012-08-19 17:32:20 | Updated to r16667, now EDP boosts damage of cross impact, sonic blow, soul breaker, etc. Was this change intentional? TIA | |
| VodkaMartini 2012-08-19 19:26:15 | confirmed on Cross Ripped Slasher, Magnum Break, Meteor Assault and Phantom Menace Skill. (r16666) Attachment shows Magnum Break + EDP. w/o EDP damage = ~< 2k | |
| mofo 2012-08-20 03:06:13 | it's actually worse now because it raises ATK prior to boosting final damage by 400%. I'l try to get screenshots later. i made sure i had renewal.h set to renewal edp. | |
| Poseid0n 2012-08-24 23:27:28 | I confirm this bug. EDP do too much damage. It one shoot all players. Do you can, please, fix it ? | |
| zamorasantos 2012-09-07 02:08:46 | yes its a bug | |
| kyeme 2012-09-07 03:28:29 | Yeah too much damage  .. i disabled Renewal EDP on my server | |
| Tepoo 2012-09-08 09:08:14 | Tested on official Server. Cross Impact doesnt increase the dmg when edp is activated. | |
| RyokoMVP 2012-09-08 10:00:32 | but here edp give 400% final atk lol...i already posting about this before...but they dont care... | |
| Euphy 2012-09-09 19:29:34 | Is anyone working on this? This is a major issue on Renewal servers... | |
| kyeme 2012-09-09 19:50:03 | Thank you for confirming this.  | |
| GM Takumirai 2012-09-09 22:22:05 | I dont know if this is the correct fix http://rathena.org/board/topic/69340-reduce-damage-normal-attack-use-edp/page__p__135694#entry135694 | |
| malufett 2012-09-10 04:06:33 | [quote]Is anyone working on this? This is a major issue on Renewal servers...[/quote] ok let me do it..I'll do a remedy even though renewal atk is not yet fully implemented..  | |
| Angezerus 2012-09-10 09:23:12 | I don't mean to push anyone, but why does nobody start that renewal atk implementation? It's a problem since 3-4 months, I already posted formulas and links about the problem, but noone does anything. This should be the first thing... There's no point in fixing skills all the time if the base attack is wrong. This edp thingie is starting to really piss me off. There's about 10 to 20 reports about this. Please do something, or revert to the old 400% atk. Anything would be better! But theres a problem with the skill as well: Currently we increase the weapon atk and base atk as well (as intended), but in the meantime we increase the final attack by 400% (as it was done in the old formula). THIS is the problem wit the skill.... This is a duplicate bonus. Pz make the 400% bonus only pre re. Of course the renewal formula needs renewal attack, but as you see it's an error in the skill as well not only the missing re atk... Here's the source: Renewal bonus part: [CODE] #ifdef RENEWAL_EDP // renewal EDP increases your weapon atk by watk x Skill Level - 1 if( sc->data[SC_EDP] && sc->data[SC_EDP]->val1 > 1 ) watk = watk * (sc->data[SC_EDP]->val1 - 1); [/CODE] This applies to renewal as well, making the bonus extremely OP [CODE] case SC_EDP: // [Celest] val2 = val1 + 2; //Chance to Poison enemies. val3 = 50*(val1+1); //Damage increase (+50 +50*lv%) <<<< SHOULD BE ONLY PRE RE [/CODE] | |
| malufett 2012-09-10 16:36:33 | this should be the fixed [rev='16770'].. however due to the current atk formula damage is still quite huge...but not that big as before... I don't know If I should flag all reports as fixed...anyway bug me if its ok to change all to fixed... | |
| Angezerus 2012-09-10 17:32:31 | Thanks a lot :3 | |
| kyeme 2012-09-10 18:42:08 | Thanks for d fixed . May I ask something? My normal attack is = 60k and my Cross Impact = 109K is this normal? or there was something wrong about bDefRatioAtkRace (Pierce Defense) ? Im using Super Latest Revision. Here's my Screenshot Screenshot 1: Sura with Angelus and Revitalize Alive Total Def = 433 + 5 and Cranial Shield. And Venon Impression [attachment=3487:1.JPG] Screenshot 2: Equipment of GX = Ice Pick with Turtle General Card [attachment=3486:2.JPG] Screenshot 3: Normal Attack of GX = 60k [attachment=3488:3.JPG] Screenshot 4: Cross Impact of GX = 109k each [attachment=3489:4.JPG] | |
| malufett 2012-09-11 02:12:18 | @kyeme its normal in our current formula..but its not normal as we can see.. anyway this is how it makes the damage still huge.. are current formula or the PRE flows [quote]Base Damage->Skill Modifiers->Damage Reduction->Masteries->Elemental->Card Bonuses[/quote] therefor the '[color=#282828] bDefRatioAtkRace' bonus is amplified(suppose to be wrong) where it should be added as fixed damage.. [/color] [color=#282828] [/color] | |
| donkeyg 2012-11-17 03:26:45 | any solution on this? | |
| donkeyg 2012-11-17 03:29:06 | this was happened in my server. 150 max level. and no god item at all but they still able to cross impact 99999999999 dmg on every MVP.... and i don think even if i got MG/ mjolnir can deal such a over damage [attachment=4475:screenPassion-RO011.jpg] [attachment=4476:screenPassion-RO008.jpg] [attachment=4477:screenPassion-RO009.jpg] | |
| donkeyg 2012-11-19 13:33:55 | bump! | |
| GM Takumirai 2012-11-20 09:56:56 | any further solution | |
| donkeyg 2012-11-21 13:17:53 | Please do some action on this EDP and CROSS IMPACT. | |
| donkeyg 2012-11-23 13:29:06 | hey... why no respond from rathena development.. i suffer about this problem so long | |
| GM Takumirai 2012-11-23 14:51:48 | @donkey suggest to patch the manage skill damage v.2 by Lilith - im hoping that patch will be put in our svn so that we can easily manage the skills if we see an imbalance to the server since some skills are not yet fix totally , while waiting we can manage the skill damage by using the patch by Lilith .. | |
| donkeyg 2012-11-24 13:24:55 | [quote name='GM Takumirai' timestamp='1353682308' post='15847'] @donkey suggest to patch the manage skill damage v.2 by Lilith- im hoping that patch will be put in our svn so that we can easily manage the skills if we see an imbalance to the server since some skills are not yet fix totally , while waiting we can manage the skill damage by using the patch by Lilith .. [/quote] where can i find the patch by lilith's 1? ^^ | |
| GM Takumirai 2012-11-24 14:29:44 | http://rathena.org/board/topic/62238-manage-skill-damage-20/ | |
| donkeyg 2012-11-26 03:35:41 | [quote name='GM Takumirai' timestamp='1353767384' post='15878'] http://rathena.org/b...kill-damage-20/ [/quote] not really know how to use it.. just copy and paste? haha! btw, why kro is so slow to fix this skill? | |
| Euphy 2012-11-26 04:56:09 | Please keep unrelated discussion out of the bug tracker. That's what the support forums are for. ._. | |
| GM Takumirai 2012-11-26 05:49:11 | as Euphy said we must not discuss unrelated issue in here, anyway answer to your question is that its not kRO that it make it unfixable, we have developers now starting the fix of this issue.. so wait for them and support them for there time to fix it.. | |
| Angezerus 2012-11-27 11:54:11 | Since this is more of a renewal attack issue, there is no need to modify the skills. Their formula is okay. The only problem is the missing eAtk/ wAtk separation and the missing renewal pierceing calculation. | |
| donkeyg 2012-11-28 04:28:36 | [quote name='GM Takumirai' timestamp='1353908951' post='15909'] as Euphy said we must not discuss unrelated issue in here, anyway answer to your question is that its not kRO that it make it unfixable, we have developers now starting the fix of this issue.. so wait for them and support them for there time to fix it.. [/quote] Glad to heard that! hope the rathena Team will fix it as fast as possible ^^ | |
| arun89 2012-11-28 16:21:48 | still waiting for a solution to this... patiently waiting ^^ | |
| donkeyg 2012-11-30 04:57:34 | Bumppppp this thread and still havent been fix since august 20? | |
| Angezerus 2012-11-30 10:23:36 | [quote name='donkeyg' timestamp='1354251454' post='16031'] Bumppppp this thread and still havent been fix since august 20? [/quote] Some are not fixed since May. Be patient pz. As many ppl mentioned: these issues are related to Renewal Atk. There's no point in teporally nerfing the skill, because attack is the one that needs to be fixed. Only then can the skill formula be altered. Till then use pre renewal edp settings if neccessary. | |
| powerboots 2012-12-01 01:16:00 | or you could use the same formula as maximum_overthrust which only boost 200% on physical attacks (make it 400% on edp) | |
| Angezerus 2012-12-01 12:40:06 | [quote name='powerboots' timestamp='1354324560' post='16061'] or you could use the same formula as maximum_overthrust which only boost 200% on physical attacks (make it 400% on edp) [/quote] The problem is that EDP increases eAtk by 4 and wAtk by 5 times, but eAtk is not implemented, so once again, this needs Renewal Attack. Using other skill's formulas would make it even worse and only delay the main problem | |
| donkeyg 2012-12-03 12:54:02 | O.o .. but im still prefer waiting for the rathena team's solution xD | |
| powerboots 2012-12-04 02:02:46 | here's a fix i made my own battle.c line 3000 [quote] if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break; [/quote] grimtooth shouldn't be there. as we know grimtooth doesnt increase damage on edp skill battle.c line 3015 [quote]ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus[/quote] this part is totally wrong, atk_rate(50) means it\ll boost attack by 50%. the real damage suppose to be half which means [quote]ATK_RATE(-50); // only modifier is halved but still benefit with the damage bonus[/quote] as for some people who wants final damage added +400%, insert this script at line 2041 [quote] if (sc->data[SC_EDP]) skillratio += sc->data[SC_EDP]->val2;[/quote] some of it might be wrong, so if anyone can check & confirm this? anyway.. GC_CROSSRIPPERSLASHER should be added somewhere, which reduce it's attack (either does not boost or half modifier) | |
| Golem1988 2012-12-05 05:14:07 | [quote name='powerboots' timestamp='1354586566' post='16154'] here's a fix i made my ownbattle.c line 3000[quote] if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break;[/quote] [/quote] nice try man, but this code disables grimtooth on edp  | |
| powerboots 2012-12-05 21:10:13 | [quote name='Golem1988' timestamp='1354684447' post='16162'] [quote name='powerboots' timestamp='1354586566' post='16154']here's a fix i made my ownbattle.c line 3000[quote] if (sc->data[SC_EDP]) { switch (skill_num) { case AS_SPLASHER: case AS_VENOMKNIFE: case AS_GRIMTOOTH: break;[/quote][/quote] nice try man, but this code disables grimtooth on edp [/quote] well.. thanks for telling it out (sorry i'm still quite new to this stuffs so there are lots of parts where i don't understand at all.) the only solution did i placed is that i added grimtooth to the half damage modifier because grimtooth had no delay and is crazy high damage as for other attacks modifier, i've learn it out of coincidence (when i nerf thanatos, and boost maxoverthrust) | |
| Golem1988 2012-12-08 17:33:39 | [quote]ok let me do it..I'll do a remedy even though renewal atk is not yet fully implemented..[/quote] <c> Malufett Okay... this is the quote from 10th of september. How many time has passed? Lemme tell you: 4 months = No result. This question was posted even earlyer. As I see the point were to tell people "we are working on it, relax" and let all the things as they were? I don't really believe that atk formulas are so hard to write if you really do it. Bump, wanna hear about some changes or wanna hear what problems developers met doing this thing real. I mean doing normal atk formula real. Bump, bump, bump. This formula ruines all tre emulator btw, people are leaving servers becaue of horrible formula, so I request some changelog from developement side. Thanks. I still believe rA isn't dead... | |
| arun89 2012-12-22 03:26:39 | still no solution? i might have gotten the 'avoid spamming' reply, but nevertheless, bump again. i am not spamming, just urging for a quick solution to this matter. | |
| donkeyg 2012-12-22 07:09:43 | +1 for u arun89 | |
| arun89 2013-01-17 03:22:53 | bump..... | |
| Alayne 2013-01-17 16:02:30 | Actually, I don't if I'm right, but if you look in status.c, line 4611, there's something like that: [CODE] if( sc->data[SC_EDP] ) watk = watk * (100 + sc->data[SC_EDP]->val1 * 80) / 100; [/CODE] If you now look in irowiki, it says: [quote]EDP level 5 will multiply your weapon atk by 5 times, and your equipment atk by 4 times.[/quote] Let us make a quick calculation: knowing that edp val1 is 50, suppose you have a weapon of 250 atk, you obtain a watk equal to 35000 instead of the 1250 it was supposed to be. Knowing that this calculation is the base for skillratio, I changed this formula to watk = watk*5. The damage look fair know, but I'm really not sure this is the right solution. | |
| KyleZ 2013-01-17 18:11:45 | [quote name='Alayne' timestamp='1358438550' post='17341'] Actually, I don't if I'm right, but if you look in status.c, line 4611, there's something like that:[CODE]if( sc->data[SC_EDP] ) watk = watk * (100 + sc->data[SC_EDP]->val1 * 80) / 100;[/CODE]If you now look in irowiki, it says:[quote]EDP level 5 will multiply your weapon atk by 5 times, and your equipment atk by 4 times.[/quote]Let us make a quick calculation:knowing that edp val1 is 50, suppose you have a weapon of 250 atk, you obtain a watk equal to 35000 instead of the 1250 it was supposed to be.Knowing that this calculation is the base for skillratio, I changed this formula to watk = watk*5. The damage look fair know, but I'm really not sure this is the right solution. [/quote] where did you get that... val1 equals to skill lvl, which is 5. for max lvl 5 watk=watk*(100+5*80)/100=watk*5, it's OK. the problem is here, i'm afraid [CODE] #ifdef RENEWAL_EDP if( sd->sc.data[SC_EDP] ){ cardfix = cardfix * (100 + sd->sc.data[SC_EDP]->val1 * 60 ) / 100; cardfix_ = cardfix_ * (100 + sd->sc.data[SC_EDP]->val1 * 60 ) / 100; [/CODE] EDP already boosts watk, it should not exist here in cardfix part. | |
| Alayne 2013-01-18 08:10:40 | If that's right, all my apologies. I've found a comment (dun remember where and I can't succeed in finding it again) telling that val1 was 50. Therefor, I don't understand why this modification make the skills works almost how it should ?? maybe something else I've changed... | |
| Antares 2013-01-18 12:59:10 | [quote name='KyleZ' timestamp='1358446305' post='17342'] [quote name='Alayne' timestamp='1358438550' post='17341']Actually, I don't if I'm right, but if you look in status.c, line 4611, there's something like that:[CODE]if( sc->data[SC_EDP] ) watk = watk * (100 + sc->data[SC_EDP]->val1 * 80) / 100;[/CODE]If you now look in irowiki, it says:[quote]EDP level 5 will multiply your weapon atk by 5 times, and your equipment atk by 4 times.[/quote]Let us make a quick calculation:knowing that edp val1 is 50, suppose you have a weapon of 250 atk, you obtain a watk equal to 35000 instead of the 1250 it was supposed to be.Knowing that this calculation is the base for skillratio, I changed this formula to watk = watk*5. The damage look fair know, but I'm really not sure this is the right solution.[/quote] where did you get that...val1 equals to skill lvl, which is 5.for max lvl 5watk=watk*(100+5*80)/100=watk*5, it's OK.the problem is here, i'm afraid[CODE]#ifdef RENEWAL_EDP if( sd->sc.data[SC_EDP] ){ cardfix = cardfix * (100 + sd->sc.data[SC_EDP]->val1 * 60 ) / 100; cardfix_ = cardfix_ * (100 + sd->sc.data[SC_EDP]->val1 * 60 ) / 100;[/CODE]EDP already boosts watk, it should not exist here in cardfix part. [/quote] Edp boosts watk*5 and eatk*4. Cards give eatk, so it's intentional (tho it should be checked that these are only +atk bonuses and not % ones. If this increases % bonuses that would explain a lot  ). The main problem is that renewal attack is not implemented, and there is no official eatk, instead we use batk and eatk together. Maybe there are some other issues other than these, but again, the top priority is RE ATK. Without it, any atk skill bug cannot be fixed, because it has to be reworked again when RE ATK becomes live. | |
| KyleZ 2013-01-18 13:24:03 | feel the same way about re-ATK. malufett has been doing it, last time i heard. just don't know how far he has achieved. as for EDP effect on eatk, see dmg flow: [CODE] Base Damage->Skill Modifiers->Damage Reduction->Masteries->Elemental->Card Bonuses [/CODE] EDP quadruples everything, instead of eatk(again requires re-atk to implement first ) if only i had kRO account, so I could do sth. to help malufett~ bitter reality is, I can only sit on my ass and wait BTW, things could get worse, when EDP meets long range weapon. I don't know what you call it in native English, my translation is "reverse phenomenon". A mechanism from pre RE(and exists in pre ONLY, again again requires re ATK ), when watk exceeds 100(for long range weapon), calculation changes. [CODE]say DEX=200, watk=300, Lv4 weapon, lv5 EDP Actual watk=1.6x200x300x5/100=4800 4800/(300x5)~3 times don't forget the cardfix part, together make final dmg roughly 12 times higher than it should be.[/CODE] | |
| Cyrix 2013-01-30 19:15:47 | ? | |
| jTynne 2013-03-16 06:58:28 | Why has this NOT been fixed yet? "Confirmed" and "High" Severity for literally months. | |
| Playtester 2013-03-16 10:55:42 | Hum, what is still open here? That EDP affect damage of Cross Impact, Sonic Blow and Soul Breaker in renewal is correct. They have their damage increased by half of the normal value, this is already in. So the open issue is that it should not boost final damage by 400% in renewal? | |
| Lighta 2013-03-16 18:26:44 | Only adding watk and eatk bonus then ? | |
| Playtester 2013-03-16 23:05:27 | I think the bonus is already in correctly. It's more like the general "renewal attack is not implemented yet". | |
| exneval 2013-03-17 00:28:07 | yes, this issue have been fixed, but still no match with official because of re-ATK isn't implemented | |
| Playtester 2013-03-17 09:58:04 | Ok then I'll set this to fixed, renewal atk is another topic altogether. | |
