Jump to content

Qura

Members
  • Posts

    21
  • Joined

  • Last visited

Posts posted by Qura

  1. Hi rAthena'ian,

     

    I have an issue here, I did some searching regarding Incorrect use of 'close' command. Such:

     

    1. https://rathena.org/board/topic/84807-how-to-fix-this-2-errors/

    2. https://rathena.org/board/topic/87264-warper-healer-got-problem/

    3. https://rathena.org/board/tracker/issue-7592-warning-incorrect-use-of-close-command/

    4. https://rathena.org/board/topic/87264-warper-healer-got-problem/

     

    But, none from Gold Room. I believe this gold room script among the unique one, because who enter that gold room, are being notified about how much Gold they got.

     

    Even I used several lots of script regarding Gold Room.txt, and most of them, encountering this "close" command.

     

    My sample GoldRoom.txt:

    
    ordeal_1-2.gat	mapflag	nomemo
    ordeal_1-2.gat	mapflag	nobranch
    ordeal_1-2.gat	mapflag	noexp
    ordeal_1-2.gat	mapflag	nodrop
    ordeal_1-2.gat	mapflag	nochat
    ordeal_1-2.gat	mapflag	novending
    ordeal_1-2.gat	mapflag	nowarpto
    ordeal_1-2.gat	mapflag	noreturn
    ordeal_1-2.gat	mapflag	nosave
    //==================================================
    //Optional
    //==================================================
    //ordeal_1-2.gat	mapflag	noloot 
    //disable so that after logging in your still in the Gold Room..
    //ordeal_1-2.gat	mapflag	nosave	SavePoint
    
    ordeal_1-2,0,0,0	script	Gold Room	-1,{
    
    OnPCDieEvent: 
    
    if (getmapxy(@mapname$,@mapx,@mapy,0) == -1) goto L_Finish;
    if (@mapname$ == "ordeal_1-2"){
    		dispbottom "Holy Shit you died!";
    		dispbottom "All of your gold will gone!";
    		set alive, 0;
    		set paid, 0;
    		set @gold,0;
    		end;
    }
    
    L_Finish:
    close;
    
    OnNPCKillEvent:
    if (getmapxy(@mapname$,@mapx,@mapy,0) == -1) goto L_Finish;
    if (@mapname$ == "ordeal_1-2"){
    	
    	set @gold,@gold+1;
    		
    	dispbottom "-|You got: 1 gold| - |Total: " +@gold+ " gold|-";
    	getitem 969,1;
    	
    	if (gold >= 115 && gold <= 149){
    		 sc_start	33,240000,10;
    	}else if (gold >= 150 && gold <= 199){
    		 sc_start	5,240000,10;
    	}else if(gold > 200){
    		 percentheal -30,0;
    		 heal -50,0;
    	}
    	if(paid == 0){
    		mapannounce "ordeal_1-2"," :"+strcharinfo(0)+" is a cheater!",bc_map;
    		dispbottom "Go out you bastard!";
    		warp "prontera", 173, 160;
    	}
    		end;
    L_HolyShit:
    		dispbottom "Warning! you may die if you exceed.";
    		misceffect 368;
    		end;
    
    	end;
    }
    
    }
    
    //===============================================
    //warper
    //===============================================
    ordeal_1-2,154,156,5	script	Gold Miner	813,{
    	mes "[Gold Miner]";
    	mes "Want to go now?";
    	mes "Your gold is just "+@gold+" you can still get more.";
    	next;
    	goto wa;
    	close2;
    	end;
    wa:
    	mes "Want to go now?";
    	 if(select("Yes", "No") == 1) {
    		set alive,1;
    		set @gold,0;
            		warp "prontera", 170, 155;
        	}
    	close;
    }
    
     prontera,164,167,3	script	Gold Room Warperer#pront	813,{
    	set @name$,"prontera";
    	callfunc "goldmain";
    	end;
    }
    
    aldebaran,133,116,4	script	Gold Room Warperer#alde	813,{
    	set @name$,"aldebaran";
    	callfunc "goldmain";
    	end;
    }
    
    alberta,23,247,4	script	Gold Room Warperer#alb	813,{
    	set @name$,"alberta";
    	callfunc "goldmain";
    	end;
    }
    payon,151,182,4	script	Gold Room Warperer#pay	813,{
    	set @name$,"payon";
    	callfunc "goldmain";
    	end;
    }
    
    geffen,115,74,4	script	Gold Room Warperer#gef	813,{
    	set @name$,"geffen";
    	callfunc "goldmain";
    	end;
    }
    
    
    function	script	goldmain	{
    	if ( alive == 0){
    		set @gold,0;
    	}
    	cutin "fey_fun",2;
    	mes "[Gold Room Warperer]";
    	mes "What do you want?";
    	next;
    	menu "To the Gold Room("+getmapusers("ordeal_1-2")+")",-,"Nothing",C_s;
    	mes "[Gold Room Warperer]";
    	mes "Hmm..";
        	mes "Would you like to go now to the gold room?";
        	if(select("Yes", "No") == 1) {
    		if(@name$ == "prontera") savepoint "prontera",160,180;
    		if(@name$ == "aldebaran") savepoint "aldebaran",166, 163;
    		if(@name$ == "alberta") savepoint "alberta",16, 246;
    		if(@name$ == "payon") savepoint "payon",160, 179;
    		if(@name$ == "geffen") savepoint "geffen",124, 85;
    		set alive, 1;
    		set paid, 1;
    		set @gold,0;
            		warp "ordeal_1-2", 156, 155;
    		
        	}
        	close;
    nomoney:
    	mes "[Gold Room Warperer]";
    	mes "Sorry insufficient balance";
    	close;
    exchange:
    	mes "[Gold Room Warperer]";
    	mes "Hmm...let me see";
    	mes "You have " +@gold+ ".";
    	if (gold == 0) goto nogold; 
    	mes "Ok get this.";
    	next;
            if (checkweight(969,gold) == 0) goto L_OverWeight;
    	getitem 969, gold;
    	set gold, 0;
    	emotion e_gg;
    	close;
    L_OverWeight:
    	mes "[Gold Room Warperer]";
    	mes "Sorry your overweight";
    	close;
    nogold:
    	close;
    C_s:
    	close2;
    	cutin "",255;
    	end;
    }
    
    
    
    
    //========================================
    //warps you may edit this one for your convenience
    //========================================
    ordeal_1-2,73,265,0	warp	ord500	1,1,prontera,173,160
    ordeal_1-2,129,194,0	warp	ord501	1,1,prontera,173,160
    ordeal_1-2,130,194,0	warp	ord502	1,1,prontera,173,160
    ordeal_1-2,178,193,0	warp	ord503	1,1,prontera,173,160
    ordeal_1-2,290,130,0	warp	ord504	1,1,prontera,173,160
    ordeal_1-2,241,281,0	warp	ord505	1,1,prontera,173,160
    ordeal_1-2,66,25,0 	warp	ord506	1,1,prontera,173,160
    ordeal_1-2,290,229,0	warp	ord507	1,1,prontera,173,160
    ordeal_1-2,179,94,0	warp	ord5s08	1,1,prontera,173,160
    //======================================
    //mobs you may edit this as you want but don't change the mobs
    //=====================================
    
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	1078,800,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,100,40000,20000,0
    
    /*
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,10,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,10,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,10,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,10,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,10,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,10,40000,20000,0
    ordeal_1-2,0,0,0,0	monster	Hunt For Gold	2074,20,40000,20000,0
    */
    //======================================
    
    ordeal_1-2	mapflag	noskill
    ordeal_1-2	mapflag	noteleport
    ordeal_1-2	mapflag	novending
    ordeal_1-2	mapflag	noicewall
    ordeal_1-2	mapflag	nopenalty
    ordeal_1-2	mapflag	nobranch
    ordeal_1-2	mapflag	noexp
    

    My issue is, this Incorrect use of 'close' command appeared when a char died outside that "GOLD ROOM" (eg: town, field, dungeon, etc). Or/And, my assumption is, they use @warp or @go command to get out from Gold Room and got killed somewhere (outside Gold Room).

     

    post-37962-0-60929100-1461709857_thumb.jpg

     

    Hence, I'm not a good scripter to realize which close command that causes this error. And I believe most of us who uses any Gold Room (from download section) in their RO, could encounter this error.

     

    Thus, can anyone help us to resolve this issue?

    Your supports are much appreciated.  :meow:

    post-37962-0-60929100-1461709857_thumb.jpg

  2. Do you still have the backup?

     

    right click > tortoise git > stash save // this will save your modifications

    right click > tortoise git > pull            // this will update your git to the latest revision

    right click > tortoise git > stash pop  // this will apply the modifications your saved

     

    sometimes you will encounter conflicts after using stash pop because of the modifications but I used to fix them manually.

    Thank you Technoken for enlightening me! I will try it.

     

     

    Update your source code and recompile your server.

    I've minified some item scripts by replacing ternary operators with min/max calls which are new script commands implemented recently.

    Thank you secretdataz, it's worked after I recompiled it. Thank you for the guidance!

  3. It's been awhile (2-3 weeks) not updating .git rathena server. Suddenly after updating the .git file, I'm experiencing this issues.

    Came from db/re/item_db.txt and db/re/item_combo_db.txt.

     

    post-37962-0-12827800-1460063028_thumb.png
    and
    post-37962-0-59492300-1460063024_thumb.png
     

    First and foremost, will someone please enlighten me?

    Actually, 

     

    1. Is it by updating the .git file (right click>SVN Update) is the appropriate way to update the git? Or is there any other proper way (specific update revision, etc)?

    2. If this issue happens, is there any other way to reverse/recover the previous working .git?

    3. How to solve this issue? Hehe

     

    Apologies me, I'm still in the beginning of learning.

    Thank you for everyone guidance support for all this while.  :meow:

    post-37962-0-59492300-1460063024_thumb.png

    post-37962-0-12827800-1460063028_thumb.png

  4. Yeah, every single changes we did in the "server" files (especially .conf), it is recommended for us to recompile back the server.

     

    So, the error still persist?

    Would you mind to attach your src/char/char_clif.c?

    Before and after edited.

  5. Open your src/char/char_clif.c.

    Search this codes

    //----------------------------------------
    // Tell client how many pages, kRO sends 17 (Yommy)
    //----------------------------------------
    void chclif_charlist_notify( int fd, struct char_session_data* sd ){
    #if PACKETVER >= 20151001
    	WFIFOHEAD(fd, 10);
    	WFIFOW(fd, 0) = 0x9a0;
    	// pages to req / send them all in 1 until mmo_chars_fromsql can split them up
    	WFIFOL(fd, 2) = (sd->char_slots>3)?sd->char_slots/3:1; //int TotalCnt (nb page to load)
    	WFIFOL(fd, 6) = sd->char_slots;
    	WFIFOSET(fd,10);
    #else
    	WFIFOHEAD(fd, 6);
    	WFIFOW(fd, 0) = 0x9a0;
    	// pages to req / send them all in 1 until mmo_chars_fromsql can split them up
    	WFIFOL(fd, 2) = (sd->char_slots>3)?sd->char_slots/3:1; //int TotalCnt (nb page to load)
    	WFIFOSET(fd,6);
    #endif
    }
    

    Then replacing it with these,

    //----------------------------------------
    // Tell client how many pages, kRO sends 17 (Yommy)
    //----------------------------------------
    void chclif_charlist_notify( int fd, struct char_session_data* sd ){
    	WFIFOHEAD(fd, 6);
    	WFIFOW(fd, 0) = 0x9a0;
    	// pages to req / send them all in 1 until mmo_chars_fromsql can split them up
    	WFIFOL(fd, 2) = (sd->char_slots>3)?sd->char_slots/3:1; //int TotalCnt (nb page to load)
    	WFIFOSET(fd,6);
    }
    

    Hope it helps.  :meow:

  6. Does anyone have iRO or fRO client?

     

    I need these files from "book" folder:

     

    11056.txt

    11059.txt

     

    Thanks

     

    I prefer if the item names stayed how people are used to. They need to match with all the online databases out there so players not familiar with the game yet can search for them.

    Yeah sure,

    i will leave it like it should be

     

     

    Here zackdreaver.

    I hope these two would be the right one. I extracted from data.grf of iRO.

     

    Edited:

    Sorry, It was removed. Here, I reupload it again.

     

    Book.rar

  7. Hi cdelorme,

     

    Regarding Black-Background, either compiled [as attached] in your .grf or insert oldizlude.grf in your Data.ini

     

    And regarding that database, you have to update or just extract "item_db.txt" in rAthena github. Might be due to item missing in that line.

    extract from here https://github.com/rathena/rathena/tree/master  or just replace using this provided item_db.txt,

    [location: db\re\item_db.txt]

     

    Make sure to make a copy (backup) before replacing it.

    OldIzlude.grf

    item_db.txt

    • Upvote 1
  8. No problem, happy playing  :meow:

     

    Qura

     

    Our as I forgot about it

    Thank you for your help

    /no1


    Seems, Fire Rain (Rebellion's skill) is unstable in my client server.

     

    I merged the Rebellion sprites and skills into my .grf file.

    When I run the RO by turning off the /effect before casting the skill, seems to work fine (without animation's effect).

     

    After I restarting the RO (with the disabled  /effect earlier), then re-turning on the /effect, suddenly the Fire Rain seems to show its animation skill.

    post-37962-0-70801400-1458522904_thumb.jpg

     

    After that, when I restarting again the RO (with enabled  /effect from the previous setting), seems it crashed again.

    post-37962-0-28069100-1458522901_thumb.png

     

    From this issue, what it is trying to convey?  :ani_swt3:

    Does anyone have any idea how to solve this?

    post-37962-0-28069100-1458522901_thumb.png

    post-37962-0-70801400-1458522904_thumb.jpg

  9. Hi Freyr!

     

    Hows your work progress? Is it working already? The one suggested by Renniw would be working fine.

     

    If you are still facing this issue, might be you try this one.

     

    Open you src/common/utils.c

    And search this line

    	else if(date < 20130807) return 44;
    	else if(date < 20131223) return 45;
    	else if(date < 20140212) return 46;
    	//else if(date < 20140613) return 47;
    	//else if(date < 20141016) return 48;
    	else if(date < 20141022) return 50;
    	else if(date < 20150513) return 51;
    	else if(date < 20150916) return 52;
    	else if(date < 20151001) return 53;
    	else if(date >= 20151029) return 54;
    
    	else return 30; //default
    

    Does this line, have in your src/common/utils.c?

    	else if(date >= 20151029) return 54;
  10. Renniw,

     

     

    Please Use This code.

    it will be fixed your problem.

    //----------------------------------------
    // Tell client how many pages, kRO sends 17 (Yommy)
    //----------------------------------------
    void chclif_charlist_notify( int fd, struct char_session_data* sd ){
    	WFIFOHEAD(fd, 6);
    	WFIFOW(fd, 0) = 0x9a0;
    	// pages to req / send them all in 1 until mmo_chars_fromsql can split them up
    	WFIFOL(fd, 2) = (sd->char_slots>3)?sd->char_slots/3:1; //int TotalCnt (nb page to load)
    	WFIFOSET(fd,6);
    }
    

     

    Haha, thank you. Its worked!

    Having problem with black-background in map iz_int02 (new char spawn point). I'll search the solution somewhere in this rAthena forum.

    Anyway, thank you guys (Lord Ganja, Napster, Renniw) for the help and immediate response! 

  11. Lord Ganja,

     

    Did you used the kRO from nickyzai? I experience client crashing when I used the kro from nickyzai.

     

    After I tried this one. LINK

     

    I didn't encounter crashing anymore.

     

    Ya, If I'm not mistaken, I'm using the one from NickyZai (Full_kRO_Renewal_20160124.exe).
    I'll try the one from Azeroth's post. And I'll infrom the progress.
     
     
    Napster,

     

    you can revert this ?

    https://github.com/rathena/rathena/commit/aea025e

    and test again

     
    Thank you for the respond.
    Actually, I'm using server the one from https://github.com/rathena/rathena. By which having the same coding as in src/char/char_clif.c
     
    post-37962-0-57116000-1458313306_thumb.png

     

    If it still happened, is there any other solution?

    post-37962-0-57116000-1458313306_thumb.png

  12. Hello guys.

     

    I've search many topic regarding this crashed, but it seems none from this new client 2015-10-29aRagexe.

    post-37962-0-58207900-1458289485_thumb.png

    So I decided to make a post regarding this topic.

     

    My char select page is not responding after server selection, when using Client 2015-10-29aRagexe.

    It seems my Server was running well. So I guess, it has something to do with Client side.

     

    Before

     

    After

     

     

     

    Sorry for my noobs questions.

     

    1. Is it because of i'm not updating the right rsu-lite? (I've updated the rsu-RenewalLite)

    Refering to some topics, they said I've to update the rsu-lite. So with my client of 2015-10-29aRagexe, which rsu-lite I've to update?

    Either RagLite or RenewalLite?

    First and foremost, does this error has something coorelated between client Ragexe and rsu?

     
    2. Or it has something to do with the patched?
    I've patched using NEMO. And select these features.
     
    1. @Bug Fix
    2. Always Call SelectKoreaClientInfo()
    3. Cancel to Login Window
    4. Disable 1rag1 type parameters
    5. Disable Game Guard
    6. Disable Help Message on Login
    7. Disable Nagle Algorithm
    8. Disable Ragexe Filename
    9. Enable /showname
    10. Enable /who command
    11. Enable DNS
    12. Enable Multiple GRFs
    13. Fix Camera Angles
    14. Read msgstringtable.txt
    15. Read questid2display.txt
    16. Remove Gravity Ads
    17. Gravity Logo
    18. Remove Hourly Announce
    19. Remove Serial Display
    20. Restore Login Window
    21. Translate Client
    22. Use Ascii on All LangTypes
    23. Use Normal Guild Brackets
    24. Use Plant Text Descriptions

     

    In addition, I've edited some of the:

    1. PACKETVER in mmo.h (20151029). 

    2. Changed the packet_key_ver in packet_db.txt to 54. 
    3. And, set the servertype to primary in clientinfo.xml (Client side).

     

    So, is there anything that I missed? Or, any solution for this?

    post-37962-0-58207900-1458289485_thumb.png

    • Upvote 1
×
×
  • Create New...