Jump to content

Extended Vending System [1.9] cleanup & fix


Napster

Recommended Posts


  • Group:  Members
  • Topic Count:  13
  • Topics Per Day:  0.00
  • Content Count:  36
  • Reputation:   2
  • Joined:  06/06/13
  • Last Seen:  

On 09/09/2017 at 11:47 AM, mhielo12 said:
On 09/09/2017 at 10:15 AM, mhielo12 said:

No error on map server :( im really lost.. 

you have a working sql for this? ill try to delete my sql..

EDIT:

Hi Technoken

I check the previous version and compare to the new version

in the old diff there is this line in item_vending.txt

Index: db/item_vending.txt
===================================================================
--- db/item_vending.txt    (nonexistent)
+++ db/item_vending.txt    (working copy)
@@ -0,0 +1,12 @@
+// Specific items for Vending System
+// Format: ItemID
+// Max items is equal MAX_INVENTORY ( 100 by default )
+
+// TCG Card
+7227
+// Mithril Coin
+674
+// Silver Coin
+675
+// Bronze Coin
+673

Should I remove this on the new patch?

I removed this in the new patch still not work.. :( help im lost.. :( is it zeny cash only working? :( 

 

I have the same problem.

 

the script is not working to buy in cash if the char does not have zeny the char in the minimum need to have 1 zeny in case he informs the message that you do not have cash even though okay I've tested everything is working right. Do not forget people who do not use sql tables need to do item_db2.txt

emulador/db/pre-re/item_db2.txt
emulador/db/re/item_db2.txt

30000,Zeny,Zeny,3,,10,10,,,,,,,,,,,,,{},{},{}
30001,Cash,Cash,3,,10,10,,,,,,,,,,,,,{},{},{}

Tanks...

Edited by christofereduardo
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  10
  • Topics Per Day:  0.00
  • Content Count:  65
  • Reputation:   38
  • Joined:  11/15/11
  • Last Seen:  

5 hours ago, christofereduardo said:

have error on skill.c

 


skill.c: In function ‘skill_castend_nodamage_id’:
skill.c:7521:17: warning: declaration of ‘i’ shadows a previous local [-Wshadow]
      int c = 0, i, d = 0;
                 ^
skill.c:6072:6: warning: shadowed declaration is here [-Wshadow]
  int i = 0;
      ^

 

Update the emulator to the latest version of git and apply the diff:

 

version 1.9.5 [08-09-2017].diff

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  13
  • Topics Per Day:  0.00
  • Content Count:  36
  • Reputation:   2
  • Joined:  06/06/13
  • Last Seen:  

 

I spent the afternoon pixel mechendo with this your diff is also giving this skill problem.

By the way, tell me where to fix this.
Edited by christofereduardo
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  20
  • Topics Per Day:  0.00
  • Content Count:  145
  • Reputation:   15
  • Joined:  01/06/12
  • Last Seen:  

Update to 09-15-2017.

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

version 1.9.5 (09-15-2017).diff

  • Upvote 1
  • Love 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  23
  • Topics Per Day:  0.01
  • Content Count:  112
  • Reputation:   4
  • Joined:  08/28/14
  • Last Seen:  

4 hours ago, solid2005 said:

Update to 09-15-2017.

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

version 1.9.5 (09-15-2017).diff

Whats the update? is item buying working now?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  37
  • Topics Per Day:  0.01
  • Content Count:  135
  • Reputation:   17
  • Joined:  12/31/11
  • Last Seen:  

8 hours ago, mhielo12 said:

Whats the update? is item buying working now?

always worked in the lasts diffs by @solid2005

Link to comment
Share on other sites

  • 1 month later...

  • Group:  Members
  • Topic Count:  38
  • Topics Per Day:  0.01
  • Content Count:  333
  • Reputation:   67
  • Joined:  09/05/12
  • Last Seen:  

On 9/15/2017 at 5:33 PM, solid2005 said:

Update to 09-15-2017.

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

version 1.9.5 (09-15-2017).diff

I used your diff on Git Hash 2c1df58 and I got this error when buying in any type of vending currency ( Zeny,Cash and Item(TCG) )

image.png.f72bb48e73e6cff18f9b04a6817ad447.png

I don't know why I got this error, since I have the item/zeny/cash and its gone when I buy the item.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  84
  • Topics Per Day:  0.02
  • Content Count:  309
  • Reputation:   82
  • Joined:  11/15/11
  • Last Seen:  

On ‎15‎/‎09‎/‎2017 at 6:33 AM, solid2005 said:

Update to 09-15-2017.

WARNING Backup first and use a test server if stable,

Note : Update for newer GIT NO (bug fix and add on).

version 1.9.5 (09-15-2017).diff

erro.png

error with the latest version of rAthena

Solved!

Change:

sv_readdb(dbsubpath1, "item_vending.txt",		',', 1, 1, ARRAYLENGTH(item_vend), &itemdb_read_vending, i); // Extended Vending system [Lilith]

To:

sv_readdb(dbsubpath1, "item_vending.txt",		',', 1, 1, ARRAYLENGTH(item_vend), &itemdb_read_vending, i > 0); // Extended Vending system [Lilith]

 

Edited by Dream Catcher
Link to comment
Share on other sites

  • 2 weeks later...

  • Group:  Members
  • Topic Count:  120
  • Topics Per Day:  0.03
  • Content Count:  295
  • Reputation:   6
  • Joined:  12/02/11
  • Last Seen:  

Is there any update with this mod i really like this one

this is what my the error on my console

Quote

Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\atcommand.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\battle.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\battleground.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\buyingstore.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\cashshop.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\channel.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\chat.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\chrif.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\clan.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\clif.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\duel.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\elemental.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\guild.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\homunculus.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\instance.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\intif.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\itemdb.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\log.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\mail.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\map.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\mercenary.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\mob.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\npc.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\npc_chat.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\party.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\pc.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\pc_groups.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\pet.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\quest.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\script.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\searchstore.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\skill.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\status.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\storage.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\trade.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\unit.obj    1    
Error    LNK2005    "struct s_item_vend * item_vend" (?item_vend@@3PAUs_item_vend@@A) already defined in achievement.obj    map-server    Desktop\rathena-master2\src\map\vending.obj    1    

im use the latest git rathena hope someone help me

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  37
  • Topics Per Day:  0.01
  • Content Count:  135
  • Reputation:   17
  • Joined:  12/31/11
  • Last Seen:  

anyone getting problem where when you try to buy from a item you get message saying the seller hasn't weight?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  84
  • Topics Per Day:  0.02
  • Content Count:  309
  • Reputation:   82
  • Joined:  11/15/11
  • Last Seen:  

On ‎15‎/‎09‎/‎2017 at 6:33 AM, solid2005 said:

USE THIS DIFF! 

 

6 hours ago, luan122 said:

anyone getting problem where when you try to buy from a item you get message saying the seller hasn't weight?

 

On ‎18‎/‎11‎/‎2017 at 3:45 PM, hakuren said:

Is there any update with this mod i really like this one

this is what my the error on my console

im use the latest git rathena hope someone help me

 

Edited by Windows XP
  • Like 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  477
  • Reputation:   269
  • Joined:  06/13/17
  • Last Seen:  

Quote

 

So i have problem with buying using the item too..
Tried to buy using the Zeny and Cash.. it works fine.. but when it comes to items.. it says "You do not have enough items", probably same error with mhielo.

i checked my codes line per line.. and there's no mistakes.. but it still give me the message You do not have enough items.. i use git hash 303bfb5. and your 9-15-207 version

 


Okay so i fixed my own problem.. @mhielo12 also maybe yours.

the problem on the diff is on the Vending.c

the thing about it says we don't have enough items because its looking on our cart.. not on our inventory.. =)

replace all the cart.u.items_inventory -> inventory.u.items_inventory
there are 4 cart.u.items_inventory on the diff. so you will see them easily.

 

Edited by Haruka Mayumi
  • Upvote 1
  • Like 1
Link to comment
Share on other sites

  • 1 month later...

  • Group:  Members
  • Topic Count:  3
  • Topics Per Day:  0.00
  • Content Count:  7
  • Reputation:   0
  • Joined:  02/18/17
  • Last Seen:  

ALGUEM ME AJUDE A TIRAR ESSE ERRO NA HORA DE COMPILAR?

JA DEU VÁRIOS ERROS QUE CONSEGUIR ARRUMAR, MAIS ESSE AINDA PERSISTE.

AGRADEÇO A AJUDA:

 

Spoiler

make[1]: Saindo do diretório `/home/emulador/src/login'
make[1]: Entrando no diretório `/home/emulador/src/char'
        MKDIR   obj
        CXX     char_clif.cpp
        CXX     char_cnslif.cpp
        CXX     char.cpp
        CXX     char_logif.cpp
        CXX     char_mapif.cpp
        CXX     int_achievement.cpp
        CXX     int_auction.cpp
        CXX     int_clan.cpp
        CXX     int_elemental.cpp
        CXX     inter.cpp
        CXX     int_guild.cpp
        CXX     int_homun.cpp
        CXX     int_mail.cpp
        CXX     int_mercenary.cpp
        CXX     int_party.cpp
        CXX     int_pet.cpp
        CXX     int_quest.cpp
        CXX     int_storage.cpp
        LD      char-server
make[1]: Saindo do diretório `/home/emulador/src/char'
make[1]: Entrando no diretório `/home/emulador/src/map'
        MKDIR   obj
        CXX     achievement.cpp
In file included from achievement.cpp:22:0:
clif.hpp:1069:19: error: ‘sd’ was not declared in this scope
 int clif_colormes(sd->fd, color_table[COLOR_CYAN], output);
                   ^
clif.hpp:1069:52: error: ‘output’ was not declared in this scope
 int clif_colormes(sd->fd, color_table[COLOR_CYAN], output);
                                                    ^
clif.hpp:1069:58: error: expression list treated as compound expression in initializer [-fpermissive]
 int clif_colormes(sd->fd, color_table[COLOR_CYAN], output);
                                                          ^
make[1]: ** [obj/achievement.o] Erro 1
make[1]: Saindo do diretório `/home/emulador/src/map'
make: ** [map] Erro 2

 


 

Link to comment
Share on other sites

  • 4 weeks later...

  • Group:  Members
  • Topic Count:  257
  • Topics Per Day:  0.08
  • Content Count:  737
  • Reputation:   18
  • Joined:  11/21/15
  • Last Seen:  

any updates??

is this now working on latest git??

Link to comment
Share on other sites


  • Group:  Forum Manager
  • Topic Count:  282
  • Topics Per Day:  0.06
  • Content Count:  3121
  • Reputation:   1613
  • Joined:  03/26/12
  • Last Seen:  

20 hours ago, whodhell said:

any updates??

Do you see any updates?

20 hours ago, whodhell said:

is this now working on latest git??

Have you tried?

Link to comment
Share on other sites

  • 3 weeks later...

  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  477
  • Reputation:   269
  • Joined:  06/13/17
  • Last Seen:  

UPDATE: Extended Vending 1.9.6
1. fix - checking currency from customer cart to inventory.

2. fix - vending_items sql update vending_id to not unique.

3. compatible to latest git full src/map CPP

Git hash: b48f0e8896e318e1f3cc75aee4bfeace957d7f19
 

Version 1.9.6 (02-11-2018).diff

Edited by Haruka Mayumi
  • Upvote 1
  • Love 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  0
  • Topics Per Day:  0
  • Content Count:  2
  • Reputation:   0
  • Joined:  04/15/13
  • Last Seen:  

i tried to patch this last update, but i get 

Quote

vending.diff:210: trailing whitespace.

vending.diff:236: trailing whitespace.
 * Extended Vending system [Lilith]
vending.diff:244: trailing whitespace.

vending.diff:257: trailing whitespace.
                if((item = itemdb_exists(item_vend.itemid)) != NULL &&
vending.diff:314: trailing whitespace.

error: patch failed: src/map/battle.cpp:8494
error: src/map/battle.cpp: patch does not apply
error: patch failed: src/map/battle.hpp:638
error: src/map/battle.hpp: patch does not apply
 

 

Edited by Jota
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  477
  • Reputation:   269
  • Joined:  06/13/17
  • Last Seen:  

On 2/17/2018 at 12:32 AM, Jota said:

i tried to patch this last update, but i get 

 

The git hash is already specified for no Error patch. if you get any error. it means that you are not using the git hash provided. so you need to patch it manually =)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  0
  • Topics Per Day:  0
  • Content Count:  2
  • Reputation:   0
  • Joined:  04/19/17
  • Last Seen:  

thanks you

 

Link to comment
Share on other sites

  • 3 weeks later...

  • Group:  Members
  • Topic Count:  1
  • Topics Per Day:  0.00
  • Content Count:  3
  • Reputation:   0
  • Joined:  03/10/18
  • Last Seen:  

How do i aplly this system in the emulator?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  10
  • Reputation:   0
  • Joined:  11/17/14
  • Last Seen:  

help please

ec6340a9679574256bd9ca71a0851525.png

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  197
  • Topics Per Day:  0.08
  • Content Count:  883
  • Reputation:   28
  • Joined:  02/13/17
  • Last Seen:  

got an error how to fix this?

 

image.png.6367bd5439c36ccb80e0d7f34eaa5fed.png

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  197
  • Topics Per Day:  0.08
  • Content Count:  883
  • Reputation:   28
  • Joined:  02/13/17
  • Last Seen:  

works as it intended but after clean recompile

 

skill vending cant use XD

Link to comment
Share on other sites

  • 5 weeks later...

  • Group:  Members
  • Topic Count:  48
  • Topics Per Day:  0.01
  • Content Count:  173
  • Reputation:   6
  • Joined:  12/20/11
  • Last Seen:  

is this working in latest svn?

 

Got error on recompiling with skill.cpp using latest git

 

Skill.c: In fuction 'skill_castend_nodamage_id':

Skill.c:7531: warning: implict declaración of fuction 'clif_vend'

Link to comment
Share on other sites

  • 1 month later...

  • Group:  Members
  • Topic Count:  117
  • Topics Per Day:  0.03
  • Content Count:  312
  • Reputation:   34
  • Joined:  10/15/12
  • Last Seen:  

please update ? 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...