Jump to content

Wanted: Pull Requests


Akkarin

Recommended Posts


  • Group:  Forum Manager
  • Topic Count:  282
  • Topics Per Day:  0.06
  • Content Count:  3122
  • Reputation:   1614
  • Joined:  03/26/12
  • Last Seen:  

Afternoon all!

 

I've just flicked a switch that will allow all commit info to be output to our IRC channel #rathena. In addition to this, i have also enabled Pull Request output to be sent there too:

 

Juq5apo.png

 

In theory, this will allow our devs who idle in the channel to quickly and easily review Pull Requests, as well as allow others who are in the channel to see what's going on by clicking the links provided by the IRC bot.

 

As always, Pull Requests are greatly appreciated!

 

 

 

(Note: the above image will differ depending on your IRC client and/or your theme)

  • Upvote 3
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  30
  • Topics Per Day:  0.01
  • Content Count:  121
  • Reputation:   1
  • Joined:  12/01/12
  • Last Seen:  

good job sir ;)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  127
  • Topics Per Day:  0.03
  • Content Count:  1445
  • Reputation:   163
  • Joined:  08/17/13
  • Last Seen:  

cool update for the devs. o:! ty!

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  81
  • Topics Per Day:  0.02
  • Content Count:  1654
  • Reputation:   583
  • Joined:  08/09/12
  • Last Seen:  

But I saw that the bot's name is different each time it joins the channel, but I assume basically it uses name like: Not-0xx (where xx is number)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  38
  • Topics Per Day:  0.01
  • Content Count:  949
  • Reputation:   173
  • Joined:  06/12/12
  • Last Seen:  

I hope the text encoding gets fixed when you submit a pull request via the Github web interface

 

inb4 my pull request disaster which was witnessed by @nanakiwurtz and co.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  81
  • Topics Per Day:  0.02
  • Content Count:  1654
  • Reputation:   583
  • Joined:  08/09/12
  • Last Seen:  

Yea, suddenly sandbox becomes a Chinese, just because he eats too much Chinese food...  /omg 

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  38
  • Topics Per Day:  0.01
  • Content Count:  949
  • Reputation:   173
  • Joined:  06/12/12
  • Last Seen:  

@Akkarin I already tried copy pasting via NP++, even tried it on chrome/firefox. Could you test it too? This is regarding to my PR for Gentle Touch skills

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...