Jump to content

Emistry's rentitem2 be added to SVN!


Peopleperson49

Recommended Posts


  • Group:  Members
  • Topic Count:  218
  • Topics Per Day:  0.05
  • Content Count:  1180
  • Reputation:   141
  • Joined:  01/27/12
  • Last Seen:  

Request that Emistry's rentitem2 be added to the svn. It works just like getitem2 but for rental items and is a great supplement to the rentitem script command.

 

Peopleperson49

 

http://rathena.org/board/topic/59677-rentitem2/?hl=rentitem

  • Upvote 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  31
  • Topics Per Day:  0.01
  • Content Count:  666
  • Reputation:   93
  • Joined:  04/27/12
  • Last Seen:  

I don't see why not. It would seem like this would be a long over due addition to rA. Also, since the work has been done for us, surely there can't be a real big reason as to why we don't add it. +1 for this.

Link to comment
Share on other sites


  • Group:  Developer
  • Topic Count:  153
  • Topics Per Day:  0.04
  • Content Count:  2285
  • Reputation:   745
  • Joined:  06/16/12
  • Last Seen:  

if someone make the pull request for it, I'll merge it.

I approve this suggestion. :P

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  

if someone make the pull request for it, I'll merge it.

What he said!

In general, if you want to add a feature that already exists, making a pull request will greatly increase the chances of us adding it (as well as speeding up the process).

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  218
  • Topics Per Day:  0.05
  • Content Count:  1180
  • Reputation:   141
  • Joined:  01/27/12
  • Last Seen:  

I'm not sure what a pull request is.

 

Peopleperson49

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  

I'm not sure what a pull request is.

See the Pull Request Q&A. :P
Link to comment
Share on other sites

  • 2 weeks later...

  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

I'll do it!

haha I remember at the time I didn't think this would be useful ... but I guess it is!

 

hello...i meet some problem in make a rental item....can u teach me?

i wan to make a +10 formal suit for 30days with a ghostring card...how to do that?

Currently there is only a 'rentitem' script command.

You would need 'rentitem2' (similar to getitem2) to specify refine rate and cards.

or maybe you could use 'rentitem', then @kick them and modify the item in SQL...

  • Upvote 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  18
  • Topics Per Day:  0.00
  • Content Count:  2044
  • Reputation:   682
  • Joined:  10/09/12
  • Last Seen:  

Brian

*makeitem2 command too :P

I want to make a script where a signed item is dropped on the floor

http://rathena.org/board/topic/73454-how-to-do-skull-will-be-auto-loot-on-pvp/?p=152141

  • Upvote 1
Link to comment
Share on other sites

  • 4 weeks later...

  • Group:  Developer
  • Topic Count:  153
  • Topics Per Day:  0.04
  • Content Count:  2285
  • Reputation:   745
  • Joined:  06/16/12
  • Last Seen:  

Implemented rentitem2 and makeitem2, 339c0a8

Link to comment
Share on other sites

×
×
  • Create New...