Cydh

Itemtype Update! Read this, very important!

Recommended Posts

Related info: Storage Armor & Weapon Tab are Inverted bugreport:8180

Commit: 9cca188 Dec 21, 2013

 

Attention!

Please are this info if you have running server below that date, if you have running server newer than it, you can ignore this.

For long time rAthena is running on wrong Item type. We're believing that Item type 4 for Weapon, and 5 for Armor which they're inverted.

  • Weapon must be 5
  • Armor must be 4
For TXT item_db

If you have custom items, you can change them manually or by using tools/convert_itemtype.pl which will changes all '5' to '4' and '4' to '5'.

 

convert_itemtype.pl --i=path/to/your/db/file.txt --o=path/to/your/db/file.txt
 

For MySQL item_db

Read this

give my 2 cents as well

 

open item_db2.txt

use notepad++, Ctrl+F, select Regular Expression

Find

^([0-9]*),([^,]*),([^,]*),4,

replace with

\1,\2,\3,99,

 

Find

^([0-9]*),([^,]*),([^,]*),5,

replace with

\1,\2,\3,4,

 

Find

^([0-9]*),([^,]*),([^,]*),99,

replace with

\1,\2,\3,5,

 

attachicon.gifregular_expression.png

 

 

 

sql command

update item_db2 set type = !(type -4) +4 where type = 4 or type = 5;
 

EDIT:

awww ...

regular expression doesn't seem able to do numeric calculation ... I think ?

  • Upvote 1

Share this post


Link to post
Share on other sites

or perl tools/convert_itemtype.pl --i=../db/item_db3.txt --o=../db/item_db3.txt

So you don't have to messed up the script =)

Share this post


Link to post
Share on other sites

give my 2 cents as well

open item_db2.txt

use notepad++, Ctrl+F, select Regular Expression

Find

^([0-9]*),([^,]*),([^,]*),4,

replace with

\1,\2,\3,99,

Find

^([0-9]*),([^,]*),([^,]*),5,

replace with

\1,\2,\3,4,

Find

^([0-9]*),([^,]*),([^,]*),99,

replace with

\1,\2,\3,5,

post-8685-0-48511900-1387666815_thumb.png

sql command

update item_db2 set type = !(type -4) +4 where type = 4 or type = 5;

EDIT:

awww ...

regular expression doesn't seem able to do numeric calculation ... I think ?

Edited by AnnieRuru
  • Upvote 1

Share this post


Link to post
Share on other sites

But how do you fix this in client side?

for the storage part, ok we can just switch the textures around, but what about the 2 mini windows?
2uxzfkh.jpg

Share this post


Link to post
Share on other sites

@AnnieRuru, I'll give u 5, u give me back 3! I made this post quickly after lighta's commit without thinking. looks so messy too

 

@Phenex, it just translation (msgstringtable.txt?) problem

post-5421-0-95548700-1387686144_thumb.jpg

Share this post


Link to post
Share on other sites

change the weapon type 5

 

and atk won't work

 

item for item  

1599,Angra_Manyu,Angra Manyu,5,1,,10,10000:10000,,....
 
OSldKJi.jpg

Share this post


Link to post
Share on other sites

in this step:

 

  • Execute this command
    convert_itemtype.pl --i=../db/item_db3.txt --o=../db/item_db3.txt

Why only pop out the context of convert_itemtype.pl ???

Share this post


Link to post
Share on other sites

u guys having problem too in upgrading weapon and armor? which is inverted? armor upgrade bonus gives attack

 

while

 

weapon upgrade bonus gives defense. i already did the convert_itemtype.pl all of my weapon 5 turns into 4

and all of my armor 5 turns into 4...

Share this post


Link to post
Share on other sites

weapon vs armor, fixed in 74740b4

Share this post


Link to post
Share on other sites

Now item Shadow Gear items place in Weapon Tab in storage...

this is intended?

Share this post


Link to post
Share on other sites

Now item Shadow Gear items place in Weapon Tab in storage...

this is intended?

this would be fixed.

Share this post


Link to post
Share on other sites

 

this would be fixed.

 

sorry Lilith when i double check the git version,

the Shadow Gear items had been placed in the right tab

 

Edit: ahh now i realize the issue, shadow weapon should in weapon tab while before is in armor tab,

thanks for the fix lilith

Edited by exneval

Share this post


Link to post
Share on other sites

sql command

UPDATE item_db2 SET TYPE = !(TYPE -4) +4 WHERE TYPE = 4 OR TYPE = 5;
 

/rice

Share this post


Link to post
Share on other sites

I ran this command

 

UPDATE item_db SET TYPE = !(TYPE -4) +4 WHERE TYPE = 4 OR TYPE = 5;

 

I did this live while the server was online and did @reloaditemdb, this should work right?

 

Once i did it the storage was okay however players were complaining that they lost a lot of damage.

 

Is there somthing else that needs to be done or does the server need to be offline before i run the command?

Edited by Avid

Share this post


Link to post
Share on other sites

shouldn't you need to recompile your server too ?

because there was enum value swap too

https://github.com/rathena/rathena/commit/74740b4

EDIT:

yeah I didn't see any info about having to update src file in the 1st post =/

Edited by AnnieRuru

Share this post


Link to post
Share on other sites

I already have the latest GIT

Edited by Avid

Share this post


Link to post
Share on other sites

screenrAthena001_zpsd42bf0b0.jpg

guys... did i miss anything else?

 

found problem

the notepad++ style i use converted my 29900-299xx > 2400-24xx which conflicted with my shoes

probably my mistake(maybe i forgot something)

Edited by powerboots

Share this post


Link to post
Share on other sites

Is this not automaticly fixed in the lastest revision alreadly? I have 17702, and it isnt fixed.

Share this post


Link to post
Share on other sites

Is this not automaticly fixed in the lastest revision alreadly? I have 17702, and it isnt fixed.

i dont know if you read it carefully but i believe your problem is msgstringtable.txt and/or texture translation. better to post this on client side section or seek the right file for this issue... maybe a request my help you.

Share this post


Link to post
Share on other sites

 

Is this not automaticly fixed in the lastest revision alreadly? I have 17702, and it isnt fixed.

i dont know if you read it carefully but i believe your problem is msgstringtable.txt and/or texture translation. better to post this on client side section or seek the right file for this issue... maybe a request my help you.

 

 

 

It happens to me on storage only, not inventory. Would this still be still msgstring problem?

Share this post


Link to post
Share on other sites

I use revision 17702

 

Client 2012-04-10 AragexeRE_J

 

all my weapons and armor are set correctly.

 

I get the problem that when i put a shield in my storage/gstorage it goes to Weapons

 

When i put a weapon in storage and gstorage it goes to Armor.

 

With Headgears/other gears all is normal.

 

note: All my items are set correctly  weapon = 5  armor = 4

 

 

how do i fix this?

Share this post


Link to post
Share on other sites

Yeah i have latest too and still bugged x_x why this hasn't updated on the latest revisions?

Share this post


Link to post
Share on other sites

@Kido

did you update your data/texture/À¯ÀúÀÎÅÍÆäÀ̽º/basic_interface/tab_itm_ex_01.bmp upto tab_itm_ex_07.bmp?

 

it looks something like this:

post-7484-0-07022000-1399349246_thumb.jpg

 

you can download it here:

https://github.com/ROClientSide/Translation/tree/master/Data/texture/%EC%9C%A0%EC%A0%80%EC%9D%B8%ED%84%B0%ED%8E%98%EC%9D%B4%EC%8A%A4/basic_interface

translation project by: dastgirpojee

 

 

to: admin

if this is illegal let me know and i will delete this right away.

  • Upvote 1

Share this post


Link to post
Share on other sites

@Kido

did you update your data/texture/À¯ÀúÀÎÅÍÆäÀ̽º/basic_interface/tab_itm_ex_01.bmp upto tab_itm_ex_07.bmp?

 

it looks something like this:

attachicon.giftab_itm_ex_03.JPG

 

you can download it here:

https://github.com/ROClientSide/Translation/tree/master/Data/texture/%EC%9C%A0%EC%A0%80%EC%9D%B8%ED%84%B0%ED%8E%98%EC%9D%B4%EC%8A%A4/basic_interface

translation project by: dastgirpojee

 

 

to: admin

if this is illegal let me know and i will delete this right away.

 

yeah thanks because i have the power to whatever i touch i destroy it so there was no way for me to do that other than switching texture, thanks a lot :333!

 

i also ended editing my whole item_db z________z manually z_____________________z! thanks again o:!

Share this post


Link to post
Share on other sites

give my 2 cents as well

open item_db2.txt

use notepad++, Ctrl+F, select Regular Expression

Find

^([0-9]*),([^,]*),([^,]*),4,

replace with

\1,\2,\3,99,

Find

^([0-9]*),([^,]*),([^,]*),5,

replace with

\1,\2,\3,4,

Find

^([0-9]*),([^,]*),([^,]*),99,

replace with

\1,\2,\3,5,

attachicon.gifregular_expression.png

sql command

update item_db2 set type = !(type -4) +4 where type = 4 or type = 5;
EDIT:

awww ...

regular expression doesn't seem able to do numeric calculation ... I think ?

 

This method solved my problem. Thank you so much @AnnieRuru

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.