Euphy Posted February 12, 2013 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1130 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted February 12, 2013 Topic: http://www.eathena.ws/board/index.php?showtopic=228775 Raw: http://svn.xp-dev.com/svn/tecnocronus_scripts/docs/EN/source_documentation.txt I stumbled upon this a while back. What do you think? Is this worth revising and adding into the SVN? Edit: Cleaned up the file. It needs more technical terminology and some restructuring; if anyone with good knowledge of C would like to take over, go ahead. source_doc.txt 5 Link to comment Share on other sites More sharing options...
Mystery Posted February 12, 2013 Group: Members Topic Count: 94 Topics Per Day: 0.02 Content Count: 2192 Reputation: 252 Joined: 11/11/11 Last Seen: June 24, 2020 Share Posted February 12, 2013 Topic: http://www.eathena.w...howtopic=228775 Raw: http://svn.xp-dev.co...cumentation.txt I stumbled upon this a while back. What do you think? Is this worth revising and adding into the SVN? I think it's relevant enough because if you think about it, it's similar to script_commands in our documentation folder teaching some attributes ( a lot I must say) regarding scripting. Although this doesn't necessarily give a whole in-depth and a lot of functions about source, I think it's still good for people to understand the structuring of the source. 2 Link to comment Share on other sites More sharing options...
Stolao Posted February 12, 2013 Group: Developer Topic Count: 48 Topics Per Day: 0.01 Content Count: 1443 Reputation: 337 Joined: 10/17/12 Last Seen: Wednesday at 07:55 PM Share Posted February 12, 2013 I think it would be a nice addition, at least give newer people a gentle push into making sorce mods. But I don't think it needs to be quite as long as the script_command.txt 1 Link to comment Share on other sites More sharing options...
Brian Posted February 12, 2013 Group: Members Topic Count: 75 Topics Per Day: 0.02 Content Count: 2223 Reputation: 593 Joined: 10/26/11 Last Seen: June 2, 2018 Share Posted February 12, 2013 Maybe the first half of that file can go in the SVN (or on the wiki?), but the 2nd half (descriptions of each source function), I think it'd be better to keep those in comments above each function. 1 Link to comment Share on other sites More sharing options...
Lemongrass Posted February 12, 2013 Group: Developer Topic Count: 28 Topics Per Day: 0.01 Content Count: 547 Reputation: 270 Joined: 11/08/11 Last Seen: December 26, 2023 Share Posted February 12, 2013 I agree with Brian. I would add it to the wiki and put the reasonable descriptions inside the code above the function. Maybe even in a format so that the programming environment can parse and show the function/structure description(if we decide to do it that way, we should decide on a environment or find a tool like cmake for comments inside the source code, if that is even possible). 1 Link to comment Share on other sites More sharing options...
xazax Posted February 17, 2013 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted February 17, 2013 About comments above functions... Doxygen? 2 Link to comment Share on other sites More sharing options...
Lighta Posted February 20, 2013 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted February 20, 2013 yes doxygen but we need to reparse each function and add a comment on what it's purpose. also texte are nice but I'd really love some UML schema, modele and sequence, especially sequence since we more or less know the modele already.That would be a huge plus in our organisation to know where to put this or this handle.. 2 Link to comment Share on other sites More sharing options...
frenzmu06 Posted February 21, 2013 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 326 Reputation: 47 Joined: 04/01/12 Last Seen: February 1, 2023 Share Posted February 21, 2013 +1 to this, i've been long playing with the emulator for years but din't bother on source (except porting/ patching diffs on my copy) coz of my lack of knowledge on source since i don't really understand the functions on it and been long wanting to know and have knowledge about it but i can't find any documentations on source editing, i really am glad when i saw this topic, this would help the community gain knowledge and encourage us on source editing. thanks for opening this topic master Euphy... more devs to come Link to comment Share on other sites More sharing options...
TecnoCronus Posted February 3, 2014 Group: Members Topic Count: 3 Topics Per Day: 0.00 Content Count: 8 Reputation: 3 Joined: 02/04/12 Last Seen: December 2, 2023 Share Posted February 3, 2014 lol that`s the documentation I started in 2009 I guess, I can help too. I was "ouside RO world" a long time, but now I`m coming back, I need study the source codes again, I don`t know what changed wich the Renewal yet. 2 Link to comment Share on other sites More sharing options...
Lighta Posted February 3, 2014 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted February 3, 2014 =) hi TechnoChronus, well we liked your doc but it was quite incomplete and more script_src oriented, so we,ve been working on it. I should be added on repo soon enough but you could review it and maybe add some : http://rathena.org/board/pastebin/v4exv6yzd6/ NB : This is not a final version 1 Link to comment Share on other sites More sharing options...
TecnoCronus Posted February 4, 2014 Group: Members Topic Count: 3 Topics Per Day: 0.00 Content Count: 8 Reputation: 3 Joined: 02/04/12 Last Seen: December 2, 2023 Share Posted February 4, 2014 yes, I was reading this doc, it`s more complete. We need to completely document the source code. I`ll be working in a new documentation, merging these two docs, and adding more content. 1 Link to comment Share on other sites More sharing options...
Boom Posted February 4, 2014 Group: Members Topic Count: 21 Topics Per Day: 0.01 Content Count: 182 Reputation: 22 Joined: 12/30/12 Last Seen: February 20, 2017 Share Posted February 4, 2014 yes, I was reading this doc, it`s more complete. We need to completely document the source code. I`ll be working in a new documentation, merging these two docs, and adding more content. =) hi TechnoChronus, well we liked your doc but it was quite incomplete and more script_src oriented, so we,ve been working on it. I should be added on repo soon enough but you could review it and maybe add some : http://rathena.org/board/pastebin/v4exv6yzd6/ NB : This is not a final version This would be of great help to future developers who want to dig in more to rA source. Thank you very much for the hardwork.. Cheers! Link to comment Share on other sites More sharing options...
Zezicla Posted February 5, 2014 Group: Members Topic Count: 30 Topics Per Day: 0.01 Content Count: 121 Reputation: 1 Joined: 12/01/12 Last Seen: May 9, 2015 Share Posted February 5, 2014 +1 already Link to comment Share on other sites More sharing options...
Euphy Posted February 16, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1130 Joined: 05/27/12 Last Seen: June 1, 2017 Author Share Posted February 16, 2014 Added the first draft of this in 1d77a9f. Thanks to everyone that was involved. @TecnoCronus: when you're finished with your changes, please submit a pull request! 1 Link to comment Share on other sites More sharing options...
Recommended Posts