Characters per account

[EvilPuncker]

I've always wondered why do we got two settings to do almost the same thing, can anyone explain it? maybe I'm missing something

//Max number of characters per account. Note that changing this setting alone is not enough if the client is not hexed to support more characters as well.
#define MAX_CHARS 9

// How many Characters are allowed per Account ? (0 = disabled)
chars_per_account: 0

[lekkereten]

9 (MAX_CHARS) is the number of slots that will be avaiable.

chars_per_account is the number of characters that you can create within MAX_CHARS slots.

Although I found that you can use any value on chars_per_account, even surpass MAX_CHARS, which is not a good practice.

Fixed that in r16937.

[EvilPuncker]

isn't chars_per_account redundant?

[malufett]

isn't chars_per_account redundant?

"chars_per_account is the number of characters that you can create within MAX_CHARS slots."

so nope it's not..

[xazax]

As far as I remember, the client can not handle arbitary number of character slots. At least old client couldn't, I do not know how the new clients behave. So I believe MAX_CHARS is there because of the client limitation. The chars_per_account is the settings users should use to limit the number of characters per account. Because modifying (especially increasing) MAX_CHARS may result in unintended behavior. But correct me if I'm wrong.

[EvilPuncker]

well, both values need to be the same, no?

[malufett]

well, both values need to be the same, no?

nope..since 0 means unlimited or by default value of MAX_CHARS

[Lemongrass]

I would change the console output from:

   if (char_per_account == 0) {
       ShowStatus("Characters per Account: 'Unlimited'.\n");
   } else {
       ShowStatus("Characters per Account: '%d'.\n", char_per_account);
   }

to this:

   if( char_per_account == 0 ){
       char_per_account = MAX_CHARS;
   }

   ShowStatus( "Characters per Account: '%d'.\n", char_per_account );

Since the word "unlimited" could be missleading for some users.

[EvilPuncker]

well, both values need to be the same, no?

nope..since 0 means unlimited or by default value of MAX_CHARS

still the same xD

[malufett]

still the same xD

hahahaha..but value 0 is more efficient in this case because no need to change its value every time we change MAX_CHARS..

[lekkereten]

I would change the console output from:

if (char_per_account == 0) {
	ShowStatus("Characters per Account: 'Unlimited'.\n");
} else {
	ShowStatus("Characters per Account: '%d'.\n", char_per_account);
}

to this:

if( char_per_account == 0 ){
	char_per_account = MAX_CHARS;
}

ShowStatus( "Characters per Account: '%d'.\n", char_per_account );

Since the word "unlimited" could be missleading for some users.

Indeed, thanks for that. Done in r16939.

[Cookie]

Marked as implemented.

[EvilPuncker]

btw I still think that 2 settings for the same thing is redundant

[kyeme]

I hope they implement -> http://rathena.org/board/topic/61773-one-char-per-gm-account/