Jump to content

Critical hit on Magic [2]


goddameit

Recommended Posts


  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   217
  • Joined:  11/22/11
  • Last Seen:  

(Not only magic, but also all damage skill)

Picture preview : http://goo.gl/91vrl

Video preview :



Introduction : hmm... let skill attack also has critical hit. (damage x2)

///////////////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////////////

Download :
Critical_hit_on_Magic_2.patch

Critical_hit_on_Magic_1.patch

Critical_hit_on_Magic.patch

///////////////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////////////

qiDdD.jpg

///////////////////////////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////////////

Update :

1. Show Full hit combo

2. Fix exp not gain and

int skill_mcri_hit(int tid, unsigned int tick, int id, intptr_t data)
{
struct mob_data *md = (struct mob_data *)data;
struct tmp_data *tmpd;
tmpd = &md->tmpd;
if(tmpd!=NULL)
{
switch(1) // 1 = red ; 2 = blue
{
Edited by goddameit
  • Upvote 2
  • MVP 2
  • Like 1
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  30
  • Topics Per Day:  0.01
  • Content Count:  782
  • Reputation:   82
  • Joined:  01/01/12
  • Last Seen:  

+1 for Diff files release.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   217
  • Joined:  11/22/11
  • Last Seen:  

+1 for Diff files release.

don't know how to do /hum
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  40
  • Topics Per Day:  0.01
  • Content Count:  587
  • Reputation:   104
  • Joined:  11/19/11
  • Last Seen:  

Brian's guide :

If you use TortoiseSVN, one easy way is:

  • checkout a working copy of the rAthena SVN trunk
  • do all your "Find and Replace" edits that you listed in your topic
  • then to generate the .diff file: right-click the /trunk folder --> TortoiseSVN --> Create Patch
  • Select all files, and click OK
  • enter a name for the file, and Save!

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   217
  • Joined:  11/22/11
  • Last Seen:  

Brian's guide :

If you use TortoiseSVN, one easy way is:

  • checkout a working copy of the rAthena SVN trunk
  • do all your "Find and Replace" edits that you listed in your topic
  • then to generate the .diff file: right-click the /trunk folder --> TortoiseSVN --> Create Patch
  • Select all files, and click OK
  • enter a name for the file, and Save!

thx. later do it.

---------

edit :

done

Edited by goddameit
Link to comment
Share on other sites

  • 2 weeks later...

  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

finally.. thanks for this /thx

Link to comment
Share on other sites

  • 3 weeks later...

  • Group:  Members
  • Topic Count:  21
  • Topics Per Day:  0.01
  • Content Count:  326
  • Reputation:   19
  • Joined:  09/27/12
  • Last Seen:  

+1 for AWESOME.

 

Hmmm, I could have sworn I posted an additional reply? I suppose it got lost in translation!

Anyway, in it I had mentioned there was a bug with this fix. When scoring criticals with abilities that have effects, such as spells and things like finger offensive, the effect does not occur and the sprite animation repeats. It acts a little weird when casting on a target and they die mid-attack (with a multi-hitting attack). It sort of makes them "auto target" random stuff until the "attack" animation finishes.

Also, every hit is a crit if one is... Is there a way to change this so crits are checked for each attack on multi-hitting skills, like thunderbolt?

I tried messaging goddameit, but no response. :(

Link to comment
Share on other sites

  • 2 weeks later...

  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

bug in latest revision..

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  21
  • Topics Per Day:  0.01
  • Content Count:  326
  • Reputation:   19
  • Joined:  09/27/12
  • Last Seen:  

bug in latest revision..

Yes, I was also going to past that this morning but didn't get around to it. Due to the new size modifications to monsters via "mob_once_spawn_sub" there is a compile error among what could potentially be other errors.

Uninstalling for now........

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

@Vach

I already fix the problem. heres the code, change the error.

md = mob_once_spawn_sub(src, src->m, src->x, src->y, "--en--",1083,"", SZ_SMALL, AI_NONE);
Edited by Yurika
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  21
  • Topics Per Day:  0.01
  • Content Count:  326
  • Reputation:   19
  • Joined:  09/27/12
  • Last Seen:  

@Vach

I already fix the problem. heres the code, change the error.

md = mob_once_spawn_sub(src, src->m, src->x, src->y, "--en--",1083,"", SZ_SMALL, AI_NONE);

Oh! Yea, I saw similarities in the code and knew this would fix it... but based on how this forces the size to small and the other issues with this I was talking about earlier... I'd rather see if Goddameit will update it himself before I start messing with it.

Thanks though. :)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

thanks you goddameit, your so awesome.. /thx

btw, can critical show in blue color?

Edited by Yurika
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  76
  • Topics Per Day:  0.02
  • Content Count:  455
  • Reputation:   57
  • Joined:  08/28/12
  • Last Seen:  

Very nice. Thank you very much.

btw, can critical show in blue color?

Yea, it would be nice. Like Teakwon kicks xD

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  21
  • Topics Per Day:  0.01
  • Content Count:  326
  • Reputation:   19
  • Joined:  09/27/12
  • Last Seen:  

WOOT! THANKS!

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   217
  • Joined:  11/22/11
  • Last Seen:  

btw, can critical show in blue color?

well, look not good, client problem.

http://bit.ly/ZS8dp1

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  76
  • Topics Per Day:  0.02
  • Content Count:  455
  • Reputation:   57
  • Joined:  08/28/12
  • Last Seen:  

Hm yea, you're right.

But special thanks that you try it.

You do a nice job.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

goddameit, I suggest this, for only all magic skill works..

if ( (src->type == BL_PC || battle_get_master(src)->type == BL_PC) && attack_type == BF_MAGIC )

ahmm, how can i change the blue critical?

Edited by Yurika
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  21
  • Topics Per Day:  0.01
  • Content Count:  326
  • Reputation:   19
  • Joined:  09/27/12
  • Last Seen:  

I like the blue critical myself, I don't mind that it looks slightly off... only thing is how it repeats and doesn't bounce like the other criticals; but like you said that's a client issue.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

@goddameit bug report.. no experience receive when the critical work..

Edited by Yurika
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  82
  • Topics Per Day:  0.02
  • Content Count:  223
  • Reputation:   4
  • Joined:  02/23/12
  • Last Seen:  

Uhmm just a request. would u able to do this a a item bonus?

.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   217
  • Joined:  11/22/11
  • Last Seen:  

@goddameit bug report.. no experience receive when the critical work..

update

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  21
  • Topics Per Day:  0.01
  • Content Count:  326
  • Reputation:   19
  • Joined:  09/27/12
  • Last Seen:  

Awesome, good job! Thank you.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  535
  • Reputation:   23
  • Joined:  11/19/11
  • Last Seen:  

@goddameit bug report again.. make map server crash when using earth quake. :)

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   217
  • Joined:  11/22/11
  • Last Seen:  

@goddameit bug report again.. make map server crash when using earth quake. :)

then make that skill will not run this function.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...