comparative Renewal Sakray Vs rAthena

[Ziu]

Initial:

Initial

Sakray HP = 13846 Vs rAthena HP = 13798 (sakray trans ranger) (rAthena Trans ranger)

Sakray HIT = 342 Vs rAThena HIT = 352

The rest is identical

UP AGI-> 50+8

Sakray ASPD = rAthena ASPD

Sakray DEF1 = rAThena DEF1

UP AGI -> 100+8

Sakray ASPD = rAthena ASPD

Sakray DEF1 = rAThena DEF1

UP DEX 50+16

Sakray ASPD = rAthena ASPD

Sakray DEF1 = rAThena DEF1

Sakray HIT = 391 Vs rAThena HIT = 401

UP VIT 45+5

Sakray DEF1 = rAThena DEF1

Sakray HP = 19594 Vs rAthena HP = 19527

UP DEX 84+16

Sakray ASPD = rAthena ASPD

Sakray HIT = 425 Vs rAThena HIT = 435

UP VIT 95+5

Sakray DEF1 = rAThena DEF1

Sakray HP = 26126 Vs rAthena HP = 26037

Edited July 6, 2012 by Ziu

[Jezu]

Looks like we're almost identical with kRO. Great and thanks for this comparison screenshots.

The only difference is HIT and HP formulas.

[malufett]

BTW I just want to make some clarification that only HP formula is missing in rathena specially with 3rd jobs...

the variance of the hit is cause of Vultures eye hit bonus...in Renewal the hit bonus is remove...anyway I'll do the fix if I'm free...^^

and thanks for the comparison..^^

and sir Zui how did you reset your stat in kRO Sakray?? I can't find it...

[Michi]

Here's the diff for status.c (rev r15734) http://pastebin.com/qzyFrkNbAnd here the db files:The real only difference is on ninja & guns HP, the rest is on Munak/Bongun classes (yep, they are on aegis files XD) and aren't relevant, so you can delete those classes and join job_maxsp files into one.pre-re/job_maxhp.txt http://pastebin.com/PHSB3F5Tpre-re/job_maxsp.txt http://pastebin.com/C3QVMgtsre/job_maxhp.txt http://pastebin.com/CvyN34hFre/job_maxsp.txt http://pastebin.com/EycnqLffEdit: Oops! I forgot: You have to remove HPFactor,HPMultiplicator & SPFactor fields from job_db1.txt too

It's look to fix the hp =)

[Vianna]

In my opinion, Vulture's Eye bonus not showing up in AEGIS is a bug and it shouldn't be replicated in rAthena...

@edit

When bRO updated to Renewal, ItachiSan from Cronus Emulator figured out how the HP formula works above level 99. AEGIS used a table only to avoid calculating the values in runtime (and probably to allow server-specific values).

http://trac.cronus-e.../changeset/3144

Formula:

HP(level) =    undefined, if level < 99
       HP_99, if level == 99
       HP_100, if level == 100
       HP(level - 1) + Job_HP + floor(Base_Value + (level - 101) * Level_Multiplier), if level > 100

Level_Multiplier and Base_Value have at most 2 decimal places.

All constants are unique to each job (but not to each class, so Baby Rune Knight, Rune Knight and Rune Knight Trans have the same values).

I'm not sure if bRO and kRO formulae are the same, but it's a start.

Also, according to him, there seems to be a rounding bug that was only noticed after the HPs got big enough.

rAthena does:

MAX_HP = floor(floor((BASE_HP * (1 + VIT / 100)) * TRANS_BONUS)

AEGIS does:

MAX_HP = floor(floor((BASE_HP * TRANS_BONUS) * (1 + VIT / 100))

Edited July 8, 2012 by Vianna

[malufett]

In my opinion, Vulture's Eye bonus not showing up in AEGIS is a bug and it shouldn't be replicated in rAthena...

oh..really...then we need more testing to confirm this...XD

[Rytech]

Try changing the HPFactor, HPMultiplicator, and SPFactor column's settings in the job_db1 file for the 3rd jobs. Their currently using the same settings as their 2nd job parts. Also I do remember compareing MaxHP/MaxSP for different level 99 2nd jobs to level 99 3rd jobs and ive found small difference in the MaxHP/MaxSP for them. So changing those columns settings for 3rd's could fix the problem.

[malufett]

The issue may just require adjusting those column settings for the 3rd jobs.

3rd jobs HP/SP when increasing in base level are not the same with the increase with the lower classes...I think they have a different calculation for it..

I already tested it..

[Vianna]

http://pastebin.com/zy4TVgM9 tries to find the x, y and z for the recursive function

HP(level) = HP(level - 1) + x + ((y + (level - 101) * z) / 1000)

given HP(100) and a table to compare the results of HP(a).

Using the Ranger table as input, the following output is generated:

90 304 924 (off by one 0 times)
90 305 924 (off by one 0 times)
90 306 924 (off by one 0 times)
90 307 924 (off by one 0 times)
90 308 924 (off by one 0 times)
90 309 924 (off by one 0 times)
90 310 924 (off by one 0 times)
90 311 923 (off by one 0 times)
90 311 924 (off by one 0 times)
90 312 923 (off by one 0 times)
90 312 924 (off by one 0 times)
90 313 923 (off by one 0 times)
90 313 924 (off by one 0 times)
90 314 923 (off by one 0 times)
90 314 924 (off by one 0 times)
90 315 923 (off by one 0 times)
90 315 924 (off by one 0 times)
90 316 923 (off by one 0 times)
90 316 924 (off by one 0 times)
90 317 923 (off by one 0 times)
90 317 924 (off by one 0 times)
90 318 923 (off by one 0 times)
90 318 924 (off by one 0 times)
90 319 923 (off by one 0 times)
90 319 924 (off by one 0 times)
90 320 923 (off by one 0 times)
90 320 924 (off by one 0 times)
90 321 923 (off by one 0 times)
90 321 924 (off by one 0 times)
90 322 923 (off by one 0 times)
90 322 924 (off by one 0 times)
90 323 923 (off by one 0 times)
90 323 924 (off by one 0 times)
90 324 923 (off by one 0 times)
90 324 924 (off by one 0 times)
90 325 923 (off by one 0 times)
90 325 924 (off by one 0 times)
90 326 923 (off by one 0 times)
90 326 924 (off by one 0 times)
90 327 923 (off by one 0 times)
90 327 924 (off by one 0 times)
90 328 923 (off by one 0 times)
90 328 924 (off by one 0 times)
90 329 923 (off by one 0 times)
90 329 924 (off by one 0 times)
90 330 923 (off by one 0 times)
90 330 924 (off by one 0 times)
90 331 923 (off by one 0 times)
90 331 924 (off by one 0 times)
90 332 923 (off by one 0 times)
90 332 924 (off by one 0 times)
90 333 923 (off by one 0 times)
90 333 924 (off by one 0 times)
90 334 923 (off by one 0 times)
90 334 924 (off by one 0 times)
90 335 923 (off by one 0 times)
90 335 924 (off by one 0 times)
90 336 923 (off by one 0 times)
90 336 924 (off by one 0 times)
90 337 923 (off by one 0 times)
90 337 924 (off by one 0 times)
90 338 923 (off by one 0 times)
90 338 924 (off by one 0 times)
90 339 923 (off by one 0 times)
90 339 924 (off by one 0 times)
90 340 923 (off by one 0 times)
90 340 924 (off by one 0 times)
90 341 923 (off by one 0 times)
90 341 924 (off by one 0 times)
90 342 923 (off by one 0 times)
90 342 924 (off by one 0 times)
90 343 923 (off by one 0 times)
90 343 924 (off by one 0 times)
90 344 923 (off by one 0 times)
90 345 923 (off by one 0 times)
90 346 923 (off by one 0 times)
90 347 923 (off by one 0 times)
90 348 923 (off by one 0 times)
90 349 923 (off by one 0 times)
90 350 923 (off by one 0 times)
90 351 923 (off by one 0 times)
90 352 923 (off by one 0 times)
90 353 923 (off by one 0 times)
90 354 922 (off by one 0 times)
90 354 923 (off by one 0 times)
90 355 922 (off by one 0 times)
90 355 923 (off by one 0 times)
90 356 922 (off by one 0 times)
90 356 923 (off by one 0 times)
90 357 922 (off by one 0 times)
90 357 923 (off by one 0 times)
90 358 922 (off by one 0 times)
90 358 923 (off by one 0 times)
90 359 922 (off by one 0 times)
90 359 923 (off by one 0 times)
90 360 922 (off by one 0 times)
90 360 923 (off by one 0 times)
90 361 922 (off by one 0 times)
90 361 923 (off by one 0 times)
90 362 922 (off by one 0 times)
90 362 923 (off by one 0 times)
90 363 922 (off by one 0 times)
90 363 923 (off by one 0 times)
90 364 922 (off by one 0 times)
90 364 923 (off by one 0 times)
90 365 922 (off by one 0 times)
90 365 923 (off by one 0 times)
90 366 922 (off by one 0 times)
90 366 923 (off by one 0 times)
90 367 922 (off by one 0 times)
90 367 923 (off by one 0 times)
90 368 922 (off by one 0 times)
90 368 923 (off by one 0 times)
90 369 922 (off by one 0 times)
90 369 923 (off by one 0 times)
90 370 922 (off by one 0 times)
90 370 923 (off by one 0 times)
90 371 922 (off by one 0 times)
90 371 923 (off by one 0 times)
90 372 922 (off by one 0 times)
90 372 923 (off by one 0 times)
90 373 922 (off by one 0 times)
90 373 923 (off by one 0 times)
90 374 922 (off by one 0 times)
90 374 923 (off by one 0 times)
90 375 922 (off by one 0 times)
90 375 923 (off by one 0 times)
90 376 922 (off by one 0 times)
90 376 923 (off by one 0 times)
90 377 922 (off by one 0 times)
90 377 923 (off by one 0 times)
90 378 922 (off by one 0 times)
90 378 923 (off by one 0 times)
90 379 922 (off by one 0 times)
90 379 923 (off by one 0 times)
90 380 922 (off by one 0 times)
90 380 923 (off by one 0 times)
90 381 922 (off by one 0 times)
90 381 923 (off by one 0 times)
90 382 922 (off by one 0 times)
90 382 923 (off by one 0 times)
90 383 922 (off by one 0 times)
90 383 923 (off by one 0 times)
90 384 922 (off by one 0 times)
90 384 923 (off by one 0 times)
90 385 922 (off by one 0 times)
90 386 922 (off by one 0 times)
90 387 922 (off by one 0 times)
90 388 922 (off by one 0 times)
90 389 922 (off by one 0 times)

So, perfect matches for all the levels, it seems like it's the formula used by kRO =P

And if it's not, it's good enough.

Edited July 8, 2012 by Vianna

[mrlongshen]

its just a little. gogo dev. support you all

[Euphy]

Bringing this back - there are still (very small) differences between us and your screenshots, even after implementing official HP/SP tables and Renewal Attack (along with countless other fixes). Can anyone explain them?

[TheFinalEpisode]

Time to revise the trunk and to make it accurate. but it takes lot of time to our developer due to limited resources. i guess