Import Revision into Scripts

[GM Djinsu]

Okay over the years this has driven me absolutely crazy like a thorn in my head when working with a new server build

and I am sure others encounter this on a daily basis. So the idea comes from the import folder importing into the configuration

folder. What I am suggesting is importing the rAthena version number that a script was last edited in so that when you open say;

server_side/npc/custom/quests/sunglasses.txt

This script's current version is "1.7" however where did it come from & when was it last updated? Answer: r16169 SVN

//===== rAthena Script =======================================
//= Quest For Slotted Sunglasses
//===== By: ==================================================
//= amichan
//===== Current Version: =====================================
//= 1.7
//===== Compatible With: =====================================
//= rAthena SVN
//===== Description: =========================================
//= Quest to get Slotted Sunglasses
//===== Additional Comments: =================================
//= quest will reset it self after 1 pair of Slotted Sunglasses is made.
//=
//= 1.0 by Aegis 1.1 by aichan 1.2 by x[tsk] 1.3 by Darkchild
//= 1.5 Fixed Exploit [Lupus]
//= 1.6 Fixed Exploit [KarLaeda]
//= 1.7 Relocated 'Maseph' to moc_fild07. [Kisuka]
//============================================================

//===== Current Version: =====================================

//= 1.7 < import r16169 SVN > Here.

What I would like to see is anytime there is an update to an existing script even if it is simply a typographical error commit that the

rAthena Version is imported into the header of the script. Ironic that the script I choose has a typographical error in its header, so

lets say we change it

//= quest will reset it self after 1 pair of Slotted Sunglasses is made.

//= quest will reset it its self after 1 pair of Slotted Sunglasses is made. (Either)

//= quest will reset it itself after 1 pair of Slotted Sunglasses is made. (Or)

So while the version of the script may not change, the revision it is under does change so it would be;

//===== Current Version: =====================================

//= 1.7 < import r16170 SVN > Here.

After it is corrected and commited to the SVN the revision would be imported into the script itself.

I think if this suggestion were to be implemented I would have more hair XD

and on a serious note this would help us as a community to see what has and has not been looked

through fixed and edited without having to scour endless changelogs and commit changes to ensure

nothing has changed when working with new builds etc.

I am interested to hear any and all thoughts about this suggestion you might have? How has this

'issue' effected you if at all?

[Brian]

I am interested to hear any and all thoughts about this suggestion you might have?

How has this 'issue' effected you if at all?

If the computer I'm on has TortoiseSVN installed, I use SVN Log to view the history.

Or I view it on Trac: http://trac.rathena.org/log/rathena/trunk/npc/custom/quests/sunglasses.txt

What you're suggesting has already been added to trunk/doc/script_commands.txt (r15473) but I am not sure if we will do this for EVERY file.

//===== rAthena Doc ===========================================
//= rAthena Script Commands
//===== By: ==================================================
//= rAthena Dev Team
//===== Current Version: =====================================
//= $Revision$
//===== Last Updated: ========================================
//= $LastChangedDate$
//===== Description: =========================================
//= A reference manual for the rAthena scripting language.
//= Commands are sorted depending on their functionality.
//============================================================

//===== Current Version: =====================================
//= $Revision: 16165 $
//===== Last Updated: ========================================
//= $LastChangedDate: 2012-05-29 05:08:59 -0700 (Tue, 29 May 2012) $

[KeiKun]

isn't the rev of the script can be found under svn log when

file > right click > svn log

shows the last revision and the message there~

EDIT:

Adding it to each file...

no idea why need to do that if you can see it already under svn log..

unless you don't checkout the whole svn or trunk (exported)

[GM Djinsu]

If the computer I'm on has TortoiseSVN installed, I use SVN Log to view the history.

Or I view it on Trac: http://trac.rathena..../sunglasses.txt

What you're suggesting has already been added to trunk/doc/script_commands.txt (r15473) but I am not sure if we will do this for EVERY file.

//===== rAthena Doc ===========================================
//= rAthena Script Commands
//===== By: ==================================================
//= rAthena Dev Team
//===== Current Version: =====================================
//= $Revision$
//===== Last Updated: ========================================
//= $LastChangedDate$
//===== Description: =========================================
//= A reference manual for the rAthena scripting language.
//= Commands are sorted depending on their functionality.
//============================================================

//===== Current Version: =====================================
//= $Revision: 16165 $
//===== Last Updated: ========================================
//= $LastChangedDate: 2012-05-29 05:08:59 -0700 (Tue, 29 May 2012) $

I agree this is fairly easy to do and is quite effective to simply check the SVN log, but believe if we added the extended compatibility

for this into as many instances as possible that it can only be a good thing letting you know on the fly what exactly your working with,

how up to date it is & knowing which versions to compare for changes between the two. I know every one who has run or been a part

of a dedicated server has racked their brains from time to time trying to track down version changes between two distinct revisions.

Regarding it being added to trunk/doc/script_commands.txt this is exactly what I in-vision for as many instances as possible! Also

this is the first I have noticed it in this location and must say this is a perfect example of how this can benefit other portions of our SVN such

as NPC/Scripts as I am suggesting.

This being in this location is so great because there is not much more important when working with a new revision than knowing what new

commands and compatibility your really working with. Relying on old commands is what causes sloppy scripting with less compatibility / reliability.'

I would like to personally +1 whoever added it in this location!

@Brian - Would this even be difficult to add in the form I am suggesting? Also thank you for your Input on this!

isn't the rev of the script can be found under svn log when

file > right click > svn log

shows the last revision and the message there~

EDIT:

Adding it to each file...

no idea why need to do that if you can see it already under svn log..

unless you don't checkout the whole svn or trunk (exported)

For me and I am sure many many others this does not work as our files are on

a remote V.P.S. and not actually on the same machine we work from and once a

revision has been pulled apart edited and uploaded it isn't comparable to the revision it

is at its core and even when comparing from a machine with tortoise on a new revision

to your working copy it can get quite difficult if you have no clue exactly what revision

your initial build was exactly when your files don't have any indication as I am suggesting

to add to them in the header so you never loose track of your working copy.

@KeiKun - Thank you so much for your input, I greatly appreciate it and it's always welcomed!

[Euphy]

Since we're no longer using SVN, there's nothing left to discuss here.