Kindly check this source code

[Jin Freecs]

i recently add this src mod in my server when i recompile my server no error appears but when i try to start the server theres also no error and working fine but the problem is im getting random MAP CRASH and DONT SEND error appears. is there any way to see the logs of map server crash?? (windows os) and also i noticed if i use @killmonster the map server crash.

mob.c

//Increase drop rate if user is a premium user

if (sd->gmlevel == 1) // now rig the drop rate to never be over 90% unless it is originally >90%.

drop_rate = max(drop_rate,cap_value((int)(0.5+drop_rate*(120)/100.),0,9000));

[Lighta]

do you have a coredump or something ?,

anyway jugging by this snippet, I bet your sd probably null something wich cause null pointer exception, (sigfault in C sorry)

so try out something like :

if(sd && sd->gmlevel ==1).......

Edited March 5, 2012 by Lighta

[Jin Freecs]

sorry i dont have the coredump im using the windows os and i dont know how to get that coredump

ok i will try that code then i will update you once ive finish testing

@Lighta wow it works haha dont have any errors in compiling and also when i used the @killmonster my map server not crash anymore. anyway thanks and can you just give some hint why im having a map crash b4? i got random map crash when i add the

//Increase drop rate if user is a premium user

if (sd->gmlevel == 1) // now rig the drop rate to never be over 90% unless it is originally >90%.

drop_rate = max(drop_rate,cap_value((int)(0.5+drop_rate*(120)/100.),0,9000));

[Lighta]

I can try, I dunno where is this but I assume it's when a mob is dead right, your issue here is that you assumed that everyone (every object) that killed a mob had a gmlevel attribute wich ain't the case.

To try to be more explicite you have lot of bl_type : bl_mob, bl_pet, bl_hom, and only bl_pc would fit you're case.

[Jin Freecs]

oh i see new knowledge thanks Lighta anyway do you think this will be fixed my map crash?

Thanks for all the info

[Derceto]

More like, it was a null reference exception (dereferencing a null pointer).

(sd->gmlevel == 1) is same as (*sd).gmlevel; in this case, if (sd == null), you're doing a forbidden operation (*null)

The expression

(sd && sd->gmlevel ==1)

is true only when both statements "sd" and "sd->gmlevel==1" are true, so when program encounters "sd" being false (sd == null) it stops reading the expression and gets it as false, thus not doing the *null operation in the next part of expression.

Hope I'm clear enough.