Emistry Posted March 1, 2012 Share Posted March 1, 2012 File Name: RentItem2 File Submitter: Emistry File Submitted: 01 Mar 2012 File Category: Source Modifications Content Author: Brian A Script command that extent the usage of rentitem it work just like item2 command..but with rental period. *rentitem2 <item id>,<time>, <identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>; *rentitem2 "<item name>",<time>, <identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>; original post link : http://www.eathena.w...1 I have updated the diff with these changes, and now it works on the current rAthena (r16852). rentitem2_r16852.diff Click here to download this file Quote Link to comment Share on other sites More sharing options...
ngek202 Posted March 23, 2012 Share Posted March 23, 2012 (edited) not working on latest SVN a Question also, can the Card be removed? Edited March 23, 2012 by ngek202 Quote Link to comment Share on other sites More sharing options...
Emistry Posted March 23, 2012 Author Share Posted March 23, 2012 a Question also, can the Card be removed? http://www.eathena.ws/board/index.php?s=&showtopic=241313&view=findpost&p=1318374 Quote Link to comment Share on other sites More sharing options...
Jayz Posted October 29, 2012 Share Posted October 29, 2012 rentitem2 not working bump.. any solutions? Quote Link to comment Share on other sites More sharing options...
Jhedzkie Posted October 31, 2012 Share Posted October 31, 2012 it works fine for me. nothing to fix. just apply all patches properly. been using this since june. Quote Link to comment Share on other sites More sharing options...
Brian Posted October 31, 2012 Share Posted October 31, 2012 The original rentitem2.diff I posted in March 2010 works for e/rAthena r14260. rentitem2 not working The diff no longer works due to these changes: - r15420/trunk/src/map/script.c - r16361/trunk/src/map/script.c I have updated the diff with these changes, and now it works on the current rAthena (r16852). rentitem2_r16852.diff Quote Link to comment Share on other sites More sharing options...
serakh00 Posted November 13, 2012 Share Posted November 13, 2012 (edited) i found 2 bugs on this command : 1. When an item expired while being equiped,it didn't dissapear, it is just moved to inventory and not equipable. But the item dissapear when character logout or changing map. (Not critical) 2. Adding card to rentitem is abusable, The slotted card can easily extracted by card remover. Player will get "Free" card from this method. (This is absolutely critical) Hope fixed soon.. Edited November 13, 2012 by serakh00 Quote Link to comment Share on other sites More sharing options...
Emistry Posted November 13, 2012 Author Share Posted November 13, 2012 2. Adding card to rentitem is abusable, The slotted card can easily extracted by card remover. Player will get "Free" card from this method. (This is absolutely critical) Hope fixed soon.. add this diff.. and re-edit your npc to check for the expire date of and item before they can remove card from the item. http://www.eathena.ws/board/index.php?showtopic=241313&view=findpost&p=1318374 Quote Link to comment Share on other sites More sharing options...
QQfoolsorellina Posted November 13, 2012 Share Posted November 13, 2012 (edited) i found 2 bugs on this command : 1. When an item expired while being equiped,it didn't dissapear, it is just moved to inventory and not equipable. But the item dissapear when character logout or changing map. (Not critical) 2. Adding card to rentitem is abusable, The slotted card can easily extracted by card remover. Player will get "Free" card from this method. (This is absolutely critical) Hope fixed soon.. 2. in original post, you can get script command getequipexpiretick if(getequipexpiretick(<equipment slot>)) close; Well , Emistry post faster than me lol.. Edited November 13, 2012 by QQfoolsorellina Quote Link to comment Share on other sites More sharing options...
serakh00 Posted November 13, 2012 Share Posted November 13, 2012 (edited) i got this error when compiled with the diff (getequipexpiretic) 1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6531): error C2065: 'equip' : undeclared identifier 1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6531): error C2065: 'equip' : undeclared identifier 1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6531): error C2109: subscript requires array or pointer type 1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6538): error C2065: 'equip' : undeclared identifier 1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6538): error C2109: subscript requires array or pointer type 1>d:\installer\kro\client_full\svn area\server 2012 04 10\src\map\script.c(6538): error C2198: 'pc_checkequip' : too few arguments for call Edited November 13, 2012 by serakh00 Quote Link to comment Share on other sites More sharing options...
QQfoolsorellina Posted November 13, 2012 Share Posted November 13, 2012 in your script.c, can you find this ? static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW}; Quote Link to comment Share on other sites More sharing options...
serakh00 Posted November 13, 2012 Share Posted November 13, 2012 in your script.c, can you find this ? static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW}; sure there is Quote Link to comment Share on other sites More sharing options...
QQfoolsorellina Posted November 13, 2012 Share Posted November 13, 2012 (edited) in your script.c, can you find this ? static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW}; sure there is It must be declared before you use equip[num] , so BUILDIN_FUNC(getequipexpiretick){...} must be put after that array declare Edited November 13, 2012 by QQfoolsorellina Quote Link to comment Share on other sites More sharing options...
serakh00 Posted November 13, 2012 Share Posted November 13, 2012 in your script.c, can you find this ? static unsigned int equip[] = {EQP_HEAD_TOP,EQP_ARMOR,EQP_HAND_L,EQP_HAND_R,EQP_GARMENT,EQP_SHOES,EQP_ACC_L,EQP_ACC_R,EQP_HEAD_MID,EQP_HEAD_LOW}; sure there is It must be declared before you use equip[num] , so BUILDIN_FUNC(getequipexpiretick){...} must be put after that array declare OK its work now.. sorry for my fool Thanks QQ and Emistry for fast respone. Quote Link to comment Share on other sites More sharing options...
GM Takumirai Posted November 13, 2012 Share Posted November 13, 2012 can someone update the patch? Quote Link to comment Share on other sites More sharing options...
Emistry Posted November 13, 2012 Author Share Posted November 13, 2012 I have updated the diff with these changes, and now it works on the current rAthena (r16852). rentitem2_r16852.diff read previous post....beside i already updated the Download site too.... Quote Link to comment Share on other sites More sharing options...
serakh00 Posted February 27, 2013 Share Posted February 27, 2013 someone can update this to recent revision? Quote Link to comment Share on other sites More sharing options...
kyeme Posted February 27, 2013 Share Posted February 27, 2013 someone can update this to recent revision? Its working @latest rev. Quote Link to comment Share on other sites More sharing options...
jotinha Posted January 13, 2020 Share Posted January 13, 2020 would be nice if it were rentitem2 <item id> <amount> <time> Quote Link to comment Share on other sites More sharing options...
