Jump to content

Convert to GIT


Jonne

Recommended Posts


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  303
  • Reputation:   101
  • Joined:  11/13/11
  • Last Seen:  

bump on this?

github now has a "svn emulator" that can be used to checkout/commit and track revisions as numbers so it will not be a problem for the users/developers that don't know how to use Git.

  • Upvote 2
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

Github is a way better than any other git hosting ._.

I think SubGit is a server-side tool you install. It's not Git hosting.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  40
  • Reputation:   20
  • Joined:  12/31/11
  • Last Seen:  

Github is a way better than any other git hosting ._.

I think SubGit is a server-side tool you install. It's not Git hosting.

yes, i tought of using it as a "bridge" between the current svn and github.

and i agree, github is the best :)

The things that we would benefit the most of git are in my opinion:

1. You can commit your custom changes to your local copy without making them public (for server own custom stuff - doesn't work with svn)

2. Pull requests!

No need for diff files anymore and the user gets always his credits, as he is the commit autor.

Also you can discuss it (on a line inside the diff or global for this diff) before merging it.

So instead of taking a diff with ugly code and clean it up before commiting, you could tell the pull request autor what is ugly and how to change it and when everything is ok, you merge it.

That way he gets better at coding and maybe makes it right the next time.

3. devs can code big stuff in a separate branch without fear of breacking anything and merge it afterwards.

That way we have many little commits (if he/she commited often) instead of a huge wall of code in one commit.

But if you want to see the "wall of code", you can do that by looking at the diff of the merge.

Edited by saithis
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

I registered as an Open Source project and it was approved, so we have a license in case we decide to use this.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  40
  • Reputation:   20
  • Joined:  12/31/11
  • Last Seen:  

Just curious, how will it be decided if rA uses it or git generally?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

The way I understood, I thought developers can commit to SVN or Git and SubGit will synchronize the commits between both repositories?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  40
  • Reputation:   20
  • Joined:  12/31/11
  • Last Seen:  

Yes, thats how I unterstood it too.

My question was because of your last post:

I registered as an Open Source project and it was approved, so we have a license in case we decide to use this.

I interpreted this as "in case we install subgit", so I wanted to know who decides if it will be installed.

Or did you mean "it will be installed and lets see if anyone uses it"?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

I think if the majority of the developers agree, then we should install it!

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  303
  • Reputation:   101
  • Joined:  11/13/11
  • Last Seen:  

Without GitHub isn't the same thing ;(

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  75
  • Topics Per Day:  0.02
  • Content Count:  2223
  • Reputation:   593
  • Joined:  10/26/11
  • Last Seen:  

Can SubGit be used with GitHub (can it push to remote repositories) ?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  40
  • Reputation:   20
  • Joined:  12/31/11
  • Last Seen:  

Without GitHub isn't the same thing ;(

I agree with that

Can SubGit be used with GitHub (can it push to remote repositories) ?

http://subgit.com/bo...ml#installation

Seems like both (git repo and svn repo) have to be on the same server.

So it can't be used directly with GitHub.

I googled a bit and it seems like it could be done with post-receive hooks on both ends and maybe a mirror in the middle.

But I'm not sure, if the mirror is needed or not.

Edited by saithis
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  303
  • Reputation:   101
  • Joined:  11/13/11
  • Last Seen:  

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  2
  • Topics Per Day:  0.00
  • Content Count:  40
  • Reputation:   20
  • Joined:  12/31/11
  • Last Seen:  

Wow, I didn't know that GitHub supports svn :o

That would be even better in my opinion.

Link to comment
Share on other sites

  • 4 weeks later...

  • Group:  Members
  • Topic Count:  1
  • Topics Per Day:  0.00
  • Content Count:  4
  • Reputation:   5
  • Joined:  02/06/12
  • Last Seen:  

I sure do prefer git to SVN, it makes merging changes from rAthena & branching really bloody easy.

I set up a git mirror of official rAthena here: https://github.com/nevelis/rAthena

It's updated every few minutes so it's recent. I would strongly encourage the core dev team move to git too - this will allow people to send in pull requests for features & bug fixes.

  • Upvote 1
Link to comment
Share on other sites

  • 4 weeks later...

  • Group:  Members
  • Topic Count:  20
  • Topics Per Day:  0.00
  • Content Count:  213
  • Reputation:   109
  • Joined:  05/21/12
  • Last Seen:  

This is already in the process of being worked out. We will still provide support to SVN, as well. Give us some time to transition as we're restructuring the development teams, and its entities.

Thanks,

-Cookie

Link to comment
Share on other sites

  • 1 month later...

  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  56
  • Reputation:   30
  • Joined:  02/22/12
  • Last Seen:  

Any movement on this? I think moving rAthena onto github would greatly benefit the project.

In my opinion, github is the true spirit of open source. People don't have to be in the main dev team to contribute to the project. They can do a fork of the project, add some cool changes, and then others can vote on if it's good enough to be pulled into the main repo.

Having it hosted on github will defiantly improve the community aspect of everyone helping contribute.

Yes, git is a bit of a learning curve. But once you understand it, you never go back to SVN. Git just works so much better in my opinion...

For those interested in reading up on git, I highly suggestion checking out Pro Git : http://git-scm.com/book

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  33
  • Topics Per Day:  0.01
  • Content Count:  355
  • Reputation:   34
  • Joined:  02/09/12
  • Last Seen:  

I really love GIT, is a whole more easyer than SVN ... +1 for this! .. how is this going? ..any news?

Link to comment
Share on other sites

  • 6 months later...

  • Group:  Members
  • Topic Count:  72
  • Topics Per Day:  0.02
  • Content Count:  2997
  • Reputation:   1130
  • Joined:  05/27/12
  • Last Seen:  

Link to comment
Share on other sites

×
×
  • Create New...