Gepard Posted February 10, 2012 Group: Members Topic Count: 22 Topics Per Day: 0.00 Content Count: 392 Reputation: 285 Joined: 12/19/11 Last Seen: January 23, 2022 Share Posted February 10, 2012 I've updated previous post http://rathena.org/b...dpost__p__76920 with some more details. Promised diff file is attached. Unfinished stuff: atcommand logging (logs all of them now) conf/help.txt (I did ~10 commands, but rest is untouched) conf/groups.conf (needs better default setup) add libconfig to Makefiles, CMake and VS9 project (only VS10 for now) Please review/test changes. It's a big update and there are chances that smth is wrong. I'd appreciate help with Makefiles/CMake and help.txt/groups.conf. gmsystem.patch 1 Link to comment Share on other sites More sharing options...
Ind Posted February 11, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.04 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted February 11, 2012 Looks great -- I've read the diff, not able to test from here, but I already got a question: why did you split the alias in a different dbmap? from what I understand both maps basically do the same thing (point to AtCommandInfo), and both seem to expect unique indexes -- if my thought line is correct, then why did you split it? Link to comment Share on other sites More sharing options...
Gepard Posted February 11, 2012 Group: Members Topic Count: 22 Topics Per Day: 0.00 Content Count: 392 Reputation: 285 Joined: 12/19/11 Last Seen: January 23, 2022 Share Posted February 11, 2012 To be able to iterate over original commands only. To be able to iterate over aliases only (will be used in @help <command> to display a list of all aliases to the command). To disallow configuration of commands in groups.conf via aliases. In short to have a quick and simple method do distinguish between commands and aliases. It probably could be achieve other way (like comparing key (search name) to AtCommandInfo.command every time), but adding a separate DBMap is really simple and efficient way. I like DBMaps, and don't know of any reasons to avoid using them. Link to comment Share on other sites More sharing options...
Ind Posted February 11, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.04 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted February 11, 2012 i see, thank you for taking the time to explain to me. Link to comment Share on other sites More sharing options...
Gepard Posted February 12, 2012 Group: Members Topic Count: 22 Topics Per Day: 0.00 Content Count: 392 Reputation: 285 Joined: 12/19/11 Last Seen: January 23, 2022 Share Posted February 12, 2012 I did 2 of missing tasks: better default setting for conf/groups.txt and updated help.txt a bit (it'll have to be reviewed again). And @help displays a list of aliases now, eg > @help help Help for command @help: Available aliases: h Params: <command> Shows help for specified command. I wonder how should I filter atcommand logging... Should this be per group, per command or both? Link to comment Share on other sites More sharing options...
Ind Posted February 12, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.04 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted February 12, 2012 Hehe I'd say both but perhaps command is more than enough Link to comment Share on other sites More sharing options...
Gepard Posted February 13, 2012 Group: Members Topic Count: 22 Topics Per Day: 0.00 Content Count: 392 Reputation: 285 Joined: 12/19/11 Last Seen: January 23, 2022 Share Posted February 13, 2012 I eventually added "filter by group", because it resembles the previous "log above GM lv X" approach. Filtering by command can be added at later time. Now I need to fix Make/CMake stuff and should be ready to commit. It is done (well, except CMake, but I won't update this "experimental" shit) http://rathena.org/b...issions-system/ r15572 While working on it, I've noticed a few things that need to be done: cleanup Makefiles, cause they still have remains of TXT version cleanup atcommands, cause there is some hardcore copypasta happening review conf/help.txt - I did not verify all of the contents, just updated syntax so it works with new system review doc/atcommands.txt - it's also copied from conf/atcommand_athena.conf, not verified whether descriptions are accurate The last two are tasks for documentation managers. Link to comment Share on other sites More sharing options...
xazax Posted February 13, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted February 13, 2012 Well, it is a bit off topic, but I think, we should ask if somebody wants to maintain the CMake files. If noone is interested, we shoud drop them. Link to comment Share on other sites More sharing options...
Gepard Posted February 13, 2012 Group: Members Topic Count: 22 Topics Per Day: 0.00 Content Count: 392 Reputation: 285 Joined: 12/19/11 Last Seen: January 23, 2022 Share Posted February 13, 2012 There is already a topic about it: CMake. I'd maintain CMakeLists but don't know how. Link to comment Share on other sites More sharing options...
Maki Posted June 6, 2012 Group: Members Topic Count: 146 Topics Per Day: 0.03 Content Count: 1195 Reputation: 467 Joined: 11/15/11 Last Seen: April 11, 2023 Author Share Posted June 6, 2012 Some updates regarding this: http://rathena.org/board/topic/58877-r15572-new-gm-commands-permissions-system/page__st__60 3 suggestions on the last page that should be added Link to comment Share on other sites More sharing options...
Recommended Posts